Blank error message after chaning password and using credential provider again |
||
Issue descriptionChrome Version: 72.0.3604.0 OS: Win10 What steps will reproduce the problem? (1) Use credential provider to sign in to machine with a google account (2) Go to admin console and change password of the account (3) Sign out of the machine (4) Use credential provider to sign in to machine with same google account as step 1 What is the expected result? Get an error dialog that password is incorrect. What happens instead? Get an error dialog with a blank message.
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7732159f9ff394cd39c76d783dc99ed87a2e200a commit 7732159f9ff394cd39c76d783dc99ed87a2e200a Author: Roger Tawa <rogerta@chromium.org> Date: Wed Nov 07 22:15:23 2018 Fix blank error dialog from credential provider. When the user enters an old password into the credential provider after a password change, make sure to use an appropriate message. At the same time make sure that all error paths return a valid string otherwise a blank error will be shown. Bug: 902706 Change-Id: I2835f8b11d8f1f116e64333d47515115b642b066 Reviewed-on: https://chromium-review.googlesource.com/c/1323270 Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#606179} [modify] https://crrev.com/7732159f9ff394cd39c76d783dc99ed87a2e200a/chrome/credential_provider/gaiacp/gaia_credential.cc [modify] https://crrev.com/7732159f9ff394cd39c76d783dc99ed87a2e200a/chrome/credential_provider/gaiacp/gaia_credential_base.cc [modify] https://crrev.com/7732159f9ff394cd39c76d783dc99ed87a2e200a/chrome/credential_provider/gaiacp/gaia_resources.grd [add] https://crrev.com/7732159f9ff394cd39c76d783dc99ed87a2e200a/chrome/credential_provider/gaiacp/gaia_resources_grd/IDS_INVALID_PASSWORD.png.sha1 [modify] https://crrev.com/7732159f9ff394cd39c76d783dc99ed87a2e200a/chrome/credential_provider/gaiacp/reauth_credential.cc
,
Nov 8
|
||
►
Sign in to add a comment |
||
Comment 1 by rogerta@chromium.org
, Nov 7