New issue
Advanced search Search tips

Issue 902696 link

Starred by 2 users
Status: Fixed
Owner:
h...@chromium.org
Closed: Nov 8
Cc:
r...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 894363



Sign in to add a comment

win-libfuzzer-asan-rel bot fails with tip-of-tree clang

Project Member Reported by h...@chromium.org, Nov 7 
Trying to roll in the new clang, https://chromium-review.googlesource.com/c/chromium/src/+/1321863, the CQ failed due to this build: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win-libfuzzer-asan-rel/10915

This is a new cq bot (see Issue 893614). I didn't even know we supported this config, and it has no coverage on the clang tot waterfall :-/

Currently bisecting to see where it regressed.

Comment 1 by h...@chromium.org, Nov 7 

This is the failure:


FAILED: libGLESv2.dll libGLESv2.dll.lib libGLESv2.dll.pdb 
ninja -t msvc -e environment.x64 -- ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /IMPLIB:./libGLESv2.dll.lib /DLL /OUT:./libGLESv2.dll /PDB:./libGLESv2.dll.pdb @./libGLESv2.dll.rsp
lld-link: error: relocation against symbol in discarded section: .text
lld-link: error: relocation against symbol in discarded section: .text
lld-link: error: relocation against symbol in discarded section: .text
lld-link: error: relocation against symbol in discarded section: .text
lld-link: error: relocation against symbol in discarded section: .text
lld-link: error: relocation against symbol in discarded section: .text
lld-link: error: relocation against symbol in discarded section: .text
lld-link: error: relocation against symbol in discarded section: .text
lld-link: error: relocation against symbol in discarded section: .text
lld-link: error: relocation against symbol in discarded section: .text
lld-link: error: relocation against symbol in discarded section: .text
lld-link: error: relocation against symbol in discarded section: .text
lld-link: error: relocation against symbol in discarded section: .text
lld-link: error: relocation against symbol in discarded section: .text
lld-link: error: relocation against symbol in discarded section: .text
lld-link: error: relocation against symbol in discarded section: .text
lld-link: error: relocation against symbol in discarded section: .text
lld-link: error: relocation against symbol in discarded section: .text
lld-link: error: relocation against symbol in discarded section: .text
lld-link: error: relocation against symbol in discarded section: .text


gn args:

dcheck_always_on = true
enable_nacl = false
ffmpeg_branding = "Chrome"
is_asan = true
is_component_build = false
is_debug = false
pdf_enable_xfa = true
proprietary_codecs = true
strip_absolute_paths_from_debug_symbols = true
symbol_level = 1
use_goma = true
use_libfuzzer = true

Comment 2 by h...@chromium.org, Nov 7 

Bisection is down to:

good - 344447
bad  - 344464

Comment 3 by h...@chromium.org, Nov 7 

Argh, no it's

good - 344344
bad  - 344464

Comment 4 by h...@chromium.org, Nov 7 

Suspects:

------------------------------------------------------------------------
r344345 | dor1s | 2018-10-12 15:59:31 +0200 (Fri, 12 Oct 2018) | 15 lines

[SanitizerCoverage] Make Inline8bit and TracePC counters dead stripping resistant.

Summary:
Otherwise, at least on Mac, the linker eliminates unused symbols which
causes libFuzzer to error out due to a mismatch of the sizes of coverage tables.

Issue in Chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=892167

Reviewers: morehouse, kcc, george.karpenkov

Reviewed By: morehouse

Subscribers: kubamracek, llvm-commits

Differential Revision: https://reviews.llvm.org/D53113
------------------------------------------------------------------------

------------------------------------------------------------------------
r344391 | metzman | 2018-10-12 20:11:47 +0200 (Fri, 12 Oct 2018) | 18 lines

[SanitizerCoverage] Prevent /OPT:REF from stripping constructors

Summary:
Linking with the /OPT:REF linker flag when building COFF files causes
the linker to strip SanitizerCoverage's constructors. Prevent this by
giving the constructors WeakODR linkage and by passing the linker a
directive to include sancov.module_ctor.

Include a test in compiler-rt to verify libFuzzer can be linked using
/OPT:REF

Reviewers: morehouse, rnk

Reviewed By: morehouse, rnk

Subscribers: rnk, morehouse, hiraditya

Differential Revision: https://reviews.llvm.org/D52119
------------------------------------------------------------------------

------------------------------------------------------------------------
r344433 | kcc | 2018-10-13 01:21:48 +0200 (Sat, 13 Oct 2018) | 15 lines

move GetOrCreateFunctionComdat to Instrumentation.cpp/Instrumentation.h

Summary:
GetOrCreateFunctionComdat is currently used in SanitizerCoverage,
where it's defined. I'm planing to use it in HWASAN as well,
so moving it into a common location.
NFC

Reviewers: morehouse

Reviewed By: morehouse

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D53218
------------------------------------------------------------------------

Comment 5 by h...@chromium.org, Nov 7 

r344391 is good

Comment 6 by h...@chromium.org, Nov 7 

r344433 is bad

Comment 7 by h...@chromium.org, Nov 8

Cc: r...@chromium.org
Status: Fixed (was: Assigned)
rnk fixed in r346381

And I now realize I forgot to cc him :-(

We need a ToT bot for this; filed Issue 903078.
►

Sign in to add a comment