Collapse/uncollapse doesn't remember state with back-button |
|||
Issue descriptionTake https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20-%20builder/37113 for example. Start out with the "Default" selection. All elements are collapsed: http://shortn/_DUzRK1WXqb Now open measurements and press a log link: http://shortn/_yXRaYH2C6G On the logdog page press either "Back to build" or the browser's back button (makes no difference). Result: measurements is collapsed again. Expectation: measurements should still be open. Repeat the same workflow, but instead of opening measurements, select "Expanded", which opens all nodes. After pressing the back button, "Expanded" is still selected, but all nodes are closed. Version: 3594-050869a
,
Nov 7
Oh, my workaround is to just open those nodes again :) It's just not very convenient. It's also not a big deal, i.e. severity is rather low I guess. It is a bit strange though that when "Expanded" is selected, that selection stays, but the nodes close. That's somewhat inconsistent.
,
Nov 7
Like sergiyb said, I think this is non-trivial to fix, it would involve saving the DOM state for every build as a cookie. But I agree it's not ideal.
,
Nov 7
The reason "Expanded" works is that the Show preference is saved in cookies, but not the individual steps. Perhaps we can use cookie after all as long as we keep them limited to the current session such that they do not grow with every expanded/collapsed step on every visited build.
,
Nov 7
You can scope cookies to individual pages.
,
Nov 7
Good point. Still I'd prefer them to have some reasonable expiration date, e.g. 1 month. Otherwise, cookies will continue to be store in browser for build pages that the user will never visit again. |
|||
►
Sign in to add a comment |
|||
Comment 1 by serg...@chromium.org
, Nov 7