New issue
Advanced search Search tips

Issue 902661 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Some of tests in perf_tests/dom can be moved into perf_tests/Editing

Project Member Reported by hayato@chromium.org, Nov 7

Issue description

It looks some of tests in perf_tests/dom can be moved into perf_tests/Editing.

For example, it looks addRange should be in perf_tests/Editing, as per the description of https://codereview.chromium.org/2878333003.

The related issue: https://bugs.chromium.org/p/chromium/issues/detail?id=887204

 
Cc: yoichio@chromium.org
Owner: yosin@chromium.org
yosin@ (or yoichio@),

Could you move some tests from perf_tests/dom to perf_tests/Editing?

It would be okay that you could tell me that which tests should be moved.
I'll move that.
Many of tests are for Editing:)

addRange.html
delete-in-password-field.html
div-editable.html
inner_html_with_selection.html
move-down-with-hidden-elements.html
move-up-with-hidden-elements.html
remove_child_with_selection.html
textarea-dom.html
textarea-edit.html
Owner: ----
Status: Available (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d0d6043a6ddec2191a18e0e6305c962a54f2330

commit 0d0d6043a6ddec2191a18e0e6305c962a54f2330
Author: Hayato Ito <hayato@chromium.org>
Date: Fri Nov 09 03:30:29 2018

Move several perf_tests from dom to Editing

See  bug 902661  for the context. Several tests in perf_test/DOM should be in
perf_tests/Editing.

Bug:  902661 
Change-Id: I9e668181f4642f989c62bf2511af6ca71dd523fe
Reviewed-on: https://chromium-review.googlesource.com/c/1325271
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606724}
[rename] https://crrev.com/0d0d6043a6ddec2191a18e0e6305c962a54f2330/third_party/blink/perf_tests/editing/addRange.html
[rename] https://crrev.com/0d0d6043a6ddec2191a18e0e6305c962a54f2330/third_party/blink/perf_tests/editing/delete-in-password-field.html
[rename] https://crrev.com/0d0d6043a6ddec2191a18e0e6305c962a54f2330/third_party/blink/perf_tests/editing/div-editable.html
[rename] https://crrev.com/0d0d6043a6ddec2191a18e0e6305c962a54f2330/third_party/blink/perf_tests/editing/inner_html_with_selection.html
[rename] https://crrev.com/0d0d6043a6ddec2191a18e0e6305c962a54f2330/third_party/blink/perf_tests/editing/move-down-with-hidden-elements.html
[rename] https://crrev.com/0d0d6043a6ddec2191a18e0e6305c962a54f2330/third_party/blink/perf_tests/editing/move-up-with-hidden-elements.html
[rename] https://crrev.com/0d0d6043a6ddec2191a18e0e6305c962a54f2330/third_party/blink/perf_tests/editing/remove_child_with_selection.html
[rename] https://crrev.com/0d0d6043a6ddec2191a18e0e6305c962a54f2330/third_party/blink/perf_tests/editing/textarea-dom.html
[rename] https://crrev.com/0d0d6043a6ddec2191a18e0e6305c962a54f2330/third_party/blink/perf_tests/editing/textarea-edit.html

Owner: hayato@chromium.org
Status: Fixed (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3038dbde431da9858e3b090af903c654aeb96972

commit 3038dbde431da9858e3b090af903c654aeb96972
Author: Hayato Ito <hayato@chromium.org>
Date: Mon Nov 19 13:22:51 2018

Update perf_tests/dom owners

A follow-up CL of https://crrev.com/c/1325271.

BUG= 902661 ,903666

Change-Id: I877f4239ffb8ab92225086968dca5dbb729678cf
Reviewed-on: https://chromium-review.googlesource.com/c/1328541
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#609265}
[modify] https://crrev.com/3038dbde431da9858e3b090af903c654aeb96972/tools/perf/benchmark.csv
[modify] https://crrev.com/3038dbde431da9858e3b090af903c654aeb96972/tools/perf/benchmarks/blink_perf.py

Sign in to add a comment