New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 902657 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Last visit 15 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocked on:
issue 902660



Sign in to add a comment

Intent picker UI should not be auto displayed after 2+ dismissals

Project Member Reported by djacobo@chromium.org, Nov 7

Issue description

This is a Crbug counterpart for b/67652705. Briefly, we want to implement a service that can keep a counter on how many times the user has dismissed the intent picker UI, this should be url based, persisted across sessions and not synced between multiple devices.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/623d492210f53775d50dc67bee193fb1142ae726

commit 623d492210f53775d50dc67bee193fb1142ae726
Author: David Jacobo <djacobo@chromium.org>
Date: Thu Nov 08 22:35:15 2018

Adds skeleton for IntentPickerAutoDisplayService

IntentPickerAutoDisplayService is a KeyedService (including a factory
class) so intent picker UI can locally (i.e. within Chrome) check if
such UI has been displayed before without the user taking action.

The user ignoring the UI should be remembered, so we stop
auto-displaying the UI and instead only show an entry icon in the
omnibox, where the UI will be one-click away.

Bug: 902657
Test: Build.
Change-Id: I2e0333b8c7eba3af78a671a4f119b7c26fcc5283
Reviewed-on: https://chromium-review.googlesource.com/c/1303653
Commit-Queue: David Jacobo <djacobo@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606623}
[modify] https://crrev.com/623d492210f53775d50dc67bee193fb1142ae726/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/623d492210f53775d50dc67bee193fb1142ae726/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/623d492210f53775d50dc67bee193fb1142ae726/chrome/browser/chromeos/apps/intent_helper/apps_navigation_throttle.cc
[modify] https://crrev.com/623d492210f53775d50dc67bee193fb1142ae726/chrome/browser/chromeos/apps/intent_helper/apps_navigation_throttle.h
[add] https://crrev.com/623d492210f53775d50dc67bee193fb1142ae726/chrome/browser/chromeos/apps/intent_helper/intent_picker_auto_display_pref.cc
[add] https://crrev.com/623d492210f53775d50dc67bee193fb1142ae726/chrome/browser/chromeos/apps/intent_helper/intent_picker_auto_display_pref.h
[add] https://crrev.com/623d492210f53775d50dc67bee193fb1142ae726/chrome/browser/chromeos/apps/intent_helper/intent_picker_auto_display_service.cc
[add] https://crrev.com/623d492210f53775d50dc67bee193fb1142ae726/chrome/browser/chromeos/apps/intent_helper/intent_picker_auto_display_service.h
[add] https://crrev.com/623d492210f53775d50dc67bee193fb1142ae726/chrome/browser/chromeos/apps/intent_helper/intent_picker_auto_display_service_factory.cc
[add] https://crrev.com/623d492210f53775d50dc67bee193fb1142ae726/chrome/browser/chromeos/apps/intent_helper/intent_picker_auto_display_service_factory.h
[modify] https://crrev.com/623d492210f53775d50dc67bee193fb1142ae726/chrome/browser/ui/views/location_bar/intent_picker_view.cc
[modify] https://crrev.com/623d492210f53775d50dc67bee193fb1142ae726/chrome/browser/ui/webui/site_settings_helper.cc
[modify] https://crrev.com/623d492210f53775d50dc67bee193fb1142ae726/components/content_settings/core/browser/website_settings_registry.cc
[modify] https://crrev.com/623d492210f53775d50dc67bee193fb1142ae726/components/content_settings/core/common/content_settings.cc
[modify] https://crrev.com/623d492210f53775d50dc67bee193fb1142ae726/components/content_settings/core/common/content_settings_types.h
[modify] https://crrev.com/623d492210f53775d50dc67bee193fb1142ae726/tools/metrics/histograms/enums.xml

Blockedon: 902660
Status: Started (was: Untriaged)

Sign in to add a comment