CRAS: Crash in init_and_attach_streams |
||||||||
Issue descriptionStable signature: init_and_attach_streams-aae66bca Example report ID: 76c938b5d574bf82 Link: https://crash.corp.google.com/76c938b5d574bf82 OS version: 11210.0.0 Stack trace: cras_iodev_list.c 659 init_and_attach_streams cras_iodev_list.c 712 init_device_cb cras_tm.c 142 cras_tm_call_callbacks cras_server.c 597 cras_server_run cras.c 141 main libc-start.c 289 __libc_start_main 0 _start 0 0 _init It started to happen between 11021.34.0 and 11021.51.0 Chrome version: 70.0.3538.69, Chrome OS version: 11021.51.0 page_loads: 43720157, num crashes: 411, crash_ppm 9.400698 ---------------------------------------- Top 3 crashes num_crash product.Version stable_signature 155 11021.51.0 init_and_attach_streams-aae66bca 125 11021.51.0 hfp_buf_queued-9c163718 20 11021.51.0 cras_bt_adapter_get-7f90a379 ======================================== Chrome version: 70.0.3538.41, Chrome OS version: 11021.34.0 page_loads: 24194374, num crashes: 163, crash_ppm 6.737103 ---------------------------------------- Top 3 crashes num_crash product.Version stable_signature 23 11021.34.0 flush_data-c505b7ae 21 11021.34.0 cras_bt_adapter_get-7b5dc82b 16 11021.34.0 hfp_buf_queued-9c163718
,
Nov 9
Unfortunately this crash happens starting M70. Sorry for not finding it out sooner. Geo - do we still have plan to push M-70?
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/bd50d48882ba769f3b6743704d8deade7d2cd1d1 commit bd50d48882ba769f3b6743704d8deade7d2cd1d1 Author: Hsin-Yu Chao <hychao@google.com> Date: Fri Nov 09 15:19:56 2018 CRAS: iodev_list - Fix init retry crash Commit 380919c441 generalizes init retry to pin stream/device. We should take into account the case that hotplug device no longer exists in iodev list when init retry is called. BUG=chromium:902655 TEST=None Change-Id: I095272f161cebcd832679d228358642200da5293 Reviewed-on: https://chromium-review.googlesource.com/1322297 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Hsinyu Chao <hychao@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> [modify] https://crrev.com/bd50d48882ba769f3b6743704d8deade7d2cd1d1/cras/src/server/cras_iodev_list.c
,
Nov 12
,
Nov 12
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 12
Approved for ChromeOS M71
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/826fc8fbbd40d919b0c3800e984e4d188c52a9d7 commit 826fc8fbbd40d919b0c3800e984e4d188c52a9d7 Author: Hsin-Yu Chao <hychao@google.com> Date: Tue Nov 13 03:14:09 2018 CRAS: iodev_list - Fix init retry crash Commit 380919c441 generalizes init retry to pin stream/device. We should take into account the case that hotplug device no longer exists in iodev list when init retry is called. BUG=chromium:902655 TEST=None Change-Id: I095272f161cebcd832679d228358642200da5293 Reviewed-on: https://chromium-review.googlesource.com/1322297 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Hsinyu Chao <hychao@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> (cherry picked from commit bd50d48882ba769f3b6743704d8deade7d2cd1d1) Reviewed-on: https://chromium-review.googlesource.com/c/1333208 Reviewed-by: Hsinyu Chao <hychao@chromium.org> Commit-Queue: Hsinyu Chao <hychao@chromium.org> [modify] https://crrev.com/826fc8fbbd40d919b0c3800e984e4d188c52a9d7/cras/src/server/cras_iodev_list.c
,
Nov 13
Done merge to 71, request for 70. For justification, this crash affects hot-plug audio devices, like USB and BT.
,
Nov 15
Has this been tested? How did the testing go? Thanks
,
Nov 16
The fix has been verified per crash queries: M72 (Fix landed since 11246.0.0) num_crash/product.Version/stable_signature 86 11210.0.0 init_and_attach_streams-aae66bca 5 11232.0.0 init_and_attach_streams-aae66bca 2 11197.0.0 init_and_attach_streams-aae66bca 2 11231.0.0 init_and_attach_streams-aae66bca M71 (Fix landed since 11151.29.0) num_crash/product.Version/stable_signature 288 11151.17.0 init_and_attach_streams-aae66bca 210 11151.11.0 init_and_attach_streams-aae66bca 84 11151.4.0 init_and_attach_streams-aae66bca Thanks!
,
Nov 16
Add numbers on M70: num_crash/product.Version/stable_signature 11508 11021.56.0 init_and_attach_streams-aae66bca <-- (pushed BETA) 159 11021.51.0 init_and_attach_streams-aae66bca
,
Nov 19
Rejecting for M70. We're a few weeks from M71 Stable. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by hychao@chromium.org
, Nov 7