LayerTreeHostTestQueueImageDecodeNonLazy.RunSingleThread_DelegatingRenderer(cc_unittests) failing on multiple builders |
||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of yosin@chromium.org LayerTreeHostTestQueueImageDecodeNonLazy.RunSingleThread_DelegatingRenderer(cc_unittests failing on multiple builders) Builders failed on: - chromeos-amd64-generic-rel: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-amd64-generic-rel - Linux CFI: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI
,
Nov 7
,
Nov 7
Very likely that culprit is https://chromium-review.googlesource.com/c/chromium/src/+/1318734 enne@ could you please have a look at it?
,
Nov 7
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3212ece48ac97d3930da3f5416fda93c5cfb2c88 commit 3212ece48ac97d3930da3f5416fda93c5cfb2c88 Author: Adrienne Walker <enne@chromium.org> Date: Wed Nov 07 19:29:10 2018 Disable LayerTreeHostTestQueueImageDecodeNonLazy.RunSingleThread Temporarily until the underlying cause is fixed. Bug: 902644 Change-Id: I29715b17af02e48a79319f61c1a32617dc872763 Reviewed-on: https://chromium-review.googlesource.com/c/1323797 Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#606125} [modify] https://crrev.com/3212ece48ac97d3930da3f5416fda93c5cfb2c88/cc/trees/layer_tree_host_unittest.cc
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8672b8ae041331c37435eb274b0110c2c8341b41 commit 8672b8ae041331c37435eb274b0110c2c8341b41 Author: Adrienne Walker <enne@chromium.org> Date: Wed Nov 07 22:19:53 2018 Disable LayerTreeHostTestQueueImageDecodeNonLazy.* Followup to 3212ece48ac97d3 which only handled single thread. FindIt indicates that multithread is at fault as well. Bug: 902644 Change-Id: If774e275f4a7f146993661ac4472978856eb1b00 Reviewed-on: https://chromium-review.googlesource.com/c/1324416 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#606182} [modify] https://crrev.com/8672b8ae041331c37435eb274b0110c2c8341b41/cc/trees/layer_tree_host_unittest.cc
,
Nov 8
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0cd20e8caf2b90933e61bd511819312cebacd16 commit e0cd20e8caf2b90933e61bd511819312cebacd16 Author: Adrienne Walker <enne@chromium.org> Date: Thu Nov 15 05:32:44 2018 cc: Fix flaky ImageController crash If non-lazy tasks are queued but never executed, it would still try to unref them, causing a crash. Add some tests to make sure that lazy and non-lazy images get unref'd (or not) appropriately and reenable the test. Bug: 902644 , 902022 ,905239 Change-Id: I778d81aa390c1a529b7bfd88a2e146f245fb35e5 Reviewed-on: https://chromium-review.googlesource.com/c/1324874 Commit-Queue: enne <enne@chromium.org> Reviewed-by: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#608271} [modify] https://crrev.com/e0cd20e8caf2b90933e61bd511819312cebacd16/cc/tiles/image_controller.cc [modify] https://crrev.com/e0cd20e8caf2b90933e61bd511819312cebacd16/cc/tiles/image_controller_unittest.cc [modify] https://crrev.com/e0cd20e8caf2b90933e61bd511819312cebacd16/cc/trees/layer_tree_host_unittest.cc
,
Nov 15
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/606c4393a4200bbdb1e85e969db8b66540004189 commit 606c4393a4200bbdb1e85e969db8b66540004189 Author: Adrienne Walker <enne@chromium.org> Date: Mon Nov 19 21:51:35 2018 cc: Fix flaky ImageController crash If non-lazy tasks are queued but never executed, it would still try to unref them, causing a crash. Add some tests to make sure that lazy and non-lazy images get unref'd (or not) appropriately and reenable the test. TBR=enne@chromium.org (cherry picked from commit e0cd20e8caf2b90933e61bd511819312cebacd16) Bug: 902644 , 902022 ,905239 Change-Id: I778d81aa390c1a529b7bfd88a2e146f245fb35e5 Reviewed-on: https://chromium-review.googlesource.com/c/1324874 Commit-Queue: enne <enne@chromium.org> Reviewed-by: Khushal <khushalsagar@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#608271} Reviewed-on: https://chromium-review.googlesource.com/c/1343339 Reviewed-by: enne <enne@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#758} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/606c4393a4200bbdb1e85e969db8b66540004189/cc/tiles/image_controller.cc [modify] https://crrev.com/606c4393a4200bbdb1e85e969db8b66540004189/cc/tiles/image_controller_unittest.cc
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/606c4393a4200bbdb1e85e969db8b66540004189 Commit: 606c4393a4200bbdb1e85e969db8b66540004189 Author: enne@chromium.org Commiter: enne@chromium.org Date: 2018-11-19 21:51:35 +0000 UTC cc: Fix flaky ImageController crash If non-lazy tasks are queued but never executed, it would still try to unref them, causing a crash. Add some tests to make sure that lazy and non-lazy images get unref'd (or not) appropriately and reenable the test. TBR=enne@chromium.org (cherry picked from commit e0cd20e8caf2b90933e61bd511819312cebacd16) Bug: 902644 , 902022 ,905239 Change-Id: I778d81aa390c1a529b7bfd88a2e146f245fb35e5 Reviewed-on: https://chromium-review.googlesource.com/c/1324874 Commit-Queue: enne <enne@chromium.org> Reviewed-by: Khushal <khushalsagar@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#608271} Reviewed-on: https://chromium-review.googlesource.com/c/1343339 Reviewed-by: enne <enne@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#758} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by yosin@chromium.org
, Nov 7Components: Internals>Compositing
Status: Untriaged (was: Available)