New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocked on:
issue 912848

Blocking:
issue 748389
issue 759519
issue 807998



Sign in to add a comment
link

Issue 902633: (Re)Implement streams in C++

Reported by yhirano@chromium.org, Nov 7 Project Member

Issue description

(Re)Implement streams in C++
 

Comment 1 by yhirano@chromium.org, Nov 7

Status: Available (was: Untriaged)

Comment 2 by domenic@chromium.org, Nov 7

I see a CL is in flight at https://chromium-review.googlesource.com/c/chromium/src/+/1319222. It seems like there is an incremental strategy in progress, instead of e.g. re-doing everything in idiomatic IDL and C++. For example a lot of usage of any, and only converting ReadableStream, not all streams classes at once.

Would someone mind summarizing the strategy, to better give context for reviews and spec work?

Comment 3 by bugdroid1@chromium.org, Nov 8

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/e2f0a90ec6e47284f1cb14290b79b137369de3cd

commit e2f0a90ec6e47284f1cb14290b79b137369de3cd
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Thu Nov 08 21:18:36 2018

Introduce Promise::MarkAsHandled

We are migrating streams implementation from JavaScript (v8Extra) to
C++. One of missing features is an ability to set
promise.[[PromiseIsHandled]] to true, used for example in
https://streams.spec.whatwg.org/#rs-pipe-through. This CL introduces
the feature.

Bug:  chromium:894357 ,  chromium:888154 , chromium:902633
Change-Id: If6487b29a74a212761e6d2ef04ef3ca0e6957dce
Reviewed-on: https://chromium-review.googlesource.com/c/1322296
Reviewed-by: Adam Klein <adamk@chromium.org>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57370}
[modify] https://crrev.com/e2f0a90ec6e47284f1cb14290b79b137369de3cd/include/v8.h
[modify] https://crrev.com/e2f0a90ec6e47284f1cb14290b79b137369de3cd/src/api.cc
[modify] https://crrev.com/e2f0a90ec6e47284f1cb14290b79b137369de3cd/test/cctest/test-api.cc

Comment 4 by yhirano@chromium.org, Nov 9

What I'm doing right now is "D: Introduce a thin ScriptWrappable"[1]. It's needed for TransferableStreams. Defining ScriptWrappable ReadableStream, WritableStream and TransformStreams is needed for the work.

Internal algorithms are still written in JavaScript at this stage. We will re-implement the logic in C++ probably in 2019.

https://docs.google.com/document/d/1_KuZzg5c3pncLJPFa8SuVm23AP4tft6mzPCL5at3I9M/edit#heading=h.egunr8797a77

Comment 5 by bugdroid1@chromium.org, Nov 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc41111f3dfe8208b56d02c2d7efc5bef40dcfc9

commit cc41111f3dfe8208b56d02c2d7efc5bef40dcfc9
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Nov 09 05:39:22 2018

Introduce blink::ReadableStream

Introduce blink::ReadableStream which is a ScriptWrappable. This CL
doesn't change the behavior because the interface is not (yet) exposed.

Bug:  894357 ,  888165 , 902633
Change-Id: Ie0f14e0efcc7d48034fff8317ba7f70f3f8ecd3b
Reviewed-on: https://chromium-review.googlesource.com/c/1319222
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606749}
[modify] https://crrev.com/cc41111f3dfe8208b56d02c2d7efc5bef40dcfc9/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/cc41111f3dfe8208b56d02c2d7efc5bef40dcfc9/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/cc41111f3dfe8208b56d02c2d7efc5bef40dcfc9/third_party/blink/renderer/core/streams/BUILD.gn
[modify] https://crrev.com/cc41111f3dfe8208b56d02c2d7efc5bef40dcfc9/third_party/blink/renderer/core/streams/ReadableStream.js
[add] https://crrev.com/cc41111f3dfe8208b56d02c2d7efc5bef40dcfc9/third_party/blink/renderer/core/streams/readable_stream.cc
[add] https://crrev.com/cc41111f3dfe8208b56d02c2d7efc5bef40dcfc9/third_party/blink/renderer/core/streams/readable_stream.h
[add] https://crrev.com/cc41111f3dfe8208b56d02c2d7efc5bef40dcfc9/third_party/blink/renderer/core/streams/readable_stream.idl
[modify] https://crrev.com/cc41111f3dfe8208b56d02c2d7efc5bef40dcfc9/third_party/blink/renderer/core/streams/readable_stream_operations.cc
[modify] https://crrev.com/cc41111f3dfe8208b56d02c2d7efc5bef40dcfc9/third_party/blink/renderer/core/streams/readable_stream_operations.h
[add] https://crrev.com/cc41111f3dfe8208b56d02c2d7efc5bef40dcfc9/third_party/blink/renderer/core/streams/readable_stream_test.cc

Comment 6 by bugdroid1@chromium.org, Nov 9

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6105631e4f6362a083d8ad05999f21fc7918b67f

commit 6105631e4f6362a083d8ad05999f21fc7918b67f
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Fri Nov 09 09:44:10 2018

Remove ReadableStreamOperations use from BodyStreamBuffer

Replace use of ReadableStreamOperations in BodyStreamBuffer with
ReadableStream. This CL doesn't change the behavior.

Bug:  894357 ,  888165 , 902633

Change-Id: Icd478dcc59ca86e020d540229d69f0c61fb689c0
Reviewed-on: https://chromium-review.googlesource.com/c/1319408
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606775}
[modify] https://crrev.com/6105631e4f6362a083d8ad05999f21fc7918b67f/third_party/blink/renderer/core/fetch/body.cc
[modify] https://crrev.com/6105631e4f6362a083d8ad05999f21fc7918b67f/third_party/blink/renderer/core/fetch/body.h
[modify] https://crrev.com/6105631e4f6362a083d8ad05999f21fc7918b67f/third_party/blink/renderer/core/fetch/body_stream_buffer.cc
[modify] https://crrev.com/6105631e4f6362a083d8ad05999f21fc7918b67f/third_party/blink/renderer/core/fetch/body_stream_buffer.h
[modify] https://crrev.com/6105631e4f6362a083d8ad05999f21fc7918b67f/third_party/blink/renderer/core/fetch/request.cc
[modify] https://crrev.com/6105631e4f6362a083d8ad05999f21fc7918b67f/third_party/blink/renderer/core/fetch/response.cc
[modify] https://crrev.com/6105631e4f6362a083d8ad05999f21fc7918b67f/third_party/blink/renderer/core/fetch/response.h
[modify] https://crrev.com/6105631e4f6362a083d8ad05999f21fc7918b67f/third_party/blink/renderer/core/streams/readable_stream.cc
[modify] https://crrev.com/6105631e4f6362a083d8ad05999f21fc7918b67f/third_party/blink/renderer/core/streams/readable_stream.h
[modify] https://crrev.com/6105631e4f6362a083d8ad05999f21fc7918b67f/third_party/blink/renderer/core/streams/readable_stream_operations.cc
[modify] https://crrev.com/6105631e4f6362a083d8ad05999f21fc7918b67f/third_party/blink/renderer/core/streams/readable_stream_operations.h
[modify] https://crrev.com/6105631e4f6362a083d8ad05999f21fc7918b67f/third_party/blink/renderer/core/streams/readable_stream_operations_test.cc
[modify] https://crrev.com/6105631e4f6362a083d8ad05999f21fc7918b67f/third_party/blink/renderer/core/streams/readable_stream_test.cc

Comment 7 by ricea@chromium.org, Nov 9

Blocking: 748389

Comment 8 by bmeu...@chromium.org, Nov 9

Cc: bmeu...@chromium.org

Comment 9 by bugdroid1@chromium.org, Nov 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1eea35ca9bf794cf3a112a75f5672f8538f53c7

commit e1eea35ca9bf794cf3a112a75f5672f8538f53c7
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Mon Nov 12 02:35:02 2018

Expose blink::ReadableStream and blink::TransformStream

RedableStream and TransformStream have been defined in JavaScript
files. This CL changes that - now they are defined in IDL files.
ReadableStream internal implementation sill resides in
ReadableStream.js.

This CL exposes ReadableStream and TransformStream IDL interfaces and
modifies blink modules using them.

There are some compatibility issues:
 - Function lengths (e.g., ReadableStream.prototype.cancel.length)
   change.
   (external/wpt/streams/readable-streams/general*)
 - pipeThough's "generic" behavior is broken. We could use [Custom]
   extended IDL attribute to implement it, but I'm not sure if that's
   the right way, I'm letting it break for now.
   (external/wpt/streams/piping/pipe-through*)
 - attribute @@toStringTag is added to ReadableStream and
   TransformStream. (*global-interface-listing*)

Bug:  894357 ,  888165 , 902633
Change-Id: I506a78fdfae1b0bedf7618b2b05b783d663a11c2
Reviewed-on: https://chromium-review.googlesource.com/c/1322172
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607131}
[add] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/pipe-through-expected.txt
[add] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/pipe-through.dedicatedworker-expected.txt
[add] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/pipe-through.serviceworker.https-expected.txt
[add] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/pipe-through.sharedworker-expected.txt
[add] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/WebKit/LayoutTests/external/wpt/streams/readable-streams/general-expected.txt
[add] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/WebKit/LayoutTests/external/wpt/streams/readable-streams/general.dedicatedworker-expected.txt
[add] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/WebKit/LayoutTests/external/wpt/streams/readable-streams/general.serviceworker.https-expected.txt
[add] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/WebKit/LayoutTests/external/wpt/streams/readable-streams/general.sharedworker-expected.txt
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/fetch/body.cc
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/fetch/body.h
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/fetch/body_stream_buffer.cc
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/fetch/body_stream_buffer.h
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/fetch/body_stream_buffer_test.cc
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/fetch/readable_stream_bytes_consumer_test.cc
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/fetch/response.cc
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/fetch/response.idl
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/streams/ReadableStream.js
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/streams/TransformStream.js
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/streams/readable_stream.cc
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/streams/readable_stream.h
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/streams/readable_stream.idl
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/streams/readable_stream_operations.cc
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/streams/readable_stream_operations_test.cc
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/streams/readable_stream_test.cc
[add] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/streams/test_underlying_source.h
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/streams/transform_stream.cc
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/streams/transform_stream.h
[add] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/streams/transform_stream.idl
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/core/streams/transform_stream_test.cc
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/modules/encoding/text_decoder_stream.cc
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/modules/encoding/text_decoder_stream.h
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/modules/encoding/text_decoder_stream.idl
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/modules/encoding/text_encoder_stream.cc
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/modules/encoding/text_encoder_stream.h
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/modules/encoding/text_encoder_stream.idl
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/modules/filesystem/file_system_writer.cc
[modify] https://crrev.com/e1eea35ca9bf794cf3a112a75f5672f8538f53c7/third_party/blink/renderer/modules/filesystem/file_system_writer.h

Comment 10 by bugdroid1@chromium.org, Nov 27

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/552f1f3eefb76c8c63fb88c34dec45bba59c4e79

commit 552f1f3eefb76c8c63fb88c34dec45bba59c4e79
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Tue Nov 27 08:19:20 2018

Introduce blink::WritableStream

Introduce blink::WritableStream which is a ScriptWrappable.

There are some compatibility issues:
 - Function lengths (e.g., WritableStream.prototype.abort.length)
   change.
   (external/wpt/streams/writable-streams/properties*)
 - attribute @@toStringTag is added to ReadableStream and
   TransformStream. (*global-interface-listing*)

Bug:  894357 ,  888165 , 902633
Change-Id: I93762fec72a4654759a7fbe4e80b4704befac2c3
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1337220
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611042}
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/bindings/bindings.gni
[add] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/bindings/core/v8/custom/v8_writable_stream_custom.cc
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/core/streams/BUILD.gn
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/core/streams/WritableStream.js
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/core/streams/readable_stream.cc
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/core/streams/readable_stream_operations.cc
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/core/streams/readable_stream_operations.h
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/core/streams/transform_stream.cc
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/core/streams/transform_stream.h
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/core/streams/transform_stream.idl
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/core/streams/transform_stream_test.cc
[add] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/core/streams/writable_stream.cc
[add] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/core/streams/writable_stream.h
[add] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/core/streams/writable_stream.idl
[add] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/core/streams/writable_stream_test.cc
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/modules/encoding/text_decoder_stream.cc
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/modules/encoding/text_decoder_stream.h
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/modules/encoding/text_decoder_stream.idl
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/modules/encoding/text_encoder_stream.cc
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/modules/encoding/text_encoder_stream.h
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/renderer/modules/encoding/text_encoder_stream.idl
[add] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/web_tests/external/wpt/streams/writable-streams/properties.any-expected.txt
[add] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/web_tests/external/wpt/streams/writable-streams/properties.any.serviceworker-expected.txt
[add] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/web_tests/external/wpt/streams/writable-streams/properties.any.sharedworker-expected.txt
[add] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/web_tests/external/wpt/streams/writable-streams/properties.any.worker-expected.txt
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/web_tests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/web_tests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/552f1f3eefb76c8c63fb88c34dec45bba59c4e79/third_party/blink/web_tests/webexposed/global-interface-listing-shared-worker-expected.txt

Comment 11 by ricea@chromium.org, Dec 4

Blocking: 759519

Comment 12 by ricea@chromium.org, Dec 4

Labels: -Pri-3 M-75 Pri-2
This is planned for Q1 2019. I am tentatively targeting M75, although it's quite likely we won't completely switch over until a later release.

Comment 13 by yhirano@chromium.org, Dec 7

Blockedon: 912848

Comment 14 by bugdroid1@chromium.org, Jan 15

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7ece1e208de3215928a8c91d971945b83ca1267

commit b7ece1e208de3215928a8c91d971945b83ca1267
Author: Adam Rice <ricea@chromium.org>
Date: Tue Jan 15 14:01:13 2019

Make blink::WritableStream a pure virtual class

In preparation for adding the native implementation, rename the existing
implementation to blink::WritableStreamWrapper and make
blink::WritableStream be a virtual base class for it. When the native
implementation is added, Create() methods and other places that need to
work with the real type will check a runtime flag.

BUG=902633

Change-Id: I97c6b4e5b1461b0b3b0092773db60644b3711b5f
Reviewed-on: https://chromium-review.googlesource.com/c/1405954
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622843}
[modify] https://crrev.com/b7ece1e208de3215928a8c91d971945b83ca1267/third_party/blink/renderer/bindings/core/v8/custom/v8_writable_stream_custom.cc
[modify] https://crrev.com/b7ece1e208de3215928a8c91d971945b83ca1267/third_party/blink/renderer/core/streams/BUILD.gn
[modify] https://crrev.com/b7ece1e208de3215928a8c91d971945b83ca1267/third_party/blink/renderer/core/streams/readable_stream.cc
[modify] https://crrev.com/b7ece1e208de3215928a8c91d971945b83ca1267/third_party/blink/renderer/core/streams/transform_stream.cc
[modify] https://crrev.com/b7ece1e208de3215928a8c91d971945b83ca1267/third_party/blink/renderer/core/streams/writable_stream.cc
[modify] https://crrev.com/b7ece1e208de3215928a8c91d971945b83ca1267/third_party/blink/renderer/core/streams/writable_stream.h
[add] https://crrev.com/b7ece1e208de3215928a8c91d971945b83ca1267/third_party/blink/renderer/core/streams/writable_stream_wrapper.cc
[add] https://crrev.com/b7ece1e208de3215928a8c91d971945b83ca1267/third_party/blink/renderer/core/streams/writable_stream_wrapper.h

Comment 15 by ricea@chromium.org, Jan 24

Owner: ricea@chromium.org
Status: Started (was: Available)

Comment 16 by bugdroid, Jan 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eed622fffedeb63df9638d081bdadec5cc60071c

commit eed622fffedeb63df9638d081bdadec5cc60071c
Author: Adam Rice <ricea@chromium.org>
Date: Wed Jan 30 07:52:42 2019

C++ port of miscellaneous stream operations

Port the functions from the "Miscellaneous Operations" section of the
standard to C++.

The "Queue-with-sizes" operations are split into a separate header file
as they are logically distinct.

This CL also defines abstract classes "StrategySizeAlgorithm" and
"StreamAlgorithm" to represent the algorithms used in the standard.

The new functions are not yet used, but are groundwork for adding stream
implementations.

See the design doc at
https://docs.google.com/document/d/1n0IIRmJb0R-DFc2IhhJfS2-LUwl6iKSBNaR0klr3o40/edit

Bug: 902633
Change-Id: Ifb6b188ba20fe0640c2a008bc173c0c6615e572a
Reviewed-on: https://chromium-review.googlesource.com/c/1421417
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627344}
[modify] https://crrev.com/eed622fffedeb63df9638d081bdadec5cc60071c/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/eed622fffedeb63df9638d081bdadec5cc60071c/third_party/blink/renderer/core/streams/BUILD.gn
[add] https://crrev.com/eed622fffedeb63df9638d081bdadec5cc60071c/third_party/blink/renderer/core/streams/miscellaneous_operations.cc
[add] https://crrev.com/eed622fffedeb63df9638d081bdadec5cc60071c/third_party/blink/renderer/core/streams/miscellaneous_operations.h
[add] https://crrev.com/eed622fffedeb63df9638d081bdadec5cc60071c/third_party/blink/renderer/core/streams/miscellaneous_operations_test.cc
[add] https://crrev.com/eed622fffedeb63df9638d081bdadec5cc60071c/third_party/blink/renderer/core/streams/queue_with_sizes.cc
[add] https://crrev.com/eed622fffedeb63df9638d081bdadec5cc60071c/third_party/blink/renderer/core/streams/queue_with_sizes.h
[add] https://crrev.com/eed622fffedeb63df9638d081bdadec5cc60071c/third_party/blink/renderer/core/streams/queue_with_sizes_test.cc
[add] https://crrev.com/eed622fffedeb63df9638d081bdadec5cc60071c/third_party/blink/renderer/core/streams/stream_algorithms.h

Comment 17 by bugdroid, Jan 31

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4047b61899853e97218e5b7b2de3b4a45b1b38c6

commit 4047b61899853e97218e5b7b2de3b4a45b1b38c6
Author: Adam Rice <ricea@chromium.org>
Date: Thu Jan 31 09:57:54 2019

Add StreamStartAlgorithm type

StartAlgorithms are different from other promise-returning algorithms in
the streams standard in that they can throw an exception. Add a new
StreamStartAlgorithm base class to represent them, and a
CreateStartAlgorithm() function to create ones from JavaScript.

Design doc:
https://docs.google.com/document/d/1n0IIRmJb0R-DFc2IhhJfS2-LUwl6iKSBNaR0klr3o40/edit

BUG=902633

Change-Id: I0995aa21bbec51ab206a4affc54d861b2c325db4
Reviewed-on: https://chromium-review.googlesource.com/c/1445342
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627877}
[modify] https://crrev.com/4047b61899853e97218e5b7b2de3b4a45b1b38c6/third_party/blink/renderer/core/streams/miscellaneous_operations.cc
[modify] https://crrev.com/4047b61899853e97218e5b7b2de3b4a45b1b38c6/third_party/blink/renderer/core/streams/miscellaneous_operations.h
[modify] https://crrev.com/4047b61899853e97218e5b7b2de3b4a45b1b38c6/third_party/blink/renderer/core/streams/miscellaneous_operations_test.cc
[modify] https://crrev.com/4047b61899853e97218e5b7b2de3b4a45b1b38c6/third_party/blink/renderer/core/streams/stream_algorithms.h

Comment 18 by bugdroid, Jan 31

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf388b2ee44f97e8b17252d0bc1cfb032c794012

commit bf388b2ee44f97e8b17252d0bc1cfb032c794012
Author: Adam Rice <ricea@chromium.org>
Date: Thu Jan 31 10:33:19 2019

Add StreamPromiseResolver

StreamPromiseResolver is a garbage-collected wrapper for
v8::Promise::Resolver that provides semantics matching those used for
promises in the streams standard.

Also add StreamScriptFunction, a subclass of ScriptFunction that avoids
the round-trip through ScriptValue, and StreamThenPromise(), a shortcut
for performing a Then operation where the functions are defined as
StreamScriptFunctions.

See design doc at
https://docs.google.com/document/d/1n0IIRmJb0R-DFc2IhhJfS2-LUwl6iKSBNaR0klr3o40/edit

BUG=902633

Change-Id: Ie363fb207a253a26a4bb622c50c304524d8651be
Reviewed-on: https://chromium-review.googlesource.com/c/1445571
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627888}
[modify] https://crrev.com/bf388b2ee44f97e8b17252d0bc1cfb032c794012/third_party/blink/renderer/core/BUILD.gn
[modify] https://crrev.com/bf388b2ee44f97e8b17252d0bc1cfb032c794012/third_party/blink/renderer/core/streams/BUILD.gn
[add] https://crrev.com/bf388b2ee44f97e8b17252d0bc1cfb032c794012/third_party/blink/renderer/core/streams/stream_promise_resolver.cc
[add] https://crrev.com/bf388b2ee44f97e8b17252d0bc1cfb032c794012/third_party/blink/renderer/core/streams/stream_promise_resolver.h
[add] https://crrev.com/bf388b2ee44f97e8b17252d0bc1cfb032c794012/third_party/blink/renderer/core/streams/stream_promise_resolver_test.cc
[add] https://crrev.com/bf388b2ee44f97e8b17252d0bc1cfb032c794012/third_party/blink/renderer/core/streams/stream_script_function.cc
[add] https://crrev.com/bf388b2ee44f97e8b17252d0bc1cfb032c794012/third_party/blink/renderer/core/streams/stream_script_function.h

Comment 19 by bugdroid, Feb 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a01730deff50c05bafc8e0d87fc08c343baf4b9a

commit a01730deff50c05bafc8e0d87fc08c343baf4b9a
Author: Adam Rice <ricea@chromium.org>
Date: Fri Feb 01 07:37:49 2019

Add IDL files for native WritableStream

See design doc at
https://docs.google.com/document/d/1n0IIRmJb0R-DFc2IhhJfS2-LUwl6iKSBNaR0klr3o40/edit

BUG=902633

Change-Id: I90b2f4e0791b382da6ed5803525e2e0c3ef4075e
Reviewed-on: https://chromium-review.googlesource.com/c/1446267
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628258}
[modify] https://crrev.com/a01730deff50c05bafc8e0d87fc08c343baf4b9a/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/a01730deff50c05bafc8e0d87fc08c343baf4b9a/third_party/blink/renderer/core/streams/BUILD.gn
[add] https://crrev.com/a01730deff50c05bafc8e0d87fc08c343baf4b9a/third_party/blink/renderer/core/streams/writable_stream_default_controller.cc
[add] https://crrev.com/a01730deff50c05bafc8e0d87fc08c343baf4b9a/third_party/blink/renderer/core/streams/writable_stream_default_controller.h
[add] https://crrev.com/a01730deff50c05bafc8e0d87fc08c343baf4b9a/third_party/blink/renderer/core/streams/writable_stream_default_controller.idl
[add] https://crrev.com/a01730deff50c05bafc8e0d87fc08c343baf4b9a/third_party/blink/renderer/core/streams/writable_stream_default_writer.cc
[add] https://crrev.com/a01730deff50c05bafc8e0d87fc08c343baf4b9a/third_party/blink/renderer/core/streams/writable_stream_default_writer.h
[add] https://crrev.com/a01730deff50c05bafc8e0d87fc08c343baf4b9a/third_party/blink/renderer/core/streams/writable_stream_default_writer.idl
[add] https://crrev.com/a01730deff50c05bafc8e0d87fc08c343baf4b9a/third_party/blink/renderer/core/streams/writable_stream_native.cc
[add] https://crrev.com/a01730deff50c05bafc8e0d87fc08c343baf4b9a/third_party/blink/renderer/core/streams/writable_stream_native.h
[modify] https://crrev.com/a01730deff50c05bafc8e0d87fc08c343baf4b9a/third_party/blink/renderer/platform/runtime_enabled_features.json5

Comment 20 by bugdroid, Feb 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b2a55fe69fc9ab71f713959f305b62ad08e227d

commit 2b2a55fe69fc9ab71f713959f305b62ad08e227d
Author: Keishi Hattori <keishi@chromium.org>
Date: Fri Feb 01 09:05:32 2019

Revert "Add StreamStartAlgorithm type"

This reverts commit 4047b61899853e97218e5b7b2de3b4a45b1b38c6.

Reason for revert: CFI errors
 crbug.com/927659 

Original change's description:
> Add StreamStartAlgorithm type
> 
> StartAlgorithms are different from other promise-returning algorithms in
> the streams standard in that they can throw an exception. Add a new
> StreamStartAlgorithm base class to represent them, and a
> CreateStartAlgorithm() function to create ones from JavaScript.
> 
> Design doc:
> https://docs.google.com/document/d/1n0IIRmJb0R-DFc2IhhJfS2-LUwl6iKSBNaR0klr3o40/edit
> 
> BUG=902633
> 
> Change-Id: I0995aa21bbec51ab206a4affc54d861b2c325db4
> Reviewed-on: https://chromium-review.googlesource.com/c/1445342
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Commit-Queue: Adam Rice <ricea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#627877}

TBR=ricea@chromium.org,yhirano@chromium.org

Change-Id: I1a9882e1d33236c95ac953a1a1021b9431c4ddca
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 902633
Reviewed-on: https://chromium-review.googlesource.com/c/1449478
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628274}
[modify] https://crrev.com/2b2a55fe69fc9ab71f713959f305b62ad08e227d/third_party/blink/renderer/core/streams/miscellaneous_operations.cc
[modify] https://crrev.com/2b2a55fe69fc9ab71f713959f305b62ad08e227d/third_party/blink/renderer/core/streams/miscellaneous_operations.h
[modify] https://crrev.com/2b2a55fe69fc9ab71f713959f305b62ad08e227d/third_party/blink/renderer/core/streams/miscellaneous_operations_test.cc
[modify] https://crrev.com/2b2a55fe69fc9ab71f713959f305b62ad08e227d/third_party/blink/renderer/core/streams/stream_algorithms.h

Comment 21 by bugdroid, Feb 4

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f81d5c702457e266882ef4d50e948edc2ac5e66f

commit f81d5c702457e266882ef4d50e948edc2ac5e66f
Author: Adam Rice <ricea@chromium.org>
Date: Mon Feb 04 06:45:13 2019

Reland "Add StreamStartAlgorithm type" and fix bug

Commit 4047b61899853e97218e5b7b2de3b4a45b1b38c6 was reverted in
2b2a55fe69fc9ab71f713959f305b62ad08e227d due to errors on the Linux CFI
bot.

Fix the bug causing the errors and re-land.

Original change's description:
> Add StreamStartAlgorithm type
>
> StartAlgorithms are different from other promise-returning algorithms in
> the streams standard in that they can throw an exception. Add a new
> StreamStartAlgorithm base class to represent them, and a
> CreateStartAlgorithm() function to create ones from JavaScript.
>
> Design doc:
> https://docs.google.com/document/d/1n0IIRmJb0R-DFc2IhhJfS2-LUwl6iKSBNaR0klr3o40/edit
>
> BUG=902633
>
> Change-Id: I0995aa21bbec51ab206a4affc54d861b2c325db4
> Reviewed-on: https://chromium-review.googlesource.com/c/1445342
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Commit-Queue: Adam Rice <ricea@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#627877}

BUG=902633, 927659 

Change-Id: Ia9ad04a02c92b701a4ab726d65c92228f3c5b351
Reviewed-on: https://chromium-review.googlesource.com/c/1449991
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#628671}
[modify] https://crrev.com/f81d5c702457e266882ef4d50e948edc2ac5e66f/third_party/blink/renderer/core/streams/miscellaneous_operations.cc
[modify] https://crrev.com/f81d5c702457e266882ef4d50e948edc2ac5e66f/third_party/blink/renderer/core/streams/miscellaneous_operations.h
[modify] https://crrev.com/f81d5c702457e266882ef4d50e948edc2ac5e66f/third_party/blink/renderer/core/streams/miscellaneous_operations_test.cc
[modify] https://crrev.com/f81d5c702457e266882ef4d50e948edc2ac5e66f/third_party/blink/renderer/core/streams/stream_algorithms.h

Comment 22 by ricea@chromium.org, Feb 6

Blocking: 807998

Comment 23 by bugdroid, Feb 6

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dac55f7b3ba2471df01f6bfa414f7d73423254fc

commit dac55f7b3ba2471df01f6bfa414f7d73423254fc
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Feb 06 05:40:21 2019

Add IDL files for native ReadableStream

Design doc:
https://docs.google.com/document/d/1n0IIRmJb0R-DFc2IhhJfS2-LUwl6iKSBNaR0klr3o40/edit

Bug: 902633
Change-Id: I5f2c70db01019af9816980c2c83b0f1840ecfe3d
Reviewed-on: https://chromium-review.googlesource.com/c/1454346
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629481}
[modify] https://crrev.com/dac55f7b3ba2471df01f6bfa414f7d73423254fc/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/dac55f7b3ba2471df01f6bfa414f7d73423254fc/third_party/blink/renderer/core/streams/BUILD.gn
[add] https://crrev.com/dac55f7b3ba2471df01f6bfa414f7d73423254fc/third_party/blink/renderer/core/streams/readable_stream_default_controller.cc
[add] https://crrev.com/dac55f7b3ba2471df01f6bfa414f7d73423254fc/third_party/blink/renderer/core/streams/readable_stream_default_controller.h
[add] https://crrev.com/dac55f7b3ba2471df01f6bfa414f7d73423254fc/third_party/blink/renderer/core/streams/readable_stream_default_controller.idl
[add] https://crrev.com/dac55f7b3ba2471df01f6bfa414f7d73423254fc/third_party/blink/renderer/core/streams/readable_stream_default_reader.cc
[add] https://crrev.com/dac55f7b3ba2471df01f6bfa414f7d73423254fc/third_party/blink/renderer/core/streams/readable_stream_default_reader.h
[add] https://crrev.com/dac55f7b3ba2471df01f6bfa414f7d73423254fc/third_party/blink/renderer/core/streams/readable_stream_default_reader.idl

Comment 24 by bugdroid, Feb 11

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67c6d5f37526a7ad338905cc15a030f33955f3c9

commit 67c6d5f37526a7ad338905cc15a030f33955f3c9
Author: Adam Rice <ricea@chromium.org>
Date: Mon Feb 11 22:50:41 2019

Implement WritableStreamNative

Add a C++ implementation of WritableStream. This is based on the
existing JavaScript implementation, and follows the standard text
closely.

See the design doc for background:
https://docs.google.com/document/d/1n0IIRmJb0R-DFc2IhhJfS2-LUwl6iKSBNaR0klr3o40/edit

The new implementation is protected by a "StreamsNative" blink feature
flag. It does not interoperate with the old implementation: piping
doesn't work when the feature is enabled, and TransformStream uses the
wrong implementation of WritableStream.

A new virtual test suite covers the new code. There are currently many
failing expectations, mostly due to piping being disabled.

BUG=902633

Change-Id: If90c3e93bc812211ea27b1487ed3955c63af54e8
Reviewed-on: https://chromium-review.googlesource.com/c/1445632
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630966}
[modify] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/renderer/bindings/core/v8/custom/v8_writable_stream_custom.cc
[modify] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/renderer/core/streams/WritableStream.js
[modify] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/renderer/core/streams/miscellaneous_operations.cc
[modify] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/renderer/core/streams/miscellaneous_operations_test.cc
[modify] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/renderer/core/streams/readable_stream.cc
[modify] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/renderer/core/streams/writable_stream.cc
[modify] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/renderer/core/streams/writable_stream.idl
[modify] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/renderer/core/streams/writable_stream_default_controller.cc
[modify] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/renderer/core/streams/writable_stream_default_controller.h
[modify] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/renderer/core/streams/writable_stream_default_writer.cc
[modify] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/renderer/core/streams/writable_stream_default_writer.h
[modify] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/renderer/core/streams/writable_stream_native.cc
[modify] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/renderer/core/streams/writable_stream_native.h
[modify] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/renderer/core/streams/writable_stream_test.cc
[modify] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/TestExpectations
[modify] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/VirtualTestSuites
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/README.md
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/close-propagation-backward.any-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/close-propagation-backward.any.serviceworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/close-propagation-backward.any.sharedworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/close-propagation-backward.any.worker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/flow-control.any-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/flow-control.any.serviceworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/flow-control.any.sharedworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/flow-control.any.worker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/general.any-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/general.any.serviceworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/general.any.sharedworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/general.any.worker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/multiple-propagation.any-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/multiple-propagation.any.serviceworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/multiple-propagation.any.sharedworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/multiple-propagation.any.worker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/pipe-through.any-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/pipe-through.any.serviceworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/pipe-through.any.sharedworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/pipe-through.any.worker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/then-interception.any-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/transform-streams.any-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/transform-streams.any.serviceworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/transform-streams.any.sharedworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/piping/transform-streams.any.worker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/readable-streams/reentrant-strategies.any-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/readable-streams/reentrant-strategies.any.serviceworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/readable-streams/reentrant-strategies.any.sharedworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/readable-streams/reentrant-strategies.any.worker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/transform-streams/backpressure.any-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/transform-streams/backpressure.any.serviceworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/transform-streams/backpressure.any.sharedworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/transform-streams/backpressure.any.worker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/transform-streams/reentrant-strategies.any-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/transform-streams/reentrant-strategies.any.serviceworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/transform-streams/reentrant-strategies.any.sharedworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/transform-streams/reentrant-strategies.any.worker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/transform-streams/terminate.any-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/transform-streams/terminate.any.serviceworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/transform-streams/terminate.any.sharedworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/transform-streams/terminate.any.worker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/writable-streams/constructor.any-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/writable-streams/constructor.any.serviceworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/writable-streams/constructor.any.sharedworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/writable-streams/constructor.any.worker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/writable-streams/properties.any-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/writable-streams/properties.any.serviceworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/writable-streams/properties.any.sharedworker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/external/wpt/streams/writable-streams/properties.any.worker-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/http/tests/streams/chromium/err-invalid-hwm-expected.txt
[add] https://crrev.com/67c6d5f37526a7ad338905cc15a030f33955f3c9/third_party/blink/web_tests/virtual/streams-native/http/tests/streams/transferable/transform-stream-expected.txt

Sign in to add a comment