New issue
Advanced search Search tips

Issue 902603 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 13
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DeveloperToolsDisabled has been marked as deprecated twice

Project Member Reported by zmin@chromium.org, Nov 7

Issue description

In chrome://policy page DeveloperToolsDisable has been marked as deprecated twice. (See screenshot attachment)

This is because the policy error has been added twice.
The first one comes from general policy component based on policy_templates.json
https://cs.chromium.org/chromium/src/components/policy/core/browser/configuration_policy_handler_list.cc?type=cs&sq=package:chromium&g=0&l=68
The second one comes from DeveloperToolsPolicyHandler:
https://cs.chromium.org/chromium/src/chrome/browser/policy/developer_tools_policy_handler.cc?type=cs&q=IDS_POLICY_OVERRIDDEN+develop&sq=package:chromium&g=0&l=44
 
mac_error.png
45.8 KB View Download
Owner: zmin@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81deaec30b908bf73d4e7a0698229f835b97eb18

commit 81deaec30b908bf73d4e7a0698229f835b97eb18
Author: Owen Min <zmin@chromium.org>
Date: Mon Nov 12 16:01:29 2018

Remove duplicated policy deprecation messge

DeveloperToolsDisabled policy is marked as deprecated in policy_templates
and DeveloperToolsPolicyHandler. Remove the one in handler so that the
deprecation message only appears once.

Bug:  902603 
Change-Id: Ia9a78cd4667eb39b5ec3e82399fcd44ae1556de1
Reviewed-on: https://chromium-review.googlesource.com/c/1326843
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607241}
[modify] https://crrev.com/81deaec30b908bf73d4e7a0698229f835b97eb18/chrome/browser/policy/developer_tools_policy_handler.cc

Status: Fixed (was: Started)

Sign in to add a comment