Update MacSandboxTests for V2 Sandbox |
||
Issue descriptionThe MacSandboxTests all use the V1 profile and can be re-written for the V2 profile.
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65f314fbe578be330dd7f3dca5ffcf14c838698c commit 65f314fbe578be330dd7f3dca5ffcf14c838698c Author: Greg Kerr <kerrnel@chromium.org> Date: Fri Nov 09 20:35:25 2018 macOS Sandbox: Add unit test that renderer cannot write to homedir. This adds a unit test that the V2 renderer sandbox profile cannot write to the homedir. Bug: 902597 Change-Id: I6b8c850bdafcb377070e22ed2a1459bcd631b69c Reviewed-on: https://chromium-review.googlesource.com/c/1321862 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606956} [modify] https://crrev.com/65f314fbe578be330dd7f3dca5ffcf14c838698c/content/browser/OWNERS [add] https://crrev.com/65f314fbe578be330dd7f3dca5ffcf14c838698c/content/browser/sandbox_mac_unittest.mm [modify] https://crrev.com/65f314fbe578be330dd7f3dca5ffcf14c838698c/content/browser/sandbox_parameters_mac.h [modify] https://crrev.com/65f314fbe578be330dd7f3dca5ffcf14c838698c/content/test/BUILD.gn
,
Nov 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e15d707abee4c8e7a5e0c480a9f02f857965596 commit 1e15d707abee4c8e7a5e0c480a9f02f857965596 Author: Robert Sesek <rsesek@chromium.org> Date: Mon Nov 12 02:55:40 2018 Fix SandboxMacTest.RendererCannotWriteHomeDir on macOS 10.10 Tbr: kerrnel@chromium.org Bug: 902597 Change-Id: I2b18b5b95d3a769e1185559afdcc81d25da5551f Reviewed-on: https://chromium-review.googlesource.com/c/1331227 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#607132} [modify] https://crrev.com/1e15d707abee4c8e7a5e0c480a9f02f857965596/content/browser/sandbox_mac_unittest.mm
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b25043dd7b70be015d4f17e07910068a1f9feb08 commit b25043dd7b70be015d4f17e07910068a1f9feb08 Author: Greg Kerr <kerrnel@chromium.org> Date: Tue Nov 27 18:25:46 2018 macOS Sandbox: Add unit test for pasteboard in sandboxed processes. This converts the V1 unit test, checking pasteboard access in sandboxed processes, to the V2 sandbox. Bug: 902597 Change-Id: Id11e2c597a55f9e66f45d1edf6b7c7bcb8396f57 Reviewed-on: https://chromium-review.googlesource.com/c/1327545 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#611202} [modify] https://crrev.com/b25043dd7b70be015d4f17e07910068a1f9feb08/content/browser/sandbox_mac_unittest.mm [modify] https://crrev.com/b25043dd7b70be015d4f17e07910068a1f9feb08/content/common/sandbox_mac_system_access_unittest.mm
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ffaaea77482e55dfd3d316769f12fcf4b94f179 commit 5ffaaea77482e55dfd3d316769f12fcf4b94f179 Author: Greg Kerr <kerrnel@chromium.org> Date: Wed Nov 28 00:13:29 2018 macOS Sandbox: Port SSL init test to V2. Bug: 902597 Change-Id: I3e422c88d774705a1c67682d0fdb1b18e3568170 Reviewed-on: https://chromium-review.googlesource.com/c/1327426 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#611441} [modify] https://crrev.com/5ffaaea77482e55dfd3d316769f12fcf4b94f179/content/browser/sandbox_mac_unittest.mm [delete] https://crrev.com/6cdc929e60b03e85e5870c7f06e3906bfee9670f/content/common/sandbox_mac_system_access_unittest.mm [modify] https://crrev.com/5ffaaea77482e55dfd3d316769f12fcf4b94f179/content/test/BUILD.gn
,
Nov 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d979043f0a30d35f269fa60417d5f2f50e6b657 commit 1d979043f0a30d35f269fa60417d5f2f50e6b657 Author: Greg Kerr <kerrnel@chromium.org> Date: Thu Nov 29 22:53:06 2018 macOS Sandbox: Port fontloading test to V2 sandbox. This removes all of the obsolete unit testing code from the V1 sandbox. Bug: 902597 Change-Id: I426e3b815e0bf23036815750aab350adbb22e068 Reviewed-on: https://chromium-review.googlesource.com/c/1327527 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#612416} [modify] https://crrev.com/1d979043f0a30d35f269fa60417d5f2f50e6b657/content/browser/sandbox_mac_unittest.mm [delete] https://crrev.com/53095cfc182d5ddec83ca8f04cbf96ac21f45a7d/content/common/sandbox_mac_fontloading_unittest.mm [delete] https://crrev.com/53095cfc182d5ddec83ca8f04cbf96ac21f45a7d/content/common/sandbox_mac_unittest_helper.h [delete] https://crrev.com/53095cfc182d5ddec83ca8f04cbf96ac21f45a7d/content/common/sandbox_mac_unittest_helper.mm [modify] https://crrev.com/1d979043f0a30d35f269fa60417d5f2f50e6b657/content/test/BUILD.gn
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d2514d801ad82d468f984f0ec96c5014cfe4aa5 commit 1d2514d801ad82d468f984f0ec96c5014cfe4aa5 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Fri Nov 30 01:58:11 2018 Revert "macOS Sandbox: Port fontloading test to V2 sandbox." This reverts commit 1d979043f0a30d35f269fa60417d5f2f50e6b657. Reason for revert: SandboxMacTests failing on Mac10.10 Tests https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/36825 [ RUN ] SandboxMacTest.FontLoadingTest [1000:779:1129/160013.776478:988116558481:WARNING:test_suite.cc(257)] Test launcher output path /b/s/w/itucGTyo/.org.chromium.Chromium.qx9Sed/test_results.xml exists. Not adding test launcher result printer. Nov 29 16:00:13 vm132-m1.golo.chromium.org content_unittests[1000] <Error>: SeatbeltExecServer: Failed to initialize sandbox: -1 line 163: subpaths must not end with a slash [1000:779:1129/160013.839716:988179793263:FATAL:sandbox_mac_unittest.mm(177)] Check failed: result.server->InitializeSandbox(). 0 content_unittests 0x000000010519dc1f base::debug::StackTrace::StackTrace(unsigned long) + 31 1 content_unittests 0x00000001050d871f logging::LogMessage::~LogMessage() + 223 2 content_unittests 0x000000010170d8b2 content::(anonymous namespace)::CheckCreateSeatbeltServer() + 562 3 content_unittests 0x000000010170e389 content::FontLoadingProcess() + 473 4 content_unittests 0x0000000104587138 base::TestSuite::Run() + 104 5 content_unittests 0x000000010459f43a base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) + 282 6 content_unittests 0x000000010459f2ea base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) + 154 7 content_unittests 0x00000001044df9df main + 191 8 libdyld.dylib 0x00007fff8f5845c9 start + 1 ../../content/browser/sandbox_mac_unittest.mm:90: Failure Expected equality of these values: 0 rv Which is: 1 Stack trace: 0 content_unittests 0x0000000102cbd93b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91 1 content_unittests 0x0000000102cbd2f9 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89 2 content_unittests 0x000000010199ea19 content::(anonymous namespace)::SandboxMacTest::ExecuteWithParams(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, void (*)(sandbox::SeatbeltExecClient*)) + 1625 3 content_unittests 0x000000010199ca4c content::(anonymous namespace)::SandboxMacTest::ExecuteInRendererSandbox(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 172 4 content_unittests 0x000000010199db5e content::SandboxMacTest_FontLoadingTest_Test::TestBody() + 1278 [ FAILED ] SandboxMacTest.FontLoadingTest (286 ms) Original change's description: > macOS Sandbox: Port fontloading test to V2 sandbox. > > This removes all of the obsolete unit testing code from the V1 sandbox. > > Bug: 902597 > Change-Id: I426e3b815e0bf23036815750aab350adbb22e068 > Reviewed-on: https://chromium-review.googlesource.com/c/1327527 > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612416} TBR=kerrnel@chromium.org,rsesek@chromium.org Change-Id: I4731044d228c3b21778334b1ef2693baa1818239 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902597 Reviewed-on: https://chromium-review.googlesource.com/c/1356165 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#612512} [modify] https://crrev.com/1d2514d801ad82d468f984f0ec96c5014cfe4aa5/content/browser/sandbox_mac_unittest.mm [add] https://crrev.com/1d2514d801ad82d468f984f0ec96c5014cfe4aa5/content/common/sandbox_mac_fontloading_unittest.mm [add] https://crrev.com/1d2514d801ad82d468f984f0ec96c5014cfe4aa5/content/common/sandbox_mac_unittest_helper.h [add] https://crrev.com/1d2514d801ad82d468f984f0ec96c5014cfe4aa5/content/common/sandbox_mac_unittest_helper.mm [modify] https://crrev.com/1d2514d801ad82d468f984f0ec96c5014cfe4aa5/content/test/BUILD.gn
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95d0a57ff661b75917ba2d5706fee99222db7bda commit 95d0a57ff661b75917ba2d5706fee99222db7bda Author: Greg Kerr <kerrnel@chromium.org> Date: Fri Nov 30 21:41:12 2018 Reland "macOS Sandbox: Port fontloading test to V2 sandbox." This is a reland of 1d979043f0a30d35f269fa60417d5f2f50e6b657 Original change's description: > macOS Sandbox: Port fontloading test to V2 sandbox. > > This removes all of the obsolete unit testing code from the V1 sandbox. > > Bug: 902597 > Change-Id: I426e3b815e0bf23036815750aab350adbb22e068 > Reviewed-on: https://chromium-review.googlesource.com/c/1327527 > Commit-Queue: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612416} Bug: 902597 Change-Id: I2088dd954956be6d704add7ee8e07bc629df8eb9 Reviewed-on: https://chromium-review.googlesource.com/c/1357217 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612797} [modify] https://crrev.com/95d0a57ff661b75917ba2d5706fee99222db7bda/content/browser/sandbox_mac_unittest.mm [delete] https://crrev.com/e47626124c781d7d93bae0b0610fd7a50c8a5124/content/common/sandbox_mac_fontloading_unittest.mm [delete] https://crrev.com/e47626124c781d7d93bae0b0610fd7a50c8a5124/content/common/sandbox_mac_unittest_helper.h [delete] https://crrev.com/e47626124c781d7d93bae0b0610fd7a50c8a5124/content/common/sandbox_mac_unittest_helper.mm [modify] https://crrev.com/95d0a57ff661b75917ba2d5706fee99222db7bda/content/test/BUILD.gn
,
Dec 14
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Nov 7