New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 902595 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task
M-X



Sign in to add a comment

Layout tabs at once for events from model

Project Member Reported by sangwoo108@chromium.org, Nov 7

Issue description

TabStripModel has been refactored to be consistent( bug 842194 ). This means that we don't have to layout tabs multiple times for an operation on the model. There're several cases I know, but can be more.

1. Closing / inserting tabs, followed by selection change.
Before the refactoring, selection state including the active index in the model was changed after notifying insertion/closure of contents. So, we had to layout tabs twice for this ops. One for insertion/closure, the other for selection. But now tab strip model notifies those events after adjusting the selection, we can layout tabs for a single iteration.

2. Inserting multiple tabs via dragging or restoration.
TabStripModelObserver can notify multiple changes with a single callback, thus creating multiple tabs with a single layout would be possible. This might require changes in API support from TabStripModel to insert multiple contents. 

3. Remove multiple tabs via dragging
Same as above.

This would reduce redundant layout and hopefully sort out glitches related to tab strip layout.
 
Components: UI>Browser>TabStrip
Hello pkasting@! I wonder what you think about this.
2/3 require bulk insert/remote operations, which aren't in place yet.
Cc: tbergquist@chromium.org
tbargquist@ has been looking at tabstrip layout and the like most recently.  Taylor, want to share your thoughts?
Cc: dfried@chromium.org
Labels: Hotlist-DesktopUIConsider
Labels: Group-Tabstrip
These cases seem very straightforward with the new observer API (which, by the way, is very nice; thanks for making that change).  I'm not convinced on the performance and glitches angles but it'd be great if tabstrip layout didn't have to deal with situations where the model isn't in a self-consistent state, i.e. case 1.

Are there any specific performance issues or bugs this might fix?
Labels: M-X
Status: Available (was: Untriaged)
Labels: -Hotlist-DesktopUIConsider Hotlist-DesktopUITriaged
tbergguist@ Sorry for a delayed response. There's no performance issues or bugs now. I think it's not that urgent.
Status: WontFix (was: Available)
**UI mass Triage**

Closing this issue as per C#10,If this bug still reproduces for you, 
please reopen or file a new issue. Thanks!
Labels: -Type-Bug Type-Task
Status: Available (was: WontFix)
I believe it's not a bug but worth doing. Re-triaged.

Sign in to add a comment