Issue metadata
Sign in to add a comment
|
Migrate ExternalFileUrlRequestJob to URLLoader |
||||||||||||||||||||||||
Issue descriptionhttps://cs.chromium.org/chromium/src/chrome/browser/chromeos/fileapi/external_file_url_request_job.h needs to be a network::mojom::URLLoader rather than a net::URLRequestJob in order to work with the network service enabled.
,
Nov 7
,
Nov 7
,
Nov 9
,
Nov 14
,
Nov 15
,
Nov 21
,
Dec 3
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a45ea60b7882643daccd3b0e9e4e2548d2bfea1 commit 6a45ea60b7882643daccd3b0e9e4e2548d2bfea1 Author: Robbie McElrath <rmcelrath@chromium.org> Date: Wed Dec 05 06:53:41 2018 Add ExternalFileURLLoaderFactory to make externalfile URLs work with the network service. This CL adds an ExternalFileURLLoaderFactory that will handle URLs with the externalfile scheme on ChromeOS for navigation and subresources. Without the network service enabled, externalfile URLs are loaded by the ExternalFileURLRequestJob class. I moved much of the logic from that class into a ExternalFileResolver helper class that is used by both ExternalFileURLRequestJob and ExternalFileURLLoaderFactory. Bug: 902593 Change-Id: Id37f7848c3df6c46d3e8e524b36ebe99518a21cd Reviewed-on: https://chromium-review.googlesource.com/c/1352998 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#613893} [modify] https://crrev.com/6a45ea60b7882643daccd3b0e9e4e2548d2bfea1/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/6a45ea60b7882643daccd3b0e9e4e2548d2bfea1/chrome/browser/chromeos/BUILD.gn [add] https://crrev.com/6a45ea60b7882643daccd3b0e9e4e2548d2bfea1/chrome/browser/chromeos/fileapi/external_file_resolver.cc [add] https://crrev.com/6a45ea60b7882643daccd3b0e9e4e2548d2bfea1/chrome/browser/chromeos/fileapi/external_file_resolver.h [add] https://crrev.com/6a45ea60b7882643daccd3b0e9e4e2548d2bfea1/chrome/browser/chromeos/fileapi/external_file_url_loader_factory.cc [add] https://crrev.com/6a45ea60b7882643daccd3b0e9e4e2548d2bfea1/chrome/browser/chromeos/fileapi/external_file_url_loader_factory.h [add] https://crrev.com/6a45ea60b7882643daccd3b0e9e4e2548d2bfea1/chrome/browser/chromeos/fileapi/external_file_url_loader_factory_unittest.cc [modify] https://crrev.com/6a45ea60b7882643daccd3b0e9e4e2548d2bfea1/chrome/browser/chromeos/fileapi/external_file_url_request_job.cc [modify] https://crrev.com/6a45ea60b7882643daccd3b0e9e4e2548d2bfea1/chrome/browser/chromeos/fileapi/external_file_url_request_job.h
,
Dec 5
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by rmcelrath@chromium.org
, Nov 7