New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 902592 link

Starred by 1 user
Status: Closed
Owner:
ccameron@chromium.org
Closed: Nov 8
Cc:
benwells@chromium.org
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Create shortcut for Gmail PWA produces very low-res icons on macOS

Project Member Reported by dharan@google.com, Nov 7 
Chrome Version: 72.0.3603.0
macOS 10.14.1

What steps will reproduce the problem?
(1) Enable PWA support in Chrome, create Shortcut for Gmail.
(2) Observe that resulting app has very low resolution icon in app switcher.

What is the expected result?
Expected better/higher resolution icons in manifest. Presumably this is actually Gmail's problem not a Chrome issue, but filing here in case there's some reason we're interpreting / requesting the icons incorrectly. 

What happens instead?
We get very low resolution icons. 

Link to a screencast that demonstrates the problem:
https://drive.google.com/open?id=1Q8JhPO7CrTgoEf8s5aS7a8U-lYBKpTXO

I also tried replacing the app.icns on disk with a better one I hand-built, but macOS still seems to use the bad one (not sure if that's maybe an icon caching issue?).

(Note that in the first part of the screencast I managed to make Chrome Canary crash, but I'm not exactly sure how I managed to do that - I *think* it was by removing an app while I still had an instance running, but I wasn't able to reproduce it.)

Comment 1 by dominickn@chromium.org, Nov 7

Cc: benwells@chromium.org
Labels: OS-Chrome OS-Linux OS-Windows
+cc benwells@ who I was just discussing this with.

In Gmail's case, they don't appear to have a manifest, so there's no place for us to fetch better icons from.

But if Gmail did have a manifest, we actually refuse to fetch the manifest icons if we don't think the site has a manifest that is valid for a PWA (https://cs.chromium.org/chromium/src/chrome/browser/extensions/bookmark_app_helper.cc?q=bookmark_app_helper.cc&sq=package:chromium&dr&l=331).

That's an issue across desktop - on Android, this isn't a problem because we always try and fetch an icon from the manifest, regardless of whether the manifest is valid for a PWA (https://cs.chromium.org/chromium/src/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc?dr&q=addtohomescreendata&sq=package:chromium&g=0&l=177)

Comment 2 by benwells@google.com, Nov 7 

I'll have a fix for the problem Dom mentions in soon, but I think GMail will still have a problem as they're not providing decent icons.


OP: Have you seen this problem with other web apps?

Comment 3 by dharan@google.com, Nov 7 

> OP: Have you seen this problem with other web apps?

I haven't seen this for Google Photos, Calendar, or Hangouts Chat.

I did see some oddity with Hangouts Chat, where I got a red icon instead of the green one today/on this machine, whereas I had a green one previously, and I think it had to do with my unread messages state at the time of creating the shortcut. But at any rate for these other Google products the icons were/are high-res.

Comment 4 by benwells@google.com, Nov 8

Status: Closed (was: Untriaged)
OK, as this isn't a Chrome problem will close this bug out. There is an internal bug for gmail to fix this.
►

Sign in to add a comment