New issue
Advanced search Search tips

Issue 902591 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Nov 18
Cc:
atotic@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

[LayoutNG] NG is better than Legacy tracking bug

Project Member Reported by atotic@chromium.org, Nov 7 
LayoutNG rendering is sometimes more correct than Legacy.

When this happens, we will rebaseline the result, and mark the test as failing in Legacy.

This bug will be used to mark such tests in TestExpectations.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cf3408b5121f46fdf2fc1e2cf048ae7f492aa7d

commit 5cf3408b5121f46fdf2fc1e2cf048ae7f492aa7d
Author: Aleks Totic <atotic@chromium.org>
Date: Thu Nov 08 00:25:25 2018

[LayoutNG] Rebaseline tests more correct in NG

004-vertical is removed per discussion on Slack.

svg/zoom/page/zoom-svg-float-border-padding.xml
There is no anti-aliasing in NG for top left corner.

tables/mozilla/bugs/ bug2973 .html
<td>inside of table<img src=""></td>
NG is consistent with FF/Edge.

Bug:  902591 
Change-Id: Ie672601caef16f19914855ba83a2cfe8e58ab5d8
Reviewed-on: https://chromium-review.googlesource.com/c/1323794
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606244}
[modify] https://crrev.com/5cf3408b5121f46fdf2fc1e2cf048ae7f492aa7d/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/5cf3408b5121f46fdf2fc1e2cf048ae7f492aa7d/third_party/WebKit/LayoutTests/SmokeTests
[modify] https://crrev.com/5cf3408b5121f46fdf2fc1e2cf048ae7f492aa7d/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/a3dc7158ba06e4918768f8f0d89e90ecb3ad2e26/third_party/WebKit/LayoutTests/fast/table/border-collapsing/004-vertical.html
[delete] https://crrev.com/a3dc7158ba06e4918768f8f0d89e90ecb3ad2e26/third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/svg/zoom/page/zoom-svg-float-border-padding-expected.png
[delete] https://crrev.com/a3dc7158ba06e4918768f8f0d89e90ecb3ad2e26/third_party/WebKit/LayoutTests/platform/android/fast/table/border-collapsing/004-vertical-expected.png
[delete] https://crrev.com/a3dc7158ba06e4918768f8f0d89e90ecb3ad2e26/third_party/WebKit/LayoutTests/platform/fuchsia/fast/table/border-collapsing/004-vertical-expected.png
[delete] https://crrev.com/a3dc7158ba06e4918768f8f0d89e90ecb3ad2e26/third_party/WebKit/LayoutTests/platform/linux/fast/table/border-collapsing/004-vertical-expected.png
[modify] https://crrev.com/5cf3408b5121f46fdf2fc1e2cf048ae7f492aa7d/third_party/WebKit/LayoutTests/platform/linux/svg/zoom/page/zoom-svg-float-border-padding-expected.png
[modify] https://crrev.com/5cf3408b5121f46fdf2fc1e2cf048ae7f492aa7d/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug2973-expected.png
[delete] https://crrev.com/a3dc7158ba06e4918768f8f0d89e90ecb3ad2e26/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/fast/table/border-collapsing/004-vertical-expected.png
[delete] https://crrev.com/a3dc7158ba06e4918768f8f0d89e90ecb3ad2e26/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/table/border-collapsing/004-vertical-expected.png
[delete] https://crrev.com/a3dc7158ba06e4918768f8f0d89e90ecb3ad2e26/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/mojo-loading/fast/table/border-collapsing/004-vertical-expected.png
[delete] https://crrev.com/a3dc7158ba06e4918768f8f0d89e90ecb3ad2e26/third_party/WebKit/LayoutTests/platform/mac/fast/table/border-collapsing/004-vertical-expected.png
[delete] https://crrev.com/a3dc7158ba06e4918768f8f0d89e90ecb3ad2e26/third_party/WebKit/LayoutTests/platform/mac/virtual/mojo-loading/fast/table/border-collapsing/004-vertical-expected.png
[delete] https://crrev.com/a3dc7158ba06e4918768f8f0d89e90ecb3ad2e26/third_party/WebKit/LayoutTests/platform/win/fast/table/border-collapsing/004-vertical-expected.png
[delete] https://crrev.com/a3dc7158ba06e4918768f8f0d89e90ecb3ad2e26/third_party/WebKit/LayoutTests/platform/win/virtual/mojo-loading/fast/table/border-collapsing/004-vertical-expected.png

Comment 2 by dtapu...@chromium.org, Nov 16

Components: Blink>Layout

Comment 3 by mstensho@chromium.org, Nov 18

Cc: atotic@chromium.org
Status: WontFix (was: Unconfirmed)
WontFix would be fine here, right?

Comment 4 by atotic@chromium.org, Nov 19 

WontFix is fine, just placeholder test failures in TestExpectations.
This bug will get fixed when we ship LayoutNG.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8570dd5998877c1b6560433fa7a4980ce7fb763

commit b8570dd5998877c1b6560433fa7a4980ce7fb763
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Jan 11 23:48:34 2019

Remove two failure entries for passing layout tests

tables/mozilla/bugs/ bug2973 .html
fast/scroll-snap/snaps-after-scrollbar-scrolling.html

Flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=tables%2Fmozilla%2Fbugs%2Fbug2973.html%20fast%2Fscroll-snap%2Fsnaps-after-scrollbar-scrolling.html

TBR=wangxianzhu@chromium.org

Bug:  902591 , 864887 
Change-Id: Ic5d2cdc9fcb18c00bed18e4babd8c53a9f190eaf
Reviewed-on: https://chromium-review.googlesource.com/c/1407771
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622224}
[modify] https://crrev.com/b8570dd5998877c1b6560433fa7a4980ce7fb763/third_party/blink/web_tests/TestExpectations
►

Sign in to add a comment