New issue
Advanced search Search tips

Issue 902590 link

Starred by 1 user
Status: Fixed
Owner:
rockot@google.com
Closed: Nov 16
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 904240



Sign in to add a comment

Consider splitting Identity into two types

Project Member Reported by rockot@google.com, Nov 7 
We use service_manager::Identity in primarily two distinct ways:

a) to identify a specific service instance
b) to target a dynamically resolved service instance which may or may not exist

This leads to some confusing semantics in code which uses Identity.

In places where an Identity is meant to reference a specific service instance (such as the Identity a service gets from the Service Manager on startup), we can guarantee that instance group and globally unique ID fields are always valid.

In places where an Identity is used as a sort of service locator (e.g. Connector.BindInterface), arbitrary fields may be omitted and the Identity acts more as a filter for the Service Manager to constrain its search for or creation of the targeted service instance.

We should consider not using Identity for the second case, and instead introducing a type specifically for the purpose of service instance lookup/resolution. Like IdentityFilter or InstanceFilter or something.

Comment 1 by rockot@google.com, Nov 9

Owner: rockot@google.com
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/414710ac9bf38348d7acf05ab2cf19c6aa92092c

commit 414710ac9bf38348d7acf05ab2cf19c6aa92092c
Author: Ken Rockot <rockot@google.com>
Date: Mon Nov 12 23:30:46 2018

[service-manager] Introduce ServiceFilter

ServiceFilter will replace usage of Identity in APIs which take or
require only a partial Identity.

This CL adds the mojom and C++ type (with type-mapping) and updates
Connector's mojom to use ServiceFilter instead of Identity where
appropriate. Implementations of Connector are updated accordingly.

Follow-up CLs will transition callers to explicit use of ServiceFilter
and then finally change Identity to no longer have optional fields so
that all uses refer to concrete service instance identities.

Bug:  902590 
Change-Id: I8587f2c7ba15a68d5d873f207ec8fa99dc0e7312
Reviewed-on: https://chromium-review.googlesource.com/c/1330895
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607370}
[modify] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/ash/BUILD.gn
[modify] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/ash/test/ash_test_helper.cc
[modify] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/ash/test/ash_test_helper.h
[modify] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/public/cpp/BUILD.gn
[modify] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/public/cpp/connector.cc
[modify] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/public/cpp/connector.h
[add] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/public/cpp/service_filter.cc
[add] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/public/cpp/service_filter.h
[add] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/public/cpp/service_filter.typemap
[add] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/public/cpp/service_filter_mojom_traits.cc
[add] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/public/cpp/service_filter_mojom_traits.h
[modify] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/public/cpp/test/test_connector_factory.cc
[modify] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/public/cpp/typemaps.gni
[modify] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/public/java/src/org/chromium/services/service_manager/Connector.java
[modify] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/public/mojom/BUILD.gn
[modify] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/public/mojom/connector.mojom
[add] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/public/mojom/service_filter.mojom
[modify] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/service_manager.cc
[modify] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/tests/connect/connect_test_app.cc
[modify] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/tests/connect/connect_test_package.cc
[modify] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/tests/connect/connect_unittest.cc
[modify] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/tests/service_manager/service_manager_unittest.cc
[modify] https://crrev.com/414710ac9bf38348d7acf05ab2cf19c6aa92092c/services/service_manager/tests/util.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a86fa542fff877da2589b284d800b3924d30710f

commit a86fa542fff877da2589b284d800b3924d30710f
Author: Ken Rockot <rockot@google.com>
Date: Tue Nov 13 21:47:13 2018

[service-manager] Clean up Connector API

Updates the Connector mojom and C++ APIs with clarifying naming and
type usage.

Connector has accumulated lots of cruft over the years and its API
conveys a number of muddled concepts which have lead to general
confusion, misuse, and abuse.

This attempts to sort all that out. Namely:

  - All use of Identity in the Connector API has been migrated to
    ServiceFilter where appropriate.
  - StartService (first version) has been renamed to WarmService to
    convey the correct intent. Bugs filed and TODOs dropped in places
    where this is being used in an undesirable fashion.
  - StartService (second version) has been renamed to
    RegisterServiceInstance to convey more accurately what it does.
    It also requires a complete Identity to be provided by the trusted
    caller.
  - QueryService takes only a service name instead of an Identity, since
    it only needs to take a service name. It also makes no service
    connection so it no longer returns a ConnectResult.
  - FilterInterfaces is marked as deprecated on the mojom interface,
    because we want to obliterate it.
  - Test-only methods have been properly suffixed and made public,
    eliminating the need for the weird TestApi wrapper thing. A
    follow-up CL will delete TestApi and migrate its users.
  - Connector methods which have async replies have optional callbacks
    now instead of the Connector weirdly having a single catch-all
    (and dubiously named) "StartServiceCallback" to handle all replies.

Bug:  902590 
Change-Id: I5a986a5c114da914fd624dac7e6fd021cf139958
Reviewed-on: https://chromium-review.googlesource.com/c/1329845
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#607750}
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/android_webview/renderer/aw_content_renderer_client.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/ash/accelerators/debug_commands.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/ash/app_launch_unittest.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/ash/ash_service_unittest.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/ash/assistant/assistant_controller.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/ash/keyboard/ash_keyboard_controller_unittest.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/ash/multi_device_setup/multi_device_notification_presenter.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/ash/multi_device_setup/multi_device_notification_presenter_unittest.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/ash/shell.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/ash/shell/content/client/shell_browser_main_parts.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/ash/system/flag_warning/flag_warning_tray.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/chrome/browser/chrome_service.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/chrome/browser/chrome_site_per_process_browsertest.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/chrome/browser/extensions/system_display/display_info_provider_chromeos_unittest.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/chrome/browser/spellchecker/test/spellcheck_content_browser_client.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/content/browser/browser_child_process_host_impl.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/content/browser/browser_context.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/content/browser/browser_main_loop.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/content/browser/renderer_host/media/media_devices_manager.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/content/common/service_manager/child_connection.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/content/public/browser/render_process_host.h
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/content/renderer/render_thread_impl_browsertest.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/ios/web/browser_state.mm
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/ios/web/service_manager_context.mm
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/mash/session/session.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/preferences/pref_service_factory_unittest.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/resource_coordinator/resource_coordinator_service_unittest.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/service_manager/background/tests/background_service_manager_unittest.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/service_manager/connect_params.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/service_manager/connect_params.h
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/service_manager/connect_util.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/service_manager/public/cpp/connector.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/service_manager/public/cpp/connector.h
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/service_manager/public/cpp/service_filter.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/service_manager/public/cpp/service_filter.h
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/service_manager/public/cpp/test/test_connector_factory.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/service_manager/public/mojom/connector.mojom
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/service_manager/service_manager.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/service_manager/tests/connect/connect_test_app.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/service_manager/tests/connect/connect_test_package.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/service_manager/tests/connect/connect_unittest.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/service_manager/tests/lifecycle/lifecycle_unittest.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/service_manager/tests/service_manager/service_manager_unittest.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/service_manager/tests/util.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/service_manager/tests/util.h
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/tracing/tracing_service_unittest.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/ws/ime/ime_driver_bridge.cc
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/ws/ime/ime_driver_bridge.h
[modify] https://crrev.com/a86fa542fff877da2589b284d800b3924d30710f/services/ws/ime/ime_unittest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1

commit 045c5c39416a44f87e9a46e8e250ff6e39d8aaf1
Author: Ken Rockot <rockot@google.com>
Date: Wed Nov 14 03:55:52 2018

[service-manager] Migrate things to ServiceFilter

With the exception of Service Manager internals, which will be migrated
in a follow-up CL, this makes the following changes across the tree:

- Any valid use of Identity is updated to use complete Identity values
  with no fields absent. This is for stuff like manual service instance
  registration, or using concrete Identity values from the Service
  Manager.

- All other uses of Identity are switched to ServiceFilter.

Bug:  902590 
Change-Id: I112d501e04ec22461635654ebd3f597bb2bbf396
Reviewed-on: https://chromium-review.googlesource.com/c/1331869
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#607894}
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/chrome/browser/prefs/profile_pref_store_manager_unittest.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/chrome/browser/safe_browsing/client_side_detection_service.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/chrome/browser/spellchecker/spellcheck_service.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/chrome/browser/spellchecker/spellcheck_service_browsertest.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/chrome/browser/ui/ash/chrome_keyboard_controller_client_test_helper.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/chrome/renderer/net/net_error_helper_core_unittest.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/chrome/service/service_utility_process_host.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/chrome/service/service_utility_process_host.h
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/chromecast/media/audio/cast_audio_manager_unittest.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/chromecast/media/audio/cast_audio_output_stream_unittest.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/components/language/content/browser/geo_language_model_unittest.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/components/language/content/browser/geo_language_provider_unittest.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/content/browser/media/forwarding_audio_stream_factory_unittest.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/content/browser/media/media_interface_proxy.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/content/browser/renderer_host/media/audio_service_listener_unittest.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/content/browser/renderer_host/media/render_frame_audio_input_stream_factory_unittest.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/content/browser/renderer_host/media/render_frame_audio_output_stream_factory_unittest.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/content/browser/service_manager/service_manager_context.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/content/browser/webauth/authenticator_impl_unittest.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/content/public/browser/content_browser_client.h
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/content/renderer/mojo/blink_interface_provider_impl.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/content/test/test_blink_web_unit_test_support.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/device/fido/hid/fake_hid_impl_for_testing.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/device/vr/orientation/orientation_device_provider_unittest.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/extensions/browser/api/declarative_net_request/rules_monitor_service.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/extensions/browser/api/declarative_net_request/utils.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/extensions/browser/api/declarative_net_request/utils.h
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/extensions/browser/image_sanitizer.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/extensions/browser/image_sanitizer.h
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/extensions/browser/image_sanitizer_unittest.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/extensions/browser/json_file_sanitizer.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/extensions/browser/json_file_sanitizer.h
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/extensions/browser/json_file_sanitizer_unittest.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/extensions/browser/sandboxed_unpacker.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/extensions/browser/sandboxed_unpacker.h
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/ios/web/service_manager_context.mm
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/services/audio/public/cpp/input_ipc_unittest.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/services/audio/public/cpp/output_device_unittest.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/services/audio/test/audio_system_to_service_adapter_test.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/services/data_decoder/public/cpp/safe_json_parser_impl.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/services/data_decoder/public/cpp/safe_xml_parser.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/services/resource_coordinator/memory_instrumentation/process_map_unittest.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/services/service_manager/background/background_service_manager.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/services/service_manager/background/background_service_manager.h
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/services/service_manager/service_manager.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/services/service_manager/service_manager.h
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/third_party/blink/renderer/core/mojo/test/mojo_interface_interceptor.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/third_party/blink/renderer/platform/testing/scoped_fake_plugin_registry.cc
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
[modify] https://crrev.com/045c5c39416a44f87e9a46e8e250ff6e39d8aaf1/ui/views/mus/views_mus_test_suite.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53ce5a6136b04aff8a653cdcee1f4ef788ba2515

commit 53ce5a6136b04aff8a653cdcee1f4ef788ba2515
Author: Ken Rockot <rockot@google.com>
Date: Fri Nov 16 02:19:00 2018

[service-manager] Require valid fields in Identity

Changes Identity so that none of its fields are optional. All Identity
objects are now either empty and invalid, or fully populated and refer
to a specific, concrete service instance that did, does, or may exist at
some point.

Bug:  902590 ,904240
Change-Id: I5b35909afb39b2588f0841d5b1713a6f7c06c800
Reviewed-on: https://chromium-review.googlesource.com/c/1333126
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#608634}
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/chrome/browser/chrome_content_browser_client_unittest.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/chrome/browser/chrome_site_per_process_browsertest.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/chrome/browser/safe_browsing/client_side_detection_service.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/chrome/browser/spellchecker/spell_check_host_chrome_impl.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/chrome/browser/spellchecker/spell_check_host_chrome_impl_mac.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/chrome/browser/spellchecker/spellcheck_factory.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/chrome/browser/spellchecker/spellcheck_service.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/chrome/browser/spellchecker/spellcheck_service_browsertest.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/chrome/browser/spellchecker/test/spellcheck_content_browser_client.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/content/common/service_manager/service_manager_connection_impl_unittest.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/content/public/test/mock_render_process_host.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/ios/web/service_manager_connection_impl_unittest.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/catalog/catalog.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/file/file_service.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/BUILD.gn
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/connect_params.h
[delete] https://crrev.com/2faebc81dd1b73ae2f63b46e5aa02092fb533178/services/service_manager/connect_util.cc
[delete] https://crrev.com/2faebc81dd1b73ae2f63b46e5aa02092fb533178/services/service_manager/connect_util.h
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/public/cpp/BUILD.gn
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/public/cpp/connector.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/public/cpp/identity.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/public/cpp/identity.h
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/public/cpp/identity.typemap
[add] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/public/cpp/identity_mojom_traits.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/public/cpp/identity_mojom_traits.h
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/public/cpp/service_filter.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/public/cpp/service_filter.h
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/public/cpp/service_test.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/public/cpp/test/test_connector_factory.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/public/mojom/connector.mojom
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/runner/host/service_process_launcher.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/service_manager.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/service_manager.h
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/standalone/context.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/tests/connect/connect_test.mojom
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/tests/connect/connect_test_app.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/tests/connect/connect_test_class_app.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/tests/connect/connect_test_exe.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/tests/connect/connect_test_package.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/tests/connect/connect_unittest.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/tests/service_manager/service_manager_listener_unittest.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/service_manager/tests/service_manager/service_manager_unittest.cc
[modify] https://crrev.com/53ce5a6136b04aff8a653cdcee1f4ef788ba2515/services/test/user_id/user_id_service.cc

Comment 6 by rockot@google.com, Nov 16

Status: Fixed (was: Assigned)

Comment 7 by rockot@google.com, Jan 17 (5 days ago)

Blocking: 904240
►

Sign in to add a comment