New issue
Advanced search Search tips

Issue 902588 link

Starred by 1 user
Status: Fixed
Owner:
vapier@chromium.org
Closed: Nov 13
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

nassh: Change the order of gnubbyd extension ids

Reported by ag...@chromium.org, Nov 7 
Chrome Version       : 70.0.3538.77

What steps will reproduce the problem?
When two gnubbyd extension (dev,prod) are installed, we can't predict which on will be used.

What is the expected result?
It should be in order, dev then prod
e.q
extension (dev): klnjmillfildbbimkincljmfoepfhjjj
extension: lkjlajklkdhaneeelolkfgbpikkgnkpk
app (dev): dlfcjilkjfhdnfiecknlnddkmmiofjbg
app: beknehfpfkghjoafdifaflglpjkojoco
component extension (built-in): kmendfapggjehodndflmmgagdbamhnfd

What happens instead?
Currently nassh.GoogleRelay.findGnubbyExtension picks the first available gnubbyd extension.

Comment 1 by vapier@chromium.org, Nov 7

Owner: vapier@chromium.org
Status: Available (was: Unconfirmed)
Summary: nassh: Change the order of gnubbyd extension ids (was: Change the order of gnubbyd extension ids)
assuming this part was a typo:
  app: lkjlajklkdhaneeelolkfgbpikkgnkpk

the stable app id is beknehfpfkghjoafdifaflglpjkojoco.

Comment 2 by agan@google.com, Nov 7

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/7565fc1aec962c5d5250747a3f50971633ad5bc0

commit 7565fc1aec962c5d5250747a3f50971633ad5bc0
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Nov 13 04:40:18 2018

nassh: prefer certain versions of gnubbyd

The gnubbyd team prefers we prefer specific gnubbyd versions rather
than the current algorithm of "whichever responds first".  List the
order, and then check the results based on that.

Bug:  chromium:902588 
Change-Id: Ibd379ce3ed8a360fc971caddc3e0484c7a2988ab
Reviewed-on: https://chromium-review.googlesource.com/c/1322509
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Vitaliy Shipitsyn <vsh@google.com>

[modify] https://crrev.com/7565fc1aec962c5d5250747a3f50971633ad5bc0/nassh/js/nassh_google_relay.js

Comment 4 by vapier@chromium.org, Nov 13

Status: Fixed (was: Available)
it'll be fixed for the 0.10 release
►

Sign in to add a comment