Issue metadata
Sign in to add a comment
|
User is asked to sign in to gmail.com in content area even when signed in settings. |
||||||||||||||||||||||
Issue descriptionApp Version: 72.0.3603.0 Canary iOS Version: 12.0.1, 12.1 beta ONLY Device: iPhone and iPad NOTE:Bug is reproducible even if the below flags are Enabled or Disabled #wk-http-system-cookie-store #sso-with-wkwebview Steps to reproduce: 1. Launch chrome app 2. Go to Settings, Sign In 3. Now go load gmail.com in content area Observed results: User is not signed in. Expected results: User should be signed in Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): No on M70 Bug reproducible on the current beta channel build (App Version, iOS Version): No on Link to Video: https://drive.google.com/file/d/1zzq2Qiv9CA_Xa6LK0W_LYVDh61cc8RWc/view?usp=sharing
,
Nov 7
jlebel@ could you PTAL?
,
Nov 7
Marking as blocker for M71. The original steps to repro are working fine in M71, but with slightly different steps I can reproduce on M71 also. Steps to repro: 1. Fresh install M71.0.3578.41 beta 2. Launch Google Chrome and force quit. 3. Start Chrome again 4. Goto gmail.com Observed Result: Chrome Sign In in screen is displayed. Expected Result: Gmail Sign in page should be displayed in Content area. Tested on iOS12.1, iPad Pro.
,
Nov 7
Hi Srikanth, Can someone please bisect to find the introduction point in M71 for your repro steps? Thanks,
,
Nov 7
,
Nov 8
Good Version - 72.0.3602.0 Canary Revision - 3ed11c88d92e... Bad version - 72.0.3603.0 Canary Revision - 5edf276f371d...
,
Nov 8
The bisect is for the steps from comment#0. For the steps from comment#3, I just noticed that its not very consistent repro, so I will look further and see if I can bisect.
,
Nov 8
,
Nov 8
Issue from comment#3, I am not able to reproduce anymore on M71. So removing M71 milestone.
,
Nov 9
Hello vbhatsoori, I would need a screenshot of chrome://signin-internals and the bottom of the page is very important. Please scroll to the end of the page. Once you signed in, if you wait few minutes, do you still need to sign-in when going to gmail? If you still have the problem if you kill the app (while being signed in) and you launch chrome, do you still need to sign-in when going to gmail? Thanks,
,
Nov 9
Tested in iPhone XSMAX on iOS 12.0.1 on build 72.0.3605.0 Canary. I am no longer able to repro this issue. User is logged into Gmail.com in content area. Will keep track of this issue and file it again if able to repro it. I think there was a delay in logging into gmail earlier. chrome://signin-internals screenshot - https://drive.google.com/file/d/18yYVSzKxEKo5Z7m9l3MZ2NwNvyAgIZ94/view?usp=sharing As for Srikanth's bug in # 3 , i will let him decide on what to do with it, wither to track it in this bug or open a new one. Thanks.
,
Nov 9
,
Nov 12
,
Nov 12
OK, I think we found why this is flaky. We believe that this is an artifact of the multi-login experiment that is enabled on canary and dev for 50% of the user population. vbhatsoori@: We managed to reproduce it on iOS 11 using the following experiments: enable "Use Multilogin endpoint" and disable "Use WKHTTPSystemCookieStore". Jerome is looking and understand what part of the code is failing.
,
Nov 12
This fails also on iOS 12 with the same flag configuration: + "Use Multilogin endpoint" enabled + "Use WKHTTPSystemCookieStore" disabled I'm disabling the Multilogin experiment, until we have a better solution (either Multilogin can works without WKHTTPSystemCookieStore, or we can't enable Multilogin without WKHTTPSystemCookieStore).
,
Nov 12
,
Nov 13
MirrorMultilogin experiment is disabled by default now. We can remove ReleaseBlock-Stable and ReleaseBlock-Beta
,
Nov 13
,
Nov 20
Probably an issue in:
void GaiaCookieManagerService::StartSettingCookies(
const OAuthMultiloginResult& result) {
,
Nov 21
,
Nov 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7ed9196cf3fde62117161f9c649ae9aad370d1f commit b7ed9196cf3fde62117161f9c649ae9aad370d1f Author: Jérôme Lebel <jlebel@chromium.org> Date: Thu Nov 29 12:09:44 2018 [iOS] kUseMultiloginEndpoint linked to kWKHTTPSystemCookieStore kUseMultiloginEndpoint can only be enabled if kWKHTTPSystemCookieStore is enabled. CookieManager::SetCanonicalCookie() fails to store the cookies. Bug: 902584 , 892130 Change-Id: If3ba635f031e7de830c87b7a97fd262a9e6e2cee Reviewed-on: https://chromium-review.googlesource.com/c/1352324 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#612157} [modify] https://crrev.com/b7ed9196cf3fde62117161f9c649ae9aad370d1f/components/signin/core/browser/account_reconcilor.cc [modify] https://crrev.com/b7ed9196cf3fde62117161f9c649ae9aad370d1f/components/signin/core/browser/account_reconcilor.h [modify] https://crrev.com/b7ed9196cf3fde62117161f9c649ae9aad370d1f/components/signin/core/browser/account_reconcilor_unittest.cc [modify] https://crrev.com/b7ed9196cf3fde62117161f9c649ae9aad370d1f/ios/chrome/browser/signin/account_reconcilor_factory.cc
,
Nov 29
,
Dec 17
Verified in: App Version: 73.0.3642.0 canary Devices: iPhone 6 Plus, iPhone 7 Plus iOS Version: 11.4.1, 12.1.1 As per comment#18, MirrorMultilogin experiment is disabled by default now. Hence tested with the steps mentioned in comment#0 and comment#3, Issue is not reproducible either by enabling or disabling '#wk-http-system-cookie-store' flag. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vbhatsoori@google.com
, Nov 7