Secomp issue in smbproviderd on arm |
|||||||||||
Issue descriptionUnlcear if it's ARM specific. Repro'd on minnie. syscall 196, lstat64. Repro. Fresh reboot ie service not started (maybe not relevant). I was connected to GTN, but either way not a network that had shares. I tried to connect to "smb://foo/bar" Need to figure out if this repros on 70 or 71, maybe backport?
,
Nov 7
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/83a1eb7331dac480c580f1d6530cd705ee49c9fb commit 83a1eb7331dac480c580f1d6530cd705ee49c9fb Author: Bailey Berro <baileyberro@chromium.org> Date: Fri Nov 09 15:19:55 2018 smbprovider: Update ARM seccomp filters This change updates the seccomp filters for ARM to include the same methods as the seccomp filters as x86. Fixes top crash bucket for smbproviderd in go/crash. BUG= chromium:902582 TEST=verified on minnie Change-Id: I003360daff55f5d05ca801b7ca0654ba92577287 Reviewed-on: https://chromium-review.googlesource.com/1324312 Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org> Tested-by: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/83a1eb7331dac480c580f1d6530cd705ee49c9fb/smbprovider/seccomp_filters/smbprovider-seccomp-arm.policy
,
Nov 9
Requesting a merge to 71 since this resolves the largest crash bucked for the smbproviderd process. We have tested this change on an ARM device locally.
,
Nov 9
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 9
Approved for M71 ChromeOS
,
Nov 9
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/896044ea3120e6218dc988b980460e93be41c44a commit 896044ea3120e6218dc988b980460e93be41c44a Author: Bailey Berro <baileyberro@chromium.org> Date: Fri Nov 09 21:49:32 2018 smbprovider: Update ARM seccomp filters This change updates the seccomp filters for ARM to include the same methods as the seccomp filters as x86. Fixes top crash bucket for smbproviderd in go/crash. BUG= chromium:902582 TEST=verified on minnie Change-Id: I003360daff55f5d05ca801b7ca0654ba92577287 Reviewed-on: https://chromium-review.googlesource.com/1324312 Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org> Tested-by: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit 83a1eb7331dac480c580f1d6530cd705ee49c9fb) Reviewed-on: https://chromium-review.googlesource.com/c/1330050 Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Tested-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/896044ea3120e6218dc988b980460e93be41c44a/smbprovider/seccomp_filters/smbprovider-seccomp-arm.policy
,
Nov 12
,
Nov 13
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 13
,
Nov 16
,
Nov 20
Marking as Verified based on c#4, also no crashes observed on Minnie device after reboot and connecting to the File share. Chrome OS: 11151.33.0 Chrome: 71.0.3578.57 |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by zentaro@google.com
, Nov 7