Issue metadata
Sign in to add a comment
|
crosperf unittest fails because of deprecated remote board list |
||||||||||||||||||||||||
Issue description
The unittest of crosperf fails when running experiment_factory_unittest.py.
ERROR: test_get_default_remotes (__main__.ExperimentFactoryTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "././experiment_factory_unittest.py", line 239, in test_get_default_remotes
remotes = ef.GetDefaultRemotes(b)
File "～/chromiumos/src/third_party/toolchain-utils/crosperf/experiment_factory.py", line 355, in GetDefaultRemotes
raise RuntimeError('There is not remote for {0}'.format(board))
RuntimeError: There is not remote for lumpy
Current board_list in this test is:
board_list = ['lumpy', 'elm', 'parrot', 'daisy', 'peach_pit', 'peppy', 'squawks']
We need to update the board list of test_get_default_remotes() test to fix it.
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/d87bc2f4eb3564c4865c82775dcb82c7e7cc4e3d commit d87bc2f4eb3564c4865c82775dcb82c7e7cc4e3d Author: Zhizhou Yang <zhizhouy@google.com> Date: Wed Nov 07 19:40:58 2018 Crosperf: Update board list for crosperf unit test This patch fixes a failed unit test in crosperf, by updating the board list for test_get_default_remotes(). BUG= chromium:902578 TEST=Passed all unit tests. Change-Id: I1d3e615228ef2fd3b52be500a5b769652551c286 Reviewed-on: https://chromium-review.googlesource.com/1321416 Commit-Ready: Zhizhou Yang <zhizhouy@google.com> Tested-by: Zhizhou Yang <zhizhouy@google.com> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/d87bc2f4eb3564c4865c82775dcb82c7e7cc4e3d/crosperf/experiment_factory_unittest.py
,
Nov 7
Marking it as fixed. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by zhizhouy@chromium.org
, Nov 6