Update PIN completion screen string |
||
Issue descriptionPIN completion screen currently says "You can use PIN to unlock your device when you signed out." which isn't grammatically correct. Update to "You can use your PIN to sign in to or unlock your device."
,
Nov 27
Please note that this will probably need two separate strings, because PIN login support depends on hardware. How about "You can use your PIN to unlock your device." "You can use your PIN to sign in to or unlock your device." PinBackend::HasLoginSupport[1] can be used to determine if PIN supports login. 1: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/quick_unlock/pin_backend.h?l=44-46&rcl=b144f7d72da994a15b2d93d4c18eab538e2f624e
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/496b99e7896eebab195943800ea2f9296ba24bcb commit 496b99e7896eebab195943800ea2f9296ba24bcb Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Nov 28 03:24:37 2018 Chrome OS: Update PIN completion screen string Bug: 902564 Change-Id: Ia77cbc8986acc9c3767cb08dd2f50567b14ddf70 Reviewed-on: https://chromium-review.googlesource.com/c/1351464 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#611546} [modify] https://crrev.com/496b99e7896eebab195943800ea2f9296ba24bcb/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/496b99e7896eebab195943800ea2f9296ba24bcb/chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.html [modify] https://crrev.com/496b99e7896eebab195943800ea2f9296ba24bcb/chrome/browser/resources/chromeos/login/discover/modules/discover_module_pin_setup.js [modify] https://crrev.com/496b99e7896eebab195943800ea2f9296ba24bcb/chrome/browser/ui/webui/chromeos/login/discover/modules/discover_module_pin_setup.cc
,
Nov 28
|
||
►
Sign in to add a comment |
||
Comment 1 by zalcorn@chromium.org
, Nov 13