Press enter on search box with a query does not launch the query / site |
|||||||
Issue descriptionWhat steps will reproduce the problem? (1) Open launcher (2) Type query in search box "harry" or something else, make sure only suggestions show up are omnibox suggestions(query and urls) (3) Press enter What is the expected result? One the omnibox suggestion should be highlighted and press enter should launcher that query or site. What happens instead? Nothing was highlighted in suggestions, and nothing happens when user presses Enter Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Nov 6
,
Nov 6
newcomer@ can verify but I'm pretty sure this can't not be fixed aka P1
,
Nov 6
,
Nov 6
The CL causing the issue: https://chromium-review.googlesource.com/c/chromium/src/+/1269622/15/ash/app_list/views/search_result_answer_card_view.cc#349 Simple fix is to test |have_result| in L349.
,
Nov 6
,
Nov 7
Also, it broke the autocomplete feature of search box. Applying the fix in comment#5, only fix the highlighted suggestion and launch result on "Enter", but it won't fix the autocomplete issue. Reverting the cl in #5 fixed both problems.
,
Nov 7
Hi rockot@, do you mind take a look at the issue, the CL: https://chromium-review.googlesource.com/c/chromium/src/+/1321580 only fixes the enter key issue.
,
Nov 8
This CL fixes both issues: https://chromium-review.googlesource.com/c/chromium/src/+/1325081
,
Nov 8
Thanks for the fix!
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58cccbbdf0efff8fdb755b0b8868a33820eb5053 commit 58cccbbdf0efff8fdb755b0b8868a33820eb5053 Author: Ken Rockot <rockot@google.com> Date: Thu Nov 08 01:22:18 2018 [ash] Fix app list search behavior This fixes some regressions which caused Answer Card display handling to interfere with normal search UI behavior in the app list. Namely, automatic selection of top non-Answer-Card results, and autocomplete of text in the input box. Bug: 902563 Change-Id: Ie45672ae64184d7ed6116752bad1c7a0ca38c646 Reviewed-on: https://chromium-review.googlesource.com/c/1325081 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#606269} [modify] https://crrev.com/58cccbbdf0efff8fdb755b0b8868a33820eb5053/ash/app_list/model/search/search_model.cc [modify] https://crrev.com/58cccbbdf0efff8fdb755b0b8868a33820eb5053/ash/app_list/model/search/search_model.h [modify] https://crrev.com/58cccbbdf0efff8fdb755b0b8868a33820eb5053/ash/app_list/model/search/search_result.h [modify] https://crrev.com/58cccbbdf0efff8fdb755b0b8868a33820eb5053/ash/app_list/views/search_box_view.cc [modify] https://crrev.com/58cccbbdf0efff8fdb755b0b8868a33820eb5053/ash/app_list/views/search_result_answer_card_view.cc
,
Nov 8
Thanks for investigating and tracking down the bug! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jennyz@google.com
, Nov 6