Launcher Search Focus Traversal |
|||||||||||||||||
Issue descriptionChrome Version: 72.0.3593.0 What steps will reproduce the problem? (1) Install Cat Simulator (2) Open the launcher, type "Cat", the result should auto-complete to "CatSimulator" (3) Press the down arrow three times. What is the expected result? First down arrow should remove the autocomplete Second down arrow should focus the second result. What happens instead? First arrow removes autocomplete. Second down arrow does nothing. Third down arrow focuses the second result. ⛆ |
|
|
,
Nov 7
Personally would like to wait for UX confirmation as while I agree it is broken I am unsure of this as the fix.
,
Nov 7
Sounds good. Apurvapanse@ who is standing in for shibasheikh@, WDYT?
,
Nov 9
Thanks for catching the bug. I think expected behavior would be the first down arrow focuses on the second result. This behavior parallels that of autocomplete in the omnibox.
,
Nov 12
Thanks apurva!
,
Nov 13
Autocomplete was disabled for M-72. Removing myself from this for now. Will pick it up once we bring it back.
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f7a616d6293adb1a33306fd3ce968181dd8e516 commit 6f7a616d6293adb1a33306fd3ce968181dd8e516 Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Tue Nov 13 07:28:07 2018 Disable Launcher autocomplete by default Autocomplete breaks several features (see linked bugs) and a correct fix requires investigation. Disabling the feature for now. Bug: 897206 , 902558 Test: manual Change-Id: I54a68a88541fab0e2054349c32c1c1892324f67a Reviewed-on: https://chromium-review.googlesource.com/c/1332148 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#607515} [modify] https://crrev.com/6f7a616d6293adb1a33306fd3ce968181dd8e516/ash/public/cpp/app_list/app_list_features.cc
,
Nov 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1425b26fa2a308d314afa4b2891f21e5ea0e38d Commit: f1425b26fa2a308d314afa4b2891f21e5ea0e38d Author: kaznacheev@google.com Commiter: kaznacheev@chromium.org Date: 2018-11-14 15:23:41 +0000 UTC Disable Launcher autocomplete by default Autocomplete breaks several features (see linked bugs) and a correct fix requires investigation. Disabling the feature for now. TBR=kaznacheev@google.com (cherry picked from commit 6f7a616d6293adb1a33306fd3ce968181dd8e516) Bug: 897206 , 902558 Test: manual Change-Id: I54a68a88541fab0e2054349c32c1c1892324f67a Reviewed-on: https://chromium-review.googlesource.com/c/1332148 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#607515} Reviewed-on: https://chromium-review.googlesource.com/c/1335600 Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#681} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1425b26fa2a308d314afa4b2891f21e5ea0e38d commit f1425b26fa2a308d314afa4b2891f21e5ea0e38d Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Wed Nov 14 15:23:41 2018 Disable Launcher autocomplete by default Autocomplete breaks several features (see linked bugs) and a correct fix requires investigation. Disabling the feature for now. TBR=kaznacheev@google.com (cherry picked from commit 6f7a616d6293adb1a33306fd3ce968181dd8e516) Bug: 897206 , 902558 Test: manual Change-Id: I54a68a88541fab0e2054349c32c1c1892324f67a Reviewed-on: https://chromium-review.googlesource.com/c/1332148 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#607515} Reviewed-on: https://chromium-review.googlesource.com/c/1335600 Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#681} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/f1425b26fa2a308d314afa4b2891f21e5ea0e38d/ash/public/cpp/app_list/app_list_features.cc
,
Nov 14
I'll follow up with a fix.
,
Nov 14
,
Nov 14
,
Nov 20
,
Nov 26
down arrow will always jump to the next list result. If there is autocomplete text, hitting backspace to delete it will jump to the result used for the actual currently entered text. There is currently a bug for figuring out how to handle multiple app results with arrow keys: Issue #908621
,
Nov 29
Apurva is currently working on documentation for all of the ideas surrounding the change to focus. We are also trying to think about accessibility implications for ChromeVox, as current autocomplete isn't properly read out to users the way Omnibox autocomplete is. I will work on the ChromeVox functionality while Apurva works on getting the documentation/design feedback from all relevant stakeholders.
,
Dec 19
Shiba and I synced, and we should pursue the following fix that ginko@ mentioned above: - Down arrow should always shift focus to the next result (regardless of if there is autocomplete or not) - If the focus is on an app, a down arrow shifts focus to first list result - If the focus is on a list result, a down arrow shifts focus to next list result.
,
Dec 19
,
Dec 19
,
Dec 19
Making bug into a larger Focus Traversal Redesign umbrella |
||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by newcomer@chromium.org
, Nov 6