Merge request for credit card save metric |
|||||||
Issue descriptionThis is an M71 merge request for https://chromium-review.googlesource.com/c/chromium/src/+/1315953, "[Autofill] Add metric to log when local save is successful". == Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=892299 == Description of problem: Due to changes in how Chrome handles cross-domain navigation, we're finding cases where credit card save is failing after being accepted, especially local save which generally has no reason to fail. We have a fix for M72 on its way, but in order to track the impact of this problem in M71, this CL adds a metric at the end of a save success. Comparing that with save accepted rates should tell us how often local credit card save is accepted but doesn't happen. (The CL landed today, so I have not yet been able to confirm it in Canary.)
,
Nov 7
Pls update bug with canary result tomorrow.
,
Nov 7
The NextAction date has arrived: 2018-11-07
,
Nov 7
Confirmed working as expected in latest Canary 72.0.3604.0. Broken site: Logs prompt acceptance but not new metric Working site: Logs prompt acceptance AND new metric We should be able to use the ratio of these to measure the impact of the problem.
,
Nov 7
Approving merge to M71 branch 3578 based on comment 4, pls merge ASAP. Thank you.
,
Nov 7
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35df226905398a2518ed54abc81c18abdc97dc0b commit 35df226905398a2518ed54abc81c18abdc97dc0b Author: Jared Saul <jsaul@google.com> Date: Wed Nov 07 17:57:12 2018 [Autofill] Add metric to log when local save is successful We're looking to merge this (ideally temporary) metric into M71. A problem has been discovered with regards to checkout flows that span multiple domains, and this will help determine its impact. Bug: 902532 Change-Id: I79c9acba23eb750aecf0171ee92d0de456c2ce0e Reviewed-on: https://chromium-review.googlesource.com/c/1315953 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Original-Commit-Position: refs/heads/master@{#605825}(cherry picked from commit 68eb3344df9069012d662b394e9991d3095b362e) Reviewed-on: https://chromium-review.googlesource.com/c/1323897 Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/branch-heads/3578@{#567} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/35df226905398a2518ed54abc81c18abdc97dc0b/components/autofill/core/browser/autofill_metrics.cc [modify] https://crrev.com/35df226905398a2518ed54abc81c18abdc97dc0b/components/autofill/core/browser/autofill_metrics.h [modify] https://crrev.com/35df226905398a2518ed54abc81c18abdc97dc0b/components/autofill/core/browser/credit_card_save_manager_unittest.cc [modify] https://crrev.com/35df226905398a2518ed54abc81c18abdc97dc0b/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/35df226905398a2518ed54abc81c18abdc97dc0b/tools/metrics/histograms/histograms.xml
,
Nov 7
Landed in M71 via CL 1323897; closing bug. Thanks!
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35df226905398a2518ed54abc81c18abdc97dc0b Commit: 35df226905398a2518ed54abc81c18abdc97dc0b Author: jsaul@google.com Commiter: jsaul@google.com Date: 2018-11-07 17:57:12 +0000 UTC [Autofill] Add metric to log when local save is successful We're looking to merge this (ideally temporary) metric into M71. A problem has been discovered with regards to checkout flows that span multiple domains, and this will help determine its impact. Bug: 902532 Change-Id: I79c9acba23eb750aecf0171ee92d0de456c2ce0e Reviewed-on: https://chromium-review.googlesource.com/c/1315953 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Original-Commit-Position: refs/heads/master@{#605825}(cherry picked from commit 68eb3344df9069012d662b394e9991d3095b362e) Reviewed-on: https://chromium-review.googlesource.com/c/1323897 Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/branch-heads/3578@{#567} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sheriffbot@chromium.org
, Nov 6