New issue
Advanced search Search tips

Issue 902518 link

Starred by 1 user
Status: Fixed
Owner:
futhark@chromium.org
Closed: Nov 9
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Allow ::placeholder after ::slotted()

Project Member Reported by futhark@chromium.org, Nov 6 
According to css-scoping-1, ::slotted() can be followed by a tree-abiding pseudo element. The tree-abiding pseudo elements are the following according to css-pseudo-4:

::before, ::after, ::marker, ::placeholder.

Blink currently allows ::before and ::after, does not support ::marker, and disallows ::placeholder. We should allow ::placeholder after ::slotted().

Comment 1 by futhark@chromium.org, Nov 7

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cd41aa340d600b3c1f1725d94c2e06e11635531

commit 0cd41aa340d600b3c1f1725d94c2e06e11635531
Author: Rune Lillesveen <futhark@chromium.org>
Date: Fri Nov 09 10:48:05 2018

Support ::placeholder after ::slotted().

Tree-abiding pseudo elements are allowed after ::slotted() according to
css-scoping-1. According to css-pseudo-4 they are ::before, ::after,
::marker, and ::placeholder. We already allowed ::before and ::after. We
do not support ::marker. This CL allows ::placeholder.

TEST=external/wpt/css/css-scoping/slotted-parsing.html
TEST=external/wpt/css/css-scoping/slotted-placeholder.html

Bug:  902518 
Change-Id: I963fa93e68c8fbd33fc8090e930be9a00f3c9bd4
Reviewed-on: https://chromium-review.googlesource.com/c/1323049
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606791}
[modify] https://crrev.com/0cd41aa340d600b3c1f1725d94c2e06e11635531/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/0cd41aa340d600b3c1f1725d94c2e06e11635531/third_party/WebKit/LayoutTests/external/wpt/css/css-scoping/slotted-parsing-expected.txt
[modify] https://crrev.com/0cd41aa340d600b3c1f1725d94c2e06e11635531/third_party/blink/renderer/core/css/css_selector.cc
[modify] https://crrev.com/0cd41aa340d600b3c1f1725d94c2e06e11635531/third_party/blink/renderer/core/css/css_selector.h
[modify] https://crrev.com/0cd41aa340d600b3c1f1725d94c2e06e11635531/third_party/blink/renderer/core/css/parser/css_parser_selector.h
[modify] https://crrev.com/0cd41aa340d600b3c1f1725d94c2e06e11635531/third_party/blink/renderer/core/css/parser/css_selector_parser.cc
[modify] https://crrev.com/0cd41aa340d600b3c1f1725d94c2e06e11635531/third_party/blink/renderer/core/css/parser/css_selector_parser_test.cc
[modify] https://crrev.com/0cd41aa340d600b3c1f1725d94c2e06e11635531/third_party/blink/renderer/core/css/resolver/style_resolver.cc

Comment 4 by futhark@chromium.org, Nov 9

Status: Fixed (was: Started)
►

Sign in to add a comment