Captured Sites Test break if recipe contains credit card name |
||
Issue descriptionCaptured Sites Test break if recipe contains credit card name. This is due to a conflict with the autofill profile name: Check failed: name_on_card_.empty() && !temp_card_first_name_.empty() && !temp_card_last_name_.empty() #0 0x7f010aaba50d base::debug::StackTrace::StackTrace() #1 0x7f010a7c28ea base::debug::StackTrace::StackTrace() #2 0x7f010a8326fb logging::LogMessage::~LogMessage() #3 0x0000069a7b2f autofill::CreditCard::SetNameOnCardFromSeparateParts() #4 0x0000069a731d autofill::CreditCard::SetRawInfo() #5 0x000001e0c5b7 autofill::AutofillCapturedSitesInteractiveTest::AddAutofillProfileInfo() #6 0x000001e3f745 captured_sites_test_utils::TestRecipeReplayer::SetupSavedAutofillProfile() #7 0x000001e39f47 captured_sites_test_utils::TestRecipeReplayer::InitializeBrowserToExecuteRecipe() #8 0x000001e377c5 captured_sites_test_utils::TestRecipeReplayer::ReplayRecordedActions() #9 0x000001e35fab captured_sites_test_utils::TestRecipeReplayer::ReplayTest() Consider doing a card name not empty check in the test framework to avoid hitting this error.
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbd84679e08d5b6e1bb25287cee00b6a28c4e9fd commit bbd84679e08d5b6e1bb25287cee00b6a28c4e9fd Author: Yiming Zhou <uwyiming@google.com> Date: Tue Nov 13 02:08:46 2018 Fix an autofill profile setup bug in test. The Captured Sites Autofill tests start with a default saved credit card. Individual test recipes may overwrite this default with a specified credit card. Today, there is a bug that prevents a recipe from overwriting the default card owner by first name and last name. When doing an override, the framework triggers a DCHECK in the saved credit card code that asserts the credit card name is empty. This fix address the DCHECK by setting the default credit card owner name to an empty string before overwriting it. Fixing an autofill profile setup bug in test. The Captured Sites Autofill Tests starts with a default saved credit card. A test recipe may override the default card with its own credit card info. Today, a bug exists in the framework that prevents the recipe from overriding the credit card owner by first name and last name. The bug breaks a DCHECK assertion in the saved credit card code. This fix addresses the assertion by setting the credit card owner name to empty before overriding the recipe specified credit card name. Bug: 902492 Change-Id: Iec86496bf408400b60c2a7183b15ef0bd7dfc14f Reviewed-on: https://chromium-review.googlesource.com/c/1332694 Commit-Queue: Yiming Zhou <uwyiming@google.com> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#607440} [modify] https://crrev.com/bbd84679e08d5b6e1bb25287cee00b6a28c4e9fd/chrome/browser/autofill/autofill_captured_sites_interactive_uitest.cc
,
Nov 15
|
||
►
Sign in to add a comment |
||
Comment 1 by uwyiming@chromium.org
, Nov 6