New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 902465 link

Starred by 1 user
Status: Assigned
Owner:
█ jwd@chromium.org
Last visit > 30 days ago
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Metrics service uses incorrect size to check if an upload is allowed due to traffic throttling.

Project Member Reported by jwd@chromium.org, Nov 6 
On every metrics upload on cellular we check if the upload would put us over our threshold for data use. This is to prevent metrics from using too much of a users cellular data.

We should be using the size of the log to check but instead we're using the size of the hash of the log.

https://codesearch.chromium.org/chromium/src/components/metrics/reporting_service.cc?l=130&rcl=6df919a2cf624a75cc0bb1a232e62c1380ade160

Comment 1 by jwd@chromium.org, Nov 6

Status: Assigned (was: Untriaged)
Note, although it's wrong, it's not catastrophically wrong. When we actually make uploads we use the actual sent and received bytes to update the data use tracker.

So instead of being "will this log put us over the threshold" it's basically "are we already over the threshold".
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6703c9f73fee12d46cdd3a95787aab45f4c3fa9

commit c6703c9f73fee12d46cdd3a95787aab45f4c3fa9
Author: Jesse Doherty <jwd@chromium.org>
Date: Fri Nov 09 19:26:46 2018

Use the size of the staged log instead of the size of the hash to check if it should be uploaded on cellular.

Bug: 902465
Change-Id: Ic7ffe0c5d5639b99f590c4ad7ebbf334254ea05f
Reviewed-on: https://chromium-review.googlesource.com/c/1329501
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606926}
[modify] https://crrev.com/c6703c9f73fee12d46cdd3a95787aab45f4c3fa9/components/metrics/reporting_service.cc
►

Sign in to add a comment