When unlocking after we know auth is successful we do not run the unlock success animation immediately.
For fingerprint we worked around this with a success animation. After https://chromium-review.googlesource.com/c/chromium/src/+/1320794 lands we may want to revalidate we still want the success icon.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c57594173180e1b87a22a1733edfd45386518bc commit 9c57594173180e1b87a22a1733edfd45386518bc Author: Jacob Dufault <jdufault@google.com> Date: Wed Nov 07 16:43:52 2018 cros: Remove ScreenLocker::AnimateAuthenticationSuccess This is not used in views lock screen. The implementation is also complicated and possibly crashy if UnlockOnLoginSuccess is called twice. One side-effect of this cleanup is that views lock screen now dismisses 400ms faster, because it was never calling UnlockOnLoginSuccess and instead relied on the fallback handler. Bug: 902451 Change-Id: I16c02dab2b263ee7fa304490e3df0bc002252a41 Reviewed-on: https://chromium-review.googlesource.com/c/1320794 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#606064} [modify] https://crrev.com/9c57594173180e1b87a22a1733edfd45386518bc/chrome/browser/chromeos/login/lock/screen_locker.cc [modify] https://crrev.com/9c57594173180e1b87a22a1733edfd45386518bc/chrome/browser/chromeos/login/lock/screen_locker.h [modify] https://crrev.com/9c57594173180e1b87a22a1733edfd45386518bc/chrome/browser/chromeos/login/lock/views_screen_locker.cc [modify] https://crrev.com/9c57594173180e1b87a22a1733edfd45386518bc/chrome/browser/chromeos/login/lock/views_screen_locker.h [modify] https://crrev.com/9c57594173180e1b87a22a1733edfd45386518bc/chrome/browser/chromeos/login/lock/webui_screen_locker.cc [modify] https://crrev.com/9c57594173180e1b87a22a1733edfd45386518bc/chrome/browser/chromeos/login/lock/webui_screen_locker.h [modify] https://crrev.com/9c57594173180e1b87a22a1733edfd45386518bc/chrome/browser/resources/chromeos/login/login_shared.js [modify] https://crrev.com/9c57594173180e1b87a22a1733edfd45386518bc/chrome/browser/resources/chromeos/login/md_login_shared.js [modify] https://crrev.com/9c57594173180e1b87a22a1733edfd45386518bc/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc [modify] https://crrev.com/9c57594173180e1b87a22a1733edfd45386518bc/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
Comment 1 by jdufault@chromium.org
, Nov 7