nano_omaha_devserver is adding isDeltaPayload twice when it is a delta payload |
|||
Issue description
Currently this is only affecting cellular AU delta tests
Here is an example update_engine log
[1104/125550:INFO:omaha_request_action.cc(1210)] Omaha request response:
<response protocol="3.0">
<daystart elapsed_seconds="44801"/>
<app appid="{85F8FA82-F276-4EA6-8980-93FE091F6D25}" status="ok">
<ping status="ok"/>
<updatecheck status="ok">
<urls>
<url codebase="https://storage.googleapis.com/"/><url codebase="https://storage.googleapis.com/"/>
</urls>
<manifest version="999999.0.0">
<packages>
<package hash_sha256="e3b1870e090dfce08de35b47df9768c48f5740e84f58485c8367b64b7e651145" name="chromeos-throw-away-bucket/CrOSPayloads/Cellular/chromeos_R72-11226.0.0_R72-11226.0.0_nautilus_delta_dev.bin"
size="239285" required="true"/>
</packages>
<actions>
<action event="postinstall"
ChromeOSVersion="999999.0.0"
sha256="e3b1870e090dfce08de35b47df9768c48f5740e84f58485c8367b64b7e651145"
needsadmin="false"
IsDeltaPayload="true"
MaxFailureCountPerUrl="1"
DisablePayloadBackoff="true"
IsDeltaPayload="true"
deadline="now"
/>
</actions>
</manifest>
</updatecheck>
</app>
</response>
[1104/125550:INFO:omaha_request_action.cc(1899)] No device policy is loaded. Assuming rollback enabled.
[1104/125550:INFO:omaha_request_action.cc(1929)] Rollback is enabled. Setting kernel_max_rollforward to 65537
[1104/125552:INFO:metrics_reporter_omaha.cc(609)] Sending 65537 for metric UpdateEngine.KernelKey.MinVersion
[1104/125552:INFO:metrics_reporter_omaha.cc(614)] Sending 65537 for metric UpdateEngine.KernelKey.MaxRollforwardVersion
[1104/125552:INFO:metrics_reporter_omaha.cc(619)] Sending 1 for metric UpdateEngine.KernelKey.MaxRollforwardSetSuccess (bool)
[1104/125552:ERROR:omaha_request_action.cc(1248)] Omaha response not valid XML: duplicate attribute at line 23 col 20
[
,
Nov 6
+danny and my team. Now that issue 816655 is only happening on daisy_spring, we will start getting daily cellular AU tests (normal and forced at oobe) again when this bug is fixed.
,
Nov 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/49179bb9c5bc2f40439277cdaf5f39562bc811d4 commit 49179bb9c5bc2f40439277cdaf5f39562bc811d4 Author: David Haddock <dhaddock@chromium.org> Date: Thu Nov 08 01:32:04 2018 Stop adding isDeltaPayload twice to omaha response for delta payloads. BUG= chromium:902448 TEST=autoupdate_Cellular.delta Change-Id: I749747614f166fdb3f5995fedab6e3d30f466f12 Reviewed-on: https://chromium-review.googlesource.com/c/1322189 Tested-by: David Haddock <dhaddock@chromium.org> Reviewed-by: Max Timkovich <timkovich@chromium.org> [modify] https://crrev.com/49179bb9c5bc2f40439277cdaf5f39562bc811d4/client/cros/update_engine/nano_omaha_devserver.py
,
Nov 8
No longer failing with that error. Seems like most failures now are a problem with update starting via cellular: issue 901565. |
|||
►
Sign in to add a comment |
|||
Comment 1 by dhaddock@google.com
, Nov 6