New issue
Advanced search Search tips

Issue 902436 link

Starred by 1 user
Status: Started
Owner:
schenney@chromium.org
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Add a 'reason" for all Document Lifecycle Update calls

Project Member Reported by schenney@chromium.org, Nov 6 
We have metrics tracking time spent updating the document lifecycle, but no way of knowing why. For future metrics, we want to be able to ascertain where the call came frame, and for MainFrame Ratios we want to only record during an actual main frame update.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/370a831d9ec34bf0819c2dc68088efc12c28e3ee

commit 370a831d9ec34bf0819c2dc68088efc12c28e3ee
Author: Stephen Chenney <schenney@chromium.org>
Date: Thu Nov 08 19:02:43 2018

Create PageTest::UpdateAllLifecyclePhasesForTest and use it

This patch is in preparation for adding a "reason" to lifecycle
update calls. CHanging tests in this way means we can add the reason
with a single change for all PageTests and RendererTests.

R=pdr@chromium.org
BUG=902436

Change-Id: I21d05c13570dc94b7a0743eb5770ab5ca865a1ad
Reviewed-on: https://chromium-review.googlesource.com/c/1321779
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606559}
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/animation/animation_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/animation/css/css_animations_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/animation/scroll_timeline_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/clipboard/data_transfer_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/css/active_style_sheets_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/css/affected_by_pseudo_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/css/css_computed_style_declaration_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/css/css_selector_watch_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/css/cssom/prepopulated_computed_style_property_map_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/css/resolver/css_variable_resolver_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/css/resolver/style_adjuster_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/css/style_environment_variables_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/dom/document_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/dom/node_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/dom/range_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/dom/text_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/dom/whitespace_attacher_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/caret_display_item_client_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/commands/apply_block_element_command_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/commands/insert_list_command_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/commands/replace_selection_command_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/commands/set_character_data_command_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/compute_layer_selection_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/editing_style_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/editing_utilities_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/frame_caret_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/frame_selection_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/granularity_strategy_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/ime/input_method_controller_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/iterators/character_iterator_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/iterators/text_iterator_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/layout_selection_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/selection_controller_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/spellcheck/idle_spell_check_controller_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/spellcheck/spell_checker_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/testing/editing_test_base.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/visible_position_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/editing/visible_units_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/frame/local_frame_view_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/html/canvas/canvas_font_cache_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/html/forms/html_input_element_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/html/html_element_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/html/html_embed_element_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/html/list_item_ordinal_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/input/event_handler_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/layout/layout_block_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/layout/layout_box_model_object_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/layout/layout_inline_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/layout/layout_object_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/layout/layout_progress_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/layout/layout_table_cell_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/layout/layout_table_section_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/layout/layout_text_control_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/layout/layout_text_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/layout/layout_theme_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/layout/layout_view.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/layout/layout_view_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/layout/map_coordinates_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/layout/scroll_anchor_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/layout/svg/layout_svg_foreign_object_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/layout/svg/layout_svg_root_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/layout/text_autosizer_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/layout/visual_rect_mapping_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/page/drag_controller_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/page/print_context_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/block_painter_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/box_paint_invalidator_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/compositing/compositing_reason_finder_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/compositing/compositing_requirements_updater_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/compositing/paint_layer_compositor_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/html_canvas_painter_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/image_paint_timing_detector_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/ng/ng_paint_fragment_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/object_paint_invalidator_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/paint_and_raster_invalidation_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/paint_controller_paint_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/paint_layer_painter_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/paint_layer_scrollable_area_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/paint_layer_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/paint_property_tree_update_tests.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/pre_paint_tree_walk_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/text_painter_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/video_painter_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/paint/view_painter_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/testing/core_unit_test_helper.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/testing/core_unit_test_helper.h
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/testing/page_test_base.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/core/testing/page_test_base.h
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_api_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/modules/media_controls/media_controls_orientation_lock_delegate_test.cc
[modify] https://crrev.com/370a831d9ec34bf0819c2dc68088efc12c28e3ee/third_party/blink/renderer/modules/media_controls/media_controls_rotate_to_fullscreen_delegate_test.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7260681b864d2cd058801324181de3a3fc9a7c2f

commit 7260681b864d2cd058801324181de3a3fc9a7c2f
Author: Stephen Chenney <schenney@chromium.org>
Date: Thu Nov 08 20:13:35 2018

For tests with 5 or more calls, create a local UpdateAllLifecyclePhases

In preparation for a series of patches that change the arguments to
UpdateAllLifecyclePhases, create a local helper in tests that do not
derive from PageTest so that only one call site needs to be changed.

There is no change in functionality at all. Tests writers no need to be
less concerned about the arguments to lifecycle updates.

R=pdr@chromium.org

Bug: 902436
Change-Id: Icee20e327aa5d88ecdc38852d41d1b9bda4e2454
Reviewed-on: https://chromium-review.googlesource.com/c/1324230
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606581}
[modify] https://crrev.com/7260681b864d2cd058801324181de3a3fc9a7c2f/content/shell/test_runner/event_sender.cc
[modify] https://crrev.com/7260681b864d2cd058801324181de3a3fc9a7c2f/content/shell/test_runner/event_sender.h
[modify] https://crrev.com/7260681b864d2cd058801324181de3a3fc9a7c2f/third_party/blink/renderer/core/css/style_engine_test.cc
[modify] https://crrev.com/7260681b864d2cd058801324181de3a3fc9a7c2f/third_party/blink/renderer/core/exported/web_plugin_container_test.cc
[modify] https://crrev.com/7260681b864d2cd058801324181de3a3fc9a7c2f/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/7260681b864d2cd058801324181de3a3fc9a7c2f/third_party/blink/renderer/core/frame/browser_controls_test.cc
[modify] https://crrev.com/7260681b864d2cd058801324181de3a3fc9a7c2f/third_party/blink/renderer/core/frame/use_counter_test.cc
[modify] https://crrev.com/7260681b864d2cd058801324181de3a3fc9a7c2f/third_party/blink/renderer/core/frame/visual_viewport_test.cc
[modify] https://crrev.com/7260681b864d2cd058801324181de3a3fc9a7c2f/third_party/blink/renderer/core/html/forms/text_control_element_test.cc
[modify] https://crrev.com/7260681b864d2cd058801324181de3a3fc9a7c2f/third_party/blink/renderer/core/layout/jank_tracker_test.cc
[modify] https://crrev.com/7260681b864d2cd058801324181de3a3fc9a7c2f/third_party/blink/renderer/core/layout/layout_geometry_map_test.cc
[modify] https://crrev.com/7260681b864d2cd058801324181de3a3fc9a7c2f/third_party/blink/renderer/core/page/scrolling/root_scroller_test.cc
[modify] https://crrev.com/7260681b864d2cd058801324181de3a3fc9a7c2f/third_party/blink/renderer/core/page/scrolling/scroll_metrics_test.cc
[modify] https://crrev.com/7260681b864d2cd058801324181de3a3fc9a7c2f/third_party/blink/renderer/core/page/spatial_navigation_test.cc
[modify] https://crrev.com/7260681b864d2cd058801324181de3a3fc9a7c2f/third_party/blink/renderer/core/paint/link_highlight_impl_test.cc
[modify] https://crrev.com/7260681b864d2cd058801324181de3a3fc9a7c2f/third_party/blink/renderer/core/scheduler/frame_throttling_test.cc

Comment 3 by schenney@chromium.org, Jan 15 

Hit Testing should be a reason. Should add an enum histogram for reasons.
►

Sign in to add a comment