New issue
Advanced search Search tips

Issue 902434 link

Starred by 1 user
Status: Fixed
Owner:
schenney@chromium.org
Closed: Dec 6
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Some MainFrame metrics record calls are missing

Project Member Reported by schenney@chromium.org, Nov 6 
There is no calls for MainFrameMetricvs recordings in the SinglethreadProxy, which will cause crashes with a very near future change to the LocalFrameUKMAggregator.

There is a missing RecordMainFrameMetrics call in web_frame_widget_impl, causing issues with OOPIF and messing up the metrics.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b508a247814ad7a8adb9dc4ab557a733ce03c2d6

commit b508a247814ad7a8adb9dc4ab557a733ce03c2d6
Author: Stephen Chenney <schenney@chromium.org>
Date: Thu Nov 08 20:00:36 2018

Fix MainFrame metrics recording call sites

WebFrameWidgetImpl was missing a call to record metrics, resulting in OOPIF not
recording main frame metrics for their update. And the SingleThreadProxy was
not recording metrics at all, which causes crashes with an upcoming patch.

R=pdr@chromium.org
BUG= 902434 

Change-Id: I96e4666d098ef22c2b5aec74851470319dd133f5
Reviewed-on: https://chromium-review.googlesource.com/c/1320691
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606575}
[modify] https://crrev.com/b508a247814ad7a8adb9dc4ab557a733ce03c2d6/cc/trees/single_thread_proxy.cc
[modify] https://crrev.com/b508a247814ad7a8adb9dc4ab557a733ce03c2d6/third_party/blink/renderer/core/frame/web_frame_widget_impl.cc
[modify] https://crrev.com/b508a247814ad7a8adb9dc4ab557a733ce03c2d6/third_party/blink/renderer/core/frame/web_frame_widget_impl.h

Comment 2 by schenney@chromium.org, Dec 6

Status: Fixed (was: Assigned)
►

Sign in to add a comment