New issue
Advanced search Search tips

Issue 902429 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

PaintWorkletInput should take a std::string

Project Member Reported by xidac...@chromium.org, Nov 6

Issue description

This structure would have to be passed cross threads, use std::string is much simpler for this purpose, than the WTF::String.
 
Labels: -Type-Bug Type-Task
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ea965e86495018446490e12370176df6f0af292

commit 4ea965e86495018446490e12370176df6f0af292
Author: Xida Chen <xidachen@chromium.org>
Date: Mon Nov 12 16:42:33 2018

Make PlatformPaintWorkletInput take a std::string

Right now this class takes a WTF::String, which would be hard to make
that pass cross thread. This CL changes WTF::String to a std::string.

Bug:  902429 
Change-Id: Iaa7377a02e299e99ac8178eaf59cd228724609d6
Reviewed-on: https://chromium-review.googlesource.com/c/1331032
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607256}
[modify] https://crrev.com/4ea965e86495018446490e12370176df6f0af292/third_party/blink/renderer/platform/graphics/platform_paint_worklet_input.h

Status: Fixed (was: Assigned)

Sign in to add a comment