Feature description: the goal is to generalize the keyboard accessory code to handle addresses and credit cards; today it only handles passwords.
The main change is in the data structure "TabData" to represent the data to be rendered on the bottom sheet (see attached image), that will replace password_manager::AccessoryItem (C++)/KeyboardAccessoryData.Item (Java) used today.
This will be done in the following steps (roughly one step = one CL):
1. Introduce the new type in C++ and Java and use it in the backend code. As a simplification, we will send a boolean "is_password" instead of the field type. The bridge will translated from the new data structure to AccessoryItem, so that this CL will be more contained.
2. Replace all occurrences of KeyboardAccessoryItem.Item with TabData in the Java code and delete KeyboardAccessoryItem.Item.
3. Replace is_password with the field type in UserInfo.Field.
4. Generalize favicon provider to also handle credit card static assets.
Eng owner: ftirelo
Product owner: durgapandey
Design doc: go/autofill-manual-fallback-docAre you planning on experimenting before launch? No
Any new strings? No
Any implications for Google webservices (i.e. sync, translate)? No
Binary size? No
Do the existing perf tests exercise all aspects of your new feature(s)? No
Feature description: the goal is to generalize the keyboard accessory code to handle addresses and credit cards; today it only handles passwords.
The main change is in the data structure "TabData" to represent the data to be rendered on the bottom sheet (see attached image), that will replace password_manager::AccessoryItem (C++)/KeyboardAccessoryData.Item (Java) used today.
This will be done in the following steps (roughly one step = one CL):
1. Introduce the new type in C++ and Java and use it in the backend code. As a simplification, we will send a boolean "is_password" instead of the field type. The bridge will translated from the new data structure to AccessoryItem, so that this CL will be more contained.
2. Replace all occurrences of KeyboardAccessoryItem.Item with TabData in the Java code and delete KeyboardAccessoryItem.Item.
3. Replace is_password with the field type in UserInfo.Field.
4. Generalize favicon provider to also handle credit card static assets.
5. Define an enum for the footer command type.
6. Add the UserInfo.Row class, to allow multiple fields to be grouped into a single row.
Eng owner: ftirelo
Product owner: durgapandey
Design doc: go/autofill-manual-fallback-docAre you planning on experimenting before launch? No
Any new strings? No
Any implications for Google webservices (i.e. sync, translate)? No
Binary size? No
Do the existing perf tests exercise all aspects of your new feature(s)? No
Comment 1 by ftirelo@chromium.org
, Nov 6