New issue
Advanced search Search tips

Issue 902422 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Checked in trimmed ICU data in *.txt files under (android|cast|common|flutter|ios)/source/data/ to make debugging easier

Project Member Reported by ftang@chromium.org, Nov 6

Issue description

Currently, when jshin check in the *.dat  files ( (android|cast|common|flutter|ios)/icudt[bl].dat )  for icu in 
chromium/deps/icu

by using

scripts/trim_data.sh

we only checked in the dat file. It is hard to debug some of the ICU data issue because what appeared in the src/third_party/icu/source/data/locales/*/*.txt file is not the same content as those in these dat file and it is very difficult to figure out what is built into these dat file by just code search. 
I think it will be beneficial to also checked in the trimmed data that build these dat files under (android|cast|common|flutter|ios)/source/data/ so we can easily figure out the reality of what is in these dat files.
 
Well, see bug 632116,  b/77698473 (Google internal) and 

https://unicode-org.atlassian.net/browse/ICU-10923 . 

The days of trim_data.sh are numbered and 

If necessary, you can do that easily by locally chancing make_data_all.sh. 


Status: WontFix (was: Untriaged)
> The days of trim_data.sh are numbered

Shane has been working hard to fix 
https://unicode-org.atlassian.net/browse/ICU-10923 . 

Given upcoming changes (mentioned above), extra overhead of having to keep multiple data source trees and the fact that per-platform data source can be easily generated in one's local tree, I'll close this.  

Sign in to add a comment