New issue
Advanced search Search tips

Issue 902387 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Uncaught ReferenceError: KeyframeEffect is not defined - error while reloading extensions

Reported by hakerh403@gmail.com, Nov 6

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36

Steps to reproduce the problem:
1.  Open chrome://extensions
2.  Enable dev mode
3.  Load an unpacked extension (irrelevant which)
4.  Add an invalid syntax to the manifest file
5.  Reload the extension
6.  When it says there is an invalid syntax, refresh the page
7.  Go to the extension's details and enable it
8.  Enable it for incognito mode
9.  Go back to chrome://extensions
10. Repeat steps 7-10 several times

What is the expected behavior?
No errors, console should be clean.

What went wrong?
At some point, a JavaScript error "Uncaught ReferenceError: KeyframeEffect is not defined" gets raised in the console. The error originates from Chrome's native script (it is not related to the example extension).

Did this work before? No 

Does this work in other browsers? Yes

Chrome version: 70.0.3538.77  Channel: stable
OS Version: 6.3
Flash Version: /

The issue is seen from 67.0.3396.87 to 70.0.3538.77.
 
sample-extension.zip
2.9 KB Download
Labels: Needs-Triage-M70
Cc: swarnasree.mukkala@chromium.org
Components: Platform>Extensions
Labels: Triaged-ET Target-72 FoundIn-72 M-72 FoundIn-71 FoundIn-70 OS-Linux
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on reported chrome version # 70.0.3538.77, latest stable #70.0.3538.102 and latest chrome #72.0.3608.0 using Ubuntu 17.10 and Windows 10.
Note: Issue is not seen on Mac OS.

The issue seems to have inconsistent behavior and we won't be able to provide bisect information, hence marking it as untriaged and requesting someone from Platform>Extensions team to look into the issue and help us in assigning to the correct owner.
Thanks.!
Components: -Blink>JavaScript
Cc: rdevlin....@chromium.org dpa...@chromium.org
Components: -Platform>Extensions UI>Browser>ExtensionsManagement
Labels: -Pri-2 OS-Chrome OS-Mac Pri-3
Status: Available (was: Untriaged)
This is pretty exceedingly low priority - it doesn't break the page, and takes quite a bit to reproduce.  The error is thrown from our animation code.  +dpapad FYI, since there's discussion about changing how animations work in the settings pages.
I've reproduced this quite a few times, but did not file a bug. It's actually pretty easy to repro. Just hover over the extension icon. In the video that happens accidentally at 1:25.

We should fix, but definitely not a high priority. I think what is happening is that we forgot to import the web animations polyfil which paper-tooltip relies on.
Owner: johntlee@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6e3815c097ad9067b5753f8fe63444471f6ea74

commit f6e3815c097ad9067b5753f8fe63444471f6ea74
Author: John Lee <johntlee@chromium.org>
Date: Tue Dec 04 02:42:54 2018

WebUI: Added web-animations dep for paper-tooltip animations

Bug:  902387 
Change-Id: I6ce83c4434122e038f372b6f9a19229b6dca5552
Reviewed-on: https://chromium-review.googlesource.com/c/1354501
Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613405}
[modify] https://crrev.com/f6e3815c097ad9067b5753f8fe63444471f6ea74/chrome/browser/resources/md_extensions/item.html
[modify] https://crrev.com/f6e3815c097ad9067b5753f8fe63444471f6ea74/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/f6e3815c097ad9067b5753f8fe63444471f6ea74/ui/webui/resources/cr_elements/policy/cr_tooltip_icon.html

Status: Fixed (was: Assigned)

Sign in to add a comment