Chrome OS remove profile UI is missing confirmation button |
||||||||||||||||||
Issue descriptionChromeOS version: starting 70.0.3538.76 ChromeOS device model: ASUS Chromebook Flip C101PA, Google Pixelbook Case#: 17379078 Description: Remove profile confirmation UI dialog is missing button to confirm user profile removal - "Remove this user". Steps to reproduce: 1. Launch Chromebook 2. Click the arrow on the right of user profile 3. Click "Remove this user" 4. On the confirmation screen there is no button to confirm removal But clicking on empty space below the text would eventually "confirm" profile removal. Expected Behavior: "Remove this user" buttom/area should be visible on the confirmation screen Drive link to video reproducing the issue: https://drive.google.com/open?id=1SrTfVy9Ax-k4uo_1Fs40EkSJF8kH9VFF Drive link to screenshots from v.70: https://drive.google.com/open?id=1-yJDhvPSJh1f13IrpD4Wvuw7JfHZLDLq https://drive.google.com/open?id=10RMV6SnBeji7bhbP2SjsY_FOIr4N3yN9 Drive link to screenshot from v.69: https://drive.google.com/open?id=17fwFSSBq4zSe-IErloxGgxZruulNaz_A
,
Nov 9
Also multiple Dell 3120
,
Nov 9
Hi, We have been able to reproduce this issue with long email addresses.
,
Nov 9
++case 17464506 70.0.3538.76 kip
,
Nov 10
Hello Team, do we have an update/workaround (that doesn't involve wiping/restoring the device) for this issue at the moment? Thanks.
,
Nov 10
++ case 17373161 CrOS 69, qawks
,
Nov 12
Moving to P0 since it breaks something very basic which was working and is now broken. Can we repro this internally ?
,
Nov 12
,
Nov 13
,
Nov 13
The issue is currently affecting 16 enterprise customers. Can we get an Eng owner on this?
,
Nov 13
,
Nov 13
++ EDU customers, case 17500287 and 17464733. Issue reproducible on several models running Chrome OS 69 and 70.0.3538.76. Screenshots and video recordings https://drive.google.com/corp/drive/u/0/folders/12P1kR0A0UeOH5e-z0t8w8r1-60Gy5zzu
,
Nov 13
@jdufault: Could you help us find the proper owner for this issue? There are 19 cases where customers are affected by this issue. The issue is easily reproducible on M70 with very long usernames - I was able to reproduce it on my test domain. I've shared a test domain user credential with you on Valentine: username: super.duper.long.and.redundant.username@devicetse.com
,
Nov 13
qnnguyen@ is working on this, should be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1330206.
,
Nov 13
As a workaround, you can hit 'Enter' on the keyboard
,
Nov 13
I believe after that CL lands this will be fixed on master, but likely more than just that CL will need to get merged back.
,
Nov 13
Thanks for the update! The 'Enter' workaround didn't work for me. Could you give more details on the workaround?
,
Nov 13
I believe the CL linked is for a separate issue (overlapping with other UI elements), rather than long usernames hiding the remove-user button.
,
Nov 13
Re the workaround: 1. tab to the dropdown 2. enter to activate popup window 3. enter to 'remove user' 4. enter to 'confirm remove user' Re the CL: ack, I think it is somewhat related though because the button cannot be interacted with below the shelf when visible, so just merging the fix for the bubble bounds will probably not be enough
,
Nov 14
Changing to P1, since there is a workaround provided in c#19. I think the window is too tight for M70 stable refresh, considering that M71 stable cut is coming soon.
,
Nov 14
,
Nov 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96f5ccc36864e1cf5867211d7d0eea29fa2d7c80 commit 96f5ccc36864e1cf5867211d7d0eea29fa2d7c80 Author: Quan Nguyen <qnnguyen@chromium.org> Date: Wed Nov 14 02:16:25 2018 cros: Fix long emails messing up Remove User button placement The email label now uses the same layout rule as the user name label, which fixes the same bug, but for long emails rather than long user names. Bug: 902362 Change-Id: Icfde3129078ffd6a5977b388210bf2773e0ee405 Reviewed-on: https://chromium-review.googlesource.com/c/1334827 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#607864} [modify] https://crrev.com/96f5ccc36864e1cf5867211d7d0eea29fa2d7c80/ash/login/ui/login_bubble.cc [modify] https://crrev.com/96f5ccc36864e1cf5867211d7d0eea29fa2d7c80/ash/login/ui/login_bubble_unittest.cc
,
Nov 14
If we're okay with getting this into M71, I can merge this fix. Would be good to have another person confirm it working. The CL isn't in canary just yet, so we can wait until then, or someone can patch it into their DUT and test it out.
,
Nov 14
Moving to M71, window is closed for M-70. Please test on ToT before requesting merge to M-71.
,
Nov 15
Dell 3189 Issues here too. Some users show the remove option, some can click in the black, and some don't show it at all.
,
Nov 15
qnnguyen@: Support is OK with merging the fix to M71. We'll test it out in canary. Thanks for the quick turnaround.
,
Nov 15
,
Nov 19
Any updates regarding verification for this? If verified, I can merge today :)
,
Nov 19
@qnnguyen: Please merge to M71. Let us know which version will the fix be in in canary. Thanks!
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f894edfe584757e548d9b49a8505195e80b845b commit 3f894edfe584757e548d9b49a8505195e80b845b Author: Quan Nguyen <qnnguyen@chromium.org> Date: Tue Nov 20 00:07:05 2018 cros: Fix long emails messing up Remove User button placement The email label now uses the same layout rule as the user name label, which fixes the same bug, but for long emails rather than long user names. Bug: 902362 Change-Id: Icfde3129078ffd6a5977b388210bf2773e0ee405 Reviewed-on: https://chromium-review.googlesource.com/c/1334827 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#607864}(cherry picked from commit 96f5ccc36864e1cf5867211d7d0eea29fa2d7c80) Reviewed-on: https://chromium-review.googlesource.com/c/1343052 Reviewed-by: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#764} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/3f894edfe584757e548d9b49a8505195e80b845b/ash/login/ui/login_bubble.cc [modify] https://crrev.com/3f894edfe584757e548d9b49a8505195e80b845b/ash/login/ui/login_bubble_unittest.cc
,
Nov 20
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 3f894edfe584757e548d9b49a8505195e80b845b was merged to refs/branch-heads/3578 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3f894edfe584757e548d9b49a8505195e80b845b Commit: 3f894edfe584757e548d9b49a8505195e80b845b Author: qnnguyen@chromium.org Commiter: qnnguyen@chromium.org Date: 2018-11-20 00:07:05 +0000 UTC cros: Fix long emails messing up Remove User button placement The email label now uses the same layout rule as the user name label, which fixes the same bug, but for long emails rather than long user names. Bug: 902362 Change-Id: Icfde3129078ffd6a5977b388210bf2773e0ee405 Reviewed-on: https://chromium-review.googlesource.com/c/1334827 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#607864}(cherry picked from commit 96f5ccc36864e1cf5867211d7d0eea29fa2d7c80) Reviewed-on: https://chromium-review.googlesource.com/c/1343052 Reviewed-by: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#764} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 27
,
Dec 17
This problem has not been fixed. The problem continues to be occurring on my Acer C720 chromebook. When I set Japanese language to Sign-in language. The user deletion screen can not be found out and it will overlap with the shelf bar. I am guessing chrome books which have 11 inch display still have the issue.
,
Dec 17
I have tested this behavior on chrome version 71.0.3578.94.
,
Dec 18
,
Dec 20
qnnguyen@ As #34 reported, The issue still persists after upgrade to 71.0.3578.94 with Display Chrome OS in JP Language. I’ve also tested a few other languages, such as Chinese (Traditional) and Hindi, but those languages are not affected. I’ve took a repro video, so please refer to it. https://drive.google.com/open?id=1q4-9fMshSPlS51TbdEemMui4hVtxks0l Device and OS info. ASUS Chromebook Flip C100PA veyron_minnie 71.0.3578.94 (11151.59.0 (Official Build) beta-channel) Google_Veyron_Minnie.6588.237.0 Please let me know if it is separate issue, otherwise I will create a new bug case.
,
Dec 20
@ryutas: thanks for reporting. Could you open a new crbug for this? The symptom looks different from what the bug is open on, which text overflow causing the button to go out of frame.
,
Jan 10
@qnnguyen: could you revisit this issue? It is still happening for Japanese customers, see c#37 and crbug.com/917308 . |
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by vnikolov@chromium.org
, Nov 7