[Managed Session] Don't override LidCloseAction policy client side |
|||||||||
Issue descriptionCurrently, LidCloseAction overrides any values sent down from the server to ACTION_STOP_SESSION. We want to support enterprise use cases where the policy value would be something else, so stop overriding the value on the client-side as it will be handled server-side. Sleep on Lid Close In Managed Guest Sessions PRD: https://docs.google.com/document/d/18E1FIHTuGApW0-Uj5fkkQsH_K0nYHRyRSlaKfLZs4B8/edit?ts=5bd0d169#
,
Dec 4
,
Dec 4
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/124402e859b90feabcbb2b766932137b3fd3b6cc commit 124402e859b90feabcbb2b766932137b3fd3b6cc Author: Ivan Sandrk <isandrk@google.com> Date: Tue Dec 04 09:54:25 2018 [Managed Session] Don't override LidCloseAction policy client side (do it server side) Currently, LidCloseAction overrides any values sent down from the server to ACTION_STOP_SESSION. We want to support enterprise use cases where the policy value would be something else, so stop overriding the value on the client-side as it will be handled server-side. Sleep on Lid Close In Managed Guest Sessions PRD: https://docs.google.com/document/d/18E1FIHTuGApW0-Uj5fkkQsH_K0nYHRyRSlaKfLZs4B8/edit?ts=5bd0d169# Bug: 902361 Change-Id: I2ff3b5dc99fce8e4248341896fec3c8f21eb4fec Reviewed-on: https://chromium-review.googlesource.com/c/1320171 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#613489} [modify] https://crrev.com/124402e859b90feabcbb2b766932137b3fd3b6cc/chrome/browser/chromeos/policy/device_local_account_policy_provider.cc [modify] https://crrev.com/124402e859b90feabcbb2b766932137b3fd3b6cc/chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc
,
Dec 4
,
Dec 4
,
Dec 5
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afe025c7670019fe11c7a20a30cc0a302d80c864 commit afe025c7670019fe11c7a20a30cc0a302d80c864 Author: Ivan Sandrk <isandrk@google.com> Date: Wed Dec 05 10:17:46 2018 [M72 Merge][Managed Session] Don't override LidCloseAction policy client side (do it server side) Currently, LidCloseAction overrides any values sent down from the server to ACTION_STOP_SESSION. We want to support enterprise use cases where the policy value would be something else, so stop overriding the value on the client-side as it will be handled server-side. Sleep on Lid Close In Managed Guest Sessions PRD: https://docs.google.com/document/d/18E1FIHTuGApW0-Uj5fkkQsH_K0nYHRyRSlaKfLZs4B8/edit?ts=5bd0d169# (cherry picked from commit 124402e859b90feabcbb2b766932137b3fd3b6cc) Bug: 902361 Change-Id: I2ff3b5dc99fce8e4248341896fec3c8f21eb4fec Reviewed-on: https://chromium-review.googlesource.com/c/1320171 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by: Sergey Poromov <poromov@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613489} Reviewed-on: https://chromium-review.googlesource.com/c/1362932 Reviewed-by: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#69} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/afe025c7670019fe11c7a20a30cc0a302d80c864/chrome/browser/chromeos/policy/device_local_account_policy_provider.cc [modify] https://crrev.com/afe025c7670019fe11c7a20a30cc0a302d80c864/chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc
,
Dec 19
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision afe025c7670019fe11c7a20a30cc0a302d80c864 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afe025c7670019fe11c7a20a30cc0a302d80c864 Commit: afe025c7670019fe11c7a20a30cc0a302d80c864 Author: isandrk@google.com Commiter: isandrk@chromium.org Date: 2018-12-05 10:17:46 +0000 UTC [M72 Merge][Managed Session] Don't override LidCloseAction policy client side (do it server side) Currently, LidCloseAction overrides any values sent down from the server to ACTION_STOP_SESSION. We want to support enterprise use cases where the policy value would be something else, so stop overriding the value on the client-side as it will be handled server-side. Sleep on Lid Close In Managed Guest Sessions PRD: https://docs.google.com/document/d/18E1FIHTuGApW0-Uj5fkkQsH_K0nYHRyRSlaKfLZs4B8/edit?ts=5bd0d169# (cherry picked from commit 124402e859b90feabcbb2b766932137b3fd3b6cc) Bug: 902361 Change-Id: I2ff3b5dc99fce8e4248341896fec3c8f21eb4fec Reviewed-on: https://chromium-review.googlesource.com/c/1320171 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by: Sergey Poromov <poromov@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613489} Reviewed-on: https://chromium-review.googlesource.com/c/1362932 Reviewed-by: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#69} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by isandrk@chromium.org
, Nov 6