New issue
Advanced search Search tips

Issue 902354 link

Starred by 1 user
Status: Started
Owner:
frechette@chromium.org
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug

Blocked on:
issue 872096


Sign in to add a comment

Default accept languages are not blocked

Project Member Reported by frechette@google.com, Nov 6 
A blocked language is a language the user _definitely_ understands and for which we should not offer translation.

Chrome Version: 70.0.3538.77 (Official Build) (64-bit)
OS: all

What steps will reproduce the problem?
(1) Start a fresh new Chrome.
(2) Compare accept languages in chrome://settings/languages to `translate_blocked_languages` in chrome://translate-internals.

What is the expected result?
The default accept languages (e.g. `en` and `en-US`) should be blocked.

What happens instead?
There are no blocked languages.

This leads to incongruencies such as the `Offer to translate pages in this language` to be checked for these languages.

Comment 1 by frechette@google.com, Nov 6 

This is caused by the accept languages pref having a default, but not the blocked languages one:
https://cs.chromium.org/chromium/src/chrome/browser/ui/prefs/prefs_tab_helper.cc?rcl=564c80e84a5c6ec370e85ce1890446da108687c4&l=360
https://cs.chromium.org/chromium/src/components/translate/core/browser/translate_prefs.cc?rcl=e162b6eeea70404a044eb79383d84cfc5e9e6dcc&l=875

Adjusting this would fix the issue for new users. Repairing the issue for current users with modified accept languages and blocked languages prefs is less straightforward.

Comment 2 by sczs@chromium.org, Nov 7

Status: Assigned (was: Untriaged)

Comment 3 by frechette@chromium.org, Dec 5

Blockedon: 872096

Comment 4 by frechette@chromium.org, Dec 19

Status: Started (was: Assigned)
►

Sign in to add a comment