New issue
Advanced search Search tips

Issue 902324 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 14
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

MarkAXObjectDirty() API does not cause windows state change event

Project Member Reported by aleventhal@chromium.org, Nov 6

Issue description

Replacing the value change hack with the proper MarkAXObjectDirty() API causes test failures. A focused state change event is not fired on an object that is marked dirty.

See failing test here: https://chromium-review.googlesource.com/c/chromium/src/+/1318361/


 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/085b7a32b1c1c2a60ed5ed39945d7053f83a5472

commit 085b7a32b1c1c2a60ed5ed39945d7053f83a5472
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Wed Nov 14 19:07:35 2018

Use MarkAXObjectDirty()

This updates the code to use MarkAXObjectDirty() where we were using a
hack to fire value changes for generic tree changes. However, tree
change serialization/deserialization did not handle bundles where
there were only changed objects, and no events were provided.

Bug:  902324 
Change-Id: I93f6a1ae1f2e7d835621af8f8deb6c62043454fe
Reviewed-on: https://chromium-review.googlesource.com/c/1318361
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608072}
[modify] https://crrev.com/085b7a32b1c1c2a60ed5ed39945d7053f83a5472/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/085b7a32b1c1c2a60ed5ed39945d7053f83a5472/content/renderer/accessibility/render_accessibility_impl.cc
[modify] https://crrev.com/085b7a32b1c1c2a60ed5ed39945d7053f83a5472/third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
[modify] https://crrev.com/085b7a32b1c1c2a60ed5ed39945d7053f83a5472/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc

Status: Fixed (was: Assigned)

Sign in to add a comment