New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 902297 link

Starred by 2 users
Status: Fixed
Owner:
tschumann@google.com
Closed: Yesterday
Cc:
vitaliii@chromium.org
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 875901



Sign in to add a comment

sync_integration_tests SingleClientCustomPassphraseSyncTest fail in chrome-branded builds

Project Member Reported by h...@chromium.org, Nov 6 
This is probably not related to tot clang, but it breaks our bots.

Examples:
https://ci.chromium.org/buildbot/chromium.clang/ToTWin/2619
https://ci.chromium.org/buildbot/chromium.clang/ToTWin64/2588

We have sync_integration_tests failures going way back, but LogDog ate the logs :-(

Comment 1 by h...@chromium.org, Nov 6

Owner: h...@chromium.org
Status: Started (was: Available)
It reproduces locally with the stable clang:

>type out\release\args.gn
is_chrome_branded = true
is_component_build = false
is_debug = false
is_official_build = true
symbol_level = 1
target_cpu = "x86"
use_goma = true

>ninja -C out\release -j800 sync_integration_tests
>out\release\sync_integration_tests.exe --gtest_filter="SingleClientCustomPassphraseSyncTest*"
...
3 tests timed out:
    SingleClientCustomPassphraseSyncTest.CanDecryptPbkdf2KeyEncryptedData (../../chrome/browser/sync/test/integration/single_client_custom_passphrase_sync_test.cc:236)
    SingleClientCustomPassphraseSyncTest.CanDecryptScryptKeyEncryptedDataWhenScryptNotDisabled (../../chrome/browser/sync/test/integration/single_client_custom_passphrase_sync_test.cc:252)
    SingleClientCustomPassphraseSyncTest.CannotDecryptScryptKeyEncryptedDataWhenScryptDisabled (../../chrome/browser/sync/test/integration/single_client_custom_passphrase_sync_test.cc:271)

Those are the exact same tests failing on the bot.


Is it a chrome-branding or official build thing? Do these pass on the official builders?
Looks like the official builder doesn't run them:

https://uberchromegw.corp.google.com/i/official.desktop/builders/win-clang/builds/1643

Comment 2 by h...@chromium.org, Nov 6 

What exactly is the error? It's hard to tell from all the log spew...

>out\release\sync_integration_tests.exe --gtest_filter=SingleClientCustomPassphraseSyncTest.CanDecryptPbkdf2KeyEncryptedData
IMPORTANT DEBUGGING NOTE: each test is run inside its own process.
For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with either
--single_process (to run the test in one launcher/browser process) or
--single-process (to do the above, and also run Chrome in single-process mode).
Using sharding settings from environment. This is shard 0/1
Using 1 parallel jobs.
Note: Google Test filter = SingleClientCustomPassphraseSyncTest.CanDecryptPbkdf2KeyEncryptedData
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from SingleClientCustomPassphraseSyncTest, where TypeParam =
[ RUN      ] SingleClientCustomPassphraseSyncTest.CanDecryptPbkdf2KeyEncryptedData
[30832:29580:1106/150732.511:2097475406:WARNING:loopback_server.cc(710)] Loopback sync persistent state file does not exist.
[30832:29580:1106/150732.543:ERROR:install_util.cc(687)] Failed to read HKLM\SOFTWARE\Policies\Google\Chrome\MachineLevelUserCloudPolicyEnrollmentToken: The system cannot find the file specified. (0x2)
[30832:29580:1106/150732.558:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 1
[30832:29580:1106/150732.558:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 10
[30832:29580:1106/150732.558:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 11
[30832:29580:1106/150732.558:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 12
[30832:29580:1106/150732.558:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 13
[30832:29580:1106/150732.558:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 14
[30832:29580:1106/150732.558:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 15
[30832:29580:1106/150732.558:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 16
[30832:29580:1106/150732.558:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 17
[30832:29580:1106/150732.558:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 18
[30832:29580:1106/150732.558:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 19
[30832:29580:1106/150732.558:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 2
[30832:29580:1106/150732.558:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 20
[30832:29580:1106/150732.558:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 21
[30832:29580:1106/150732.558:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 22
[30832:29580:1106/150732.558:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 23
[30832:29580:1106/150732.558:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 24
[30832:29580:1106/150732.574:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 25
[30832:29580:1106/150732.574:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 26
[30832:29580:1106/150732.574:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 3
[30832:29580:1106/150732.574:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 4
[30832:29580:1106/150732.574:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 5
[30832:29580:1106/150732.574:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 6
[30832:29580:1106/150732.574:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 7
[30832:29580:1106/150732.574:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 8
[30832:29580:1106/150732.574:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 9
[30832:29580:1106/150732.574:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: RemoteAccessHostMatchUsername
[30832:29580:1106/150732.574:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: SecurityKeyPermitAttestation\1
[30832:29580:1106/150732.710:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 1
[30832:29580:1106/150732.710:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 10
[30832:29580:1106/150732.710:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 11
[30832:29580:1106/150732.712:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 12
[30832:29580:1106/150732.712:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 13
[30832:29580:1106/150732.713:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 14
[30832:29580:1106/150732.713:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 15
[30832:29580:1106/150732.714:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 16
[30832:29580:1106/150732.714:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 17
[30832:29580:1106/150732.715:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 18
[30832:29580:1106/150732.715:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 19
[30832:29580:1106/150732.716:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 2
[30832:29580:1106/150732.716:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 20
[30832:29580:1106/150732.716:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 21
[30832:29580:1106/150732.716:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 22
[30832:29580:1106/150732.716:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 23
[30832:29580:1106/150732.716:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 24
[30832:29580:1106/150732.716:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 25
[30832:29580:1106/150732.716:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 26
[30832:29580:1106/150732.716:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 3
[30832:29580:1106/150732.716:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 4
[30832:29580:1106/150732.716:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 5
[30832:29580:1106/150732.716:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 6
[30832:29580:1106/150732.716:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 7
[30832:29580:1106/150732.716:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 8
[30832:29580:1106/150732.716:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 9
[30832:29580:1106/150732.716:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: RemoteAccessHostMatchUsername
[30832:29580:1106/150732.716:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: SecurityKeyPermitAttestation\1
[30832:29580:1106/150732.810:WARNING:chrome_browser_main_win.cc(647)] Command line too long for RegisterApplicationRestart:  --disable-gpu-process-for-dx12-vulkan-info-collection --gtest_also_run_disabled_tests --gtest_filter=SingleClientCustomPassphraseSyncTest.CanDecryptPbkdf2KeyEncryptedData --single_process --test-launcher-output="c:\src\temp\scoped_dir17600_13933\results17600_22171\test_results.xml" --user-data-dir="c:\src\temp\scoped_dir17600_13933\d17600_3623" --disable-offline-auto-reload --disable-background-networking --sync-short-initial-retry-override --sync-short-nudge-delay-for-test --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --browser-test --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=TestFeatureForBrowserTest2 --disable-gpu-process-for-dx12-vulkan-info-collection --flag-switches-begin --flag-switches-end --isolate-origins=https://chromium.org/,https://corp.googleapis.com/,https://storage.googleapis.com,https://ajax.googleapis.com,https://fonts.googleapis.com,https://googleplex.com/,https://googlesource.com/,https://youtube.com/,https://google.com/,https://googleacquisitionmigration.com/,https://googleusercontent.com/,https://googleprod.com/,https://nest.com/,https://myworkday.com/,https://chromiumapp.org/,https://lucidchart.com/,https://service-now.com/,https://concursolutions.com/,https://salesforce.com/,https://gcorppartners.com/,https://morganstanley.com/,https://schwab.com/,https://qualtrics.com/,https://ultipro.com/,https://google.secure2-enroll.com/,https://googlegroups.com/,https://google.secure.force.com/,https://ebenefitsnow.com/,https://firebase.com/,https://elo.plusrelocation.com/,https://anthem.com/,https://g.viapeople.net/,https://gdjap.com/,https://asana.com/,https://perquisite.net/,https://postini.com/,https://perkhub.com/,https://gstave.us/,https://geolearning.com/,https://lecorpio.com/,https://inverify.net/,https://preceda.com.au/,https://secureacceptance.cybersource.com/,https://solium.com/,https://fgvms.com/,https://ridecell.com/,https://tds.ie/,https://sprinklr.com/,https://smartsheet.com/,https://fieldglass.net/,https://dochub.com/ --restore-last-session about:blank
[30832:13872:1106/150732.872:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[30832:29580:1106/150733.123:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 1
[30832:29580:1106/150733.123:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 10
[30832:29580:1106/150733.124:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 11
[30832:29580:1106/150733.126:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 12
[30832:29580:1106/150733.127:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 13
[30832:29580:1106/150733.127:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 14
[30832:29580:1106/150733.127:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 15
[30832:29580:1106/150733.128:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 16
[30832:29580:1106/150733.128:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 17
[30832:29580:1106/150733.128:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 18
[30832:29580:1106/150733.129:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 19
[30832:29580:1106/150733.129:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 2
[30832:29580:1106/150733.129:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 20
[30832:29580:1106/150733.130:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 21
[30832:29580:1106/150733.130:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 22
[30832:29580:1106/150733.130:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 23
[30832:29580:1106/150733.131:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 24
[30832:29580:1106/150733.131:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 25
[30832:29580:1106/150733.131:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 26
[30832:29580:1106/150733.132:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 3
[30832:29580:1106/150733.132:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 4
[30832:29580:1106/150733.132:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 5
[30832:29580:1106/150733.133:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 6
[30832:29580:1106/150733.135:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 7
[30832:29580:1106/150733.135:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 8
[30832:29580:1106/150733.136:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 9
[30832:29580:1106/150733.137:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: RemoteAccessHostMatchUsername
[30832:29580:1106/150733.137:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: SecurityKeyPermitAttestation\1
[30832:29580:1106/150733.303:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 1
[30832:29580:1106/150733.303:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 10
[30832:29580:1106/150733.311:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 11
[30832:29580:1106/150733.312:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 12
[30832:29580:1106/150733.313:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 13
[30832:29580:1106/150733.314:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 14
[30832:29580:1106/150733.315:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 15
[30832:29580:1106/150733.315:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 16
[30832:29580:1106/150733.316:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 17
[30832:29580:1106/150733.317:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 18
[30832:29580:1106/150733.317:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 19
[30832:29580:1106/150733.318:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 2
[30832:29580:1106/150733.319:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 20
[30832:29580:1106/150733.319:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 21
[30832:29580:1106/150733.319:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 22
[30832:29580:1106/150733.320:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 23
[30832:29580:1106/150733.335:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 24
[30832:29580:1106/150733.336:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 25
[30832:29580:1106/150733.338:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 26
[30832:29580:1106/150733.342:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 3
[30832:29580:1106/150733.342:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 4
[30832:29580:1106/150733.343:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 5
[30832:29580:1106/150733.343:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 6
[30832:29580:1106/150733.343:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 7
[30832:29580:1106/150733.344:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 8
[30832:29580:1106/150733.345:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: 9
[30832:29580:1106/150733.346:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: RemoteAccessHostMatchUsername
[30832:29580:1106/150733.347:ERROR:configuration_policy_handler_list.cc(90)] Unknown policy: SecurityKeyPermitAttestation\1
[30832:29580:1106/150733.652:ERROR:account_tracker.cc(264)] OnOAuthError
[30832:29580:1106/150733.653:WARNING:account_tracker.cc(190)] Failed to get UserInfo for gaia_id_for_user@gmail.com
Still waiting for the following processes to finish:
        "out\release\sync_integration_tests.exe" --disable-gpu-process-for-dx12-vulkan-info-collection --gtest_also_run_disabled_tests --gtest_filter=SingleClientCustomPassphraseSyncTest.CanDecryptPbkdf2KeyEncryptedData --single_process --test-launcher-output="c:\src\temp\scoped_dir17600_13933\results17600_22171\test_results.xml" --user-data-dir="c:\src\temp\scoped_dir17600_13933\d17600_3623"
Still waiting for the following processes to finish:
        "out\release\sync_integration_tests.exe" --disable-gpu-process-for-dx12-vulkan-info-collection --gtest_also_run_disabled_tests --gtest_filter=SingleClientCustomPassphraseSyncTest.CanDecryptPbkdf2KeyEncryptedData --single_process --test-launcher-output="c:\src\temp\scoped_dir17600_13933\results17600_22171\test_results.xml" --user-data-dir="c:\src\temp\scoped_dir17600_13933\d17600_3623"
[1/1] SingleClientCustomPassphraseSyncTest.CanDecryptPbkdf2KeyEncryptedData (TIMED OUT)
1 test timed out:
    SingleClientCustomPassphraseSyncTest.CanDecryptPbkdf2KeyEncryptedData (../../chrome/browser/sync/test/integration/single_client_custom_passphrase_sync_test.cc:236)

Comment 3 by h...@chromium.org, Nov 6 

Does dropping the chrome branding help? Yup. Okay, let's disable the tests in that config...

Comment 5 by vitaliii@chromium.org, Nov 6

Components: Services>Sync

Comment 6 by vitaliii@chromium.org, Nov 6

Blocking: 875901
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e24601fec36682ea464a36d1dfc8840ecef25b2e

commit e24601fec36682ea464a36d1dfc8840ecef25b2e
Author: Hans Wennborg <hans@chromium.org>
Date: Tue Nov 06 15:21:35 2018

Disable SingleClientCustomPassphraseSyncTest tests that fail in chrome-branded builds

TBR=vitaliii

Bug:  902297 
Change-Id: I4663a2a70f13494b0bb3656eafb5e219efa955dc
Reviewed-on: https://chromium-review.googlesource.com/c/1318916
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605681}
[modify] https://crrev.com/e24601fec36682ea464a36d1dfc8840ecef25b2e/chrome/browser/sync/test/integration/single_client_custom_passphrase_sync_test.cc

Comment 8 by h...@chromium.org, Nov 7

Blocking: -894363
Labels: -Pri-1 Pri-2
Owner: vitaliii@chromium.org
Summary: sync_integration_tests SingleClientCustomPassphraseSyncTest fail in chrome-branded builds (was: sync_integration_tests SingleClientCustomPassphraseSyncTest fail on windows clang tot bots)
Unblocking the clang roll and reassigning.

Comment 9 by vitaliii@chromium.org, Jan 14

Cc: vitaliii@chromium.org
Owner: ----
Status: Available (was: Started)
I am busy with the server work these days.
I would appreciate if someone could have a look.
Otherwise I will have a look closer to M72 Stable release.

Comment 10 by tschumann@google.com, Jan 15 

I can reproduce the timeout with this config:
$ cat out/release/args.gn
is_chrome_branded = true
is_component_build = false
is_debug = false
is_official_build = true
symbol_level = 1
#target_cpu = "x86"
target_os = "linux"
use_goma = true


Will have a quick look into it tomorrow.

Comment 11 by tschumann@google.com, Jan 17 (5 days ago)

Owner: tschumann@google.com
Status: Assigned (was: Available)
Project Member

Comment 12 by bugdroid1@chromium.org, Yesterday (40 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1897f9b035eb1c78b40932af989df7129ecdf1f9

commit 1897f9b035eb1c78b40932af989df7129ecdf1f9
Author: Tim Schumann <tschumann@chromium.org>
Date: Mon Jan 21 15:57:06 2019

Fix the custom passphrase tests which were failing on official builds.

The tests would time out on official builds when setting up sync with
only the decryption passphrase. What happened was that during
SetupSyncImpl, the SyncSetupChecker in AwaitSyncSetupCompletion() did
not finish. This is actually not surpising, as setting up decryption
did not call FinishSyncSetup() and thus the first setup was not marked
as completed. The only reason why this works on non-google branded builds
is that those have "sync-the-transport without sync-the-feature enabled"
which allows getting the transport in an active state (which is still not
the expected state though). This CL fixes that and makes sure we wait
for the sync feature to be ready.

This CL restructures the code so that the decryption passphrase also
gets set within SetupSyncImpl and removes the ability to skip passphrase
verification checks. In fact, many of the are not needed any more now
that we know we should not end up in the missing passphrase state.

BUG= 902297 

Change-Id: I8badb9ec5cc04fe723ebe1731eae7dcbfc5ceb54
Reviewed-on: https://chromium-review.googlesource.com/c/1415262
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624591}
[modify] https://crrev.com/1897f9b035eb1c78b40932af989df7129ecdf1f9/chrome/browser/metrics/ukm_browsertest.cc
[modify] https://crrev.com/1897f9b035eb1c78b40932af989df7129ecdf1f9/chrome/browser/sync/test/integration/enable_disable_test.cc
[modify] https://crrev.com/1897f9b035eb1c78b40932af989df7129ecdf1f9/chrome/browser/sync/test/integration/profile_sync_service_harness.cc
[modify] https://crrev.com/1897f9b035eb1c78b40932af989df7129ecdf1f9/chrome/browser/sync/test/integration/profile_sync_service_harness.h
[modify] https://crrev.com/1897f9b035eb1c78b40932af989df7129ecdf1f9/chrome/browser/sync/test/integration/single_client_custom_passphrase_sync_test.cc
[modify] https://crrev.com/1897f9b035eb1c78b40932af989df7129ecdf1f9/chrome/browser/sync/test/integration/single_client_secondary_account_sync_test.cc
[modify] https://crrev.com/1897f9b035eb1c78b40932af989df7129ecdf1f9/chrome/browser/sync/test/integration/single_client_standalone_transport_sync_test.cc
[modify] https://crrev.com/1897f9b035eb1c78b40932af989df7129ecdf1f9/chrome/browser/sync/test/integration/single_client_wallet_sync_test.cc
[modify] https://crrev.com/1897f9b035eb1c78b40932af989df7129ecdf1f9/chrome/browser/sync/test/integration/sync_test.cc
[modify] https://crrev.com/1897f9b035eb1c78b40932af989df7129ecdf1f9/chrome/browser/sync/test/integration/sync_test.h

Comment 13 by tschumann@google.com, Yesterday (24 hours ago)

Status: Fixed (was: Assigned)
patch landed successfully -- bots still green.

Comment 14 by vitaliii@chromium.org, Today (15 hours ago) 

Thank you a lot!
►

Sign in to add a comment