CredentialsContainerTest.PendingGetRequest_NoGCCycles consistently fails |
||||
Issue descriptionIt started failing on this run: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/75523 Due to CL "Enable unified garbage collections": https://chromium-review.googlesource.com/c/chromium/src/+/1290869
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99c898d3582421adb634778d0014e7068fd9b0c8 commit 99c898d3582421adb634778d0014e7068fd9b0c8 Author: Henrik Boström <hbos@chromium.org> Date: Tue Nov 06 12:58:56 2018 Disable CredentialsContainerTest.PendingGetRequest_NoGCCycles test. This was failing due to "unified garbage collection", https://chromium-review.googlesource.com/c/chromium/src/+/1290869. TBR=mlippautz@chromium.org, haraken@chromium.org, mkwst@chromium.org, vasilii@chromium.org NOTRY=True Bug: 902286 Change-Id: Ia5a8fd654f668d7b13d19fb44d39bd80809f9807 Reviewed-on: https://chromium-review.googlesource.com/c/1319672 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#605662} [modify] https://crrev.com/99c898d3582421adb634778d0014e7068fd9b0c8/third_party/blink/renderer/modules/credentialmanager/credentials_container_test.cc
,
Nov 6
With the test disabled, removing sheriff label.
,
Nov 9
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31aaefcb0e3ea120f59513dd70bee33f493b9cea commit 31aaefcb0e3ea120f59513dd70bee33f493b9cea Author: Michael Lippautz <mlippautz@chromium.org> Date: Fri Nov 09 18:48:45 2018 [unified-heap] Fix CredentialsContainerTest for unified heap GCs Bug: 902286 , 843903 Change-Id: I2f4a836bfb448e092a7301a326c0caed722d607e Reviewed-on: https://chromium-review.googlesource.com/c/1329175 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#606917} [modify] https://crrev.com/31aaefcb0e3ea120f59513dd70bee33f493b9cea/third_party/blink/renderer/modules/credentialmanager/credentials_container_test.cc
,
Nov 9
|
||||
►
Sign in to add a comment |
||||
Comment 1 by hbos@chromium.org
, Nov 6