App storage is not removed when an app is removed |
|||
Issue descriptionChrome Version: 70.0.3532.2 OS: ChromeOS What steps will reproduce the problem? (1) Install a Chrome App (e.g. Postman https://chrome.google.com/webstore/detail/postman/fhbjgbiflinjbdggehcddcbncdddomop/related?hl=en-US) (2) Run the app (3) Remove the app What is the expected result? Data related to this app should get removed What happens instead? There is a still a folder in /home/chronos/u-xxxxx/Storage/ext with data from the app. Why don't we delete this data when the app is removed? There doesn't seem to be any other way to remove all data related to an app (see https://crbug.com/389603 )
,
Nov 8
This isn't intentional. I'm pretty sure there is a bug somewhere about this but I couldn't find it, it might have been archived. I vaguely remember it being complex because of the separate storage partition.
,
Nov 9
Ben, could you maybe find an owner for this? I think the expectation of app data being deleted when the app is uninstalled is a reasonable one.
,
Nov 12
How important is this? Chrome apps are deprecated on all non-Chrome OS platforms and we've lived with this for a long time.
,
Nov 12
For all data in Chrome, we should provide some way to delete it. For extensions we remove their state from "<Profile Directory>/Local Extension Settings" on uninstallation. This seems like the best way to delete App data. Android apps work this way as well. We should find out whether we could just delete the storage folder of an App on uninstallation. If that's possible, this seems like an easy to fix issue. If it is more complicated, it depends on the future of App on ChromeOS. How long do we expect them to exist?
,
Nov 13
I found a comment explaining, why we can't remove the StoragePartition directory. Code: https://cs.chromium.org/chromium/src/content/browser/storage_partition_impl_map.cc?gsn=AsyncObliterateStoragePartition&g=0&l=468 Related bug: https://crbug.com/85127 We actually implement a GarbageCollection that runs on startup and removes folders of Apps that have prevously been uninstalled. I didn't notice this when I looked into this issue. I think in this case, the bug can be closed. https://cs.chromium.org/chromium/src/content/browser/storage_partition_impl_map.cc?l=506&rcl=e66055b18d1f38f6b11fa1e0a2b177dedff26fef |
|||
►
Sign in to add a comment |
|||
Comment 1 by dullweber@chromium.org
, Nov 8