New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 902280 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary movement of omnibox URL is seen while switching between tabs.

Reported by db...@etouch.net, Nov 6

Issue description

Chrome Version:72.0.3603.0 Revision 5edf276f371d84cdd49179c8cb6a3dd210bdfe20-refs/branch-heads/3603@{#1}(32/64 bit)
OS: Windows(7,8,8.1,10), Mac (10.13.1, 10.13.6, 10.14.1) and Linux(14.04)

What steps will reproduce the problem?
(1) Launch chrome, navigate to google.com and search for Test pdf text.
(2) Now right click on any pdf file and select 'Open in new tab' option(PDF page will open in NTP ). 
(3) Switch between tabs and observe where pdf page opened.

Actual: Unnecessary movement of omnibox URL is seen while switching between tabs.

Expected: No such a movement should seen while switching between tabs.

This is a regression issue, broken in 'M72', below is bisect info:

Good Build:72.0.3596.0(Revision: 603701)
Bad Build: 72.0.3597.0(Revision: 604471)
Chromium bisect info:

You are probably looking for a change made after 603802(known good), but no later than 603807(first known bad).

CHANGE-LOG URL:
  
https://chromium.googlesource.com/chromium/src/+log/5cb9895ad35e849b6b06922024242df28fc08672..1bf36a0584562dc9662804a91d03105de1b6977a?pretty=fuller&n=100

Suspecting: https://chromium.googlesource.com/chromium/src/+/9c6ff168a2da765844c2614667f0787582561907

@wangxianzhu: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1) Providing suspect using chromium bisect script because unable to perform bisect using 'per-revision' script.
2) Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting following error:
   - Error message on Mac OS:[Errno 2] No such file or directory error message
   - Error message on Windows OS: RuntimeError: We don't have enough builds to bisect.

Kindly refer the attached screen-cast.

Thank you..!
 
Actual_Switch.mp4
1.2 MB View Download
Expected_Switch.mp4
1.3 MB View Download
Owner: ----
Status: Untriaged (was: Assigned)
My CL changed comment and #include only which didn't change compiled binary.
Owner: harrisjay@chromium.org
Status: Assigned (was: Untriaged)
I see the behavior too, but I'm not sure where the original diff came from. In the correct/complete diff, this CL is far more suspicious (only because it affects the location bar and mentions the security chip):

https://chromium-review.googlesource.com/c/chromium/src/+/1248067

Status: Started (was: Assigned)
Confirmed, a fix is on its way.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1de1a5a6b2212b197f023bd89d1e33d3883797e2

commit 1de1a5a6b2212b197f023bd89d1e33d3883797e2
Author: Jay Harris <harrisjay@chromium.org>
Date: Fri Nov 16 01:11:17 2018

Fixes unnecessary animating of security text on tab change

Bug:  902280 
Change-Id: I53e8152e1208a31bd4551c56da47489db92864af
Reviewed-on: https://chromium-review.googlesource.com/c/1329707
Commit-Queue: Jay Harris <harrisjay@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608611}
[modify] https://crrev.com/1de1a5a6b2212b197f023bd89d1e33d3883797e2/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
[modify] https://crrev.com/1de1a5a6b2212b197f023bd89d1e33d3883797e2/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/1de1a5a6b2212b197f023bd89d1e33d3883797e2/chrome/browser/ui/views/location_bar/location_icon_view.cc
[modify] https://crrev.com/1de1a5a6b2212b197f023bd89d1e33d3883797e2/chrome/browser/ui/views/location_bar/location_icon_view.h
[modify] https://crrev.com/1de1a5a6b2212b197f023bd89d1e33d3883797e2/chrome/browser/ui/views/location_bar/location_icon_view_browsertest.cc
[add] https://crrev.com/1de1a5a6b2212b197f023bd89d1e33d3883797e2/chrome/browser/ui/views/location_bar/location_icon_view_unittest.cc
[modify] https://crrev.com/1de1a5a6b2212b197f023bd89d1e33d3883797e2/chrome/test/BUILD.gn
[modify] https://crrev.com/1de1a5a6b2212b197f023bd89d1e33d3883797e2/components/omnibox/browser/test_location_bar_model.cc
[modify] https://crrev.com/1de1a5a6b2212b197f023bd89d1e33d3883797e2/components/omnibox/browser/test_location_bar_model.h

Status: Fixed (was: Started)

Sign in to add a comment