New issue
Advanced search Search tips

Issue 902274 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Nov 9
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Frame border colors cannot be changed using CSS

Reported by darnold....@gmail.com, Nov 6 
Chrome Version       : 70.0.3538.77
OS Version: 10.0
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
    IE/Edge: OK

What steps will reproduce the problem?
1. Create a file containing a frame set with styling:

<!DOCTYPE html>
<html>
<head> <style> FRAME { border: 2px solid red; } </style> </head>
<frameset title="Main" rows="35%,*" frameborder="1" border="1">
  <frame title="Banner" src="about:blank">
    <frameset cols="25%,*">
      <frame style="border-right: 1px solid black;" title="Left" src="about:blank">
      <frame title="Right" src="about:blank">
    </frameset>
  </frameset>
</html>

2. Load the page into the browser


What is the expected result?

There should be three frames with red borders, except the bottom left which has a black right border.

What happens instead of that?

There are three frames with standard borders.

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36
Frameset-Chrome.png
27.1 KB View Download
Frameset-Edge.png
18.7 KB View Download

Comment 1 by woxxom@gmail.com, Nov 6 

Bisected to r578640 = 112f71fce5ea31c1a4a92a2161a2d3ba77b20b35 = https://crrev.com/c/1150866 by trchen@chromium.org
"Reland: [Blink] Unify replaced element clipping"
Landed in 70.0.3505.0

Comment 2 by dtapu...@chromium.org, Nov 6

Components: Blink>Paint

Comment 3 by schenney@chromium.org, Nov 6

Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
I wish we could kill FrameSet. Over to wangxianzhu@ for further triage.

Comment 4 by darnold....@gmail.com, Nov 7 

Just for further information, my colleague has a similar corporate setup as me except that he has a Surface 2 and I have a Surface Book 2.
When he has the window open on the Surface display some of the styling is displayed, however when he drags the window to the attached monitor the styling disappears when it is about 3/4 of the way across.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0699cfa24f4ffa9aefe92e4e64ce43342e15f99

commit a0699cfa24f4ffa9aefe92e4e64ce43342e15f99
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Nov 09 00:30:29 2018

[PE] Fix border of frame under frameset

FrameSetPainter paints everything in the foreground phase, so
a frame under frameset should paint its box decoration background
in the foreground phase.

Bug:  902274 
Change-Id: Id56af37a478b8503f17199753a485f6fe1261c95
Reviewed-on: https://chromium-review.googlesource.com/c/1326205
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606650}
[add] https://crrev.com/a0699cfa24f4ffa9aefe92e4e64ce43342e15f99/third_party/WebKit/LayoutTests/paint/frames/frameset-frame-border-expected.html
[add] https://crrev.com/a0699cfa24f4ffa9aefe92e4e64ce43342e15f99/third_party/WebKit/LayoutTests/paint/frames/frameset-frame-border.html
[modify] https://crrev.com/a0699cfa24f4ffa9aefe92e4e64ce43342e15f99/third_party/blink/renderer/core/paint/replaced_painter.cc
[modify] https://crrev.com/a0699cfa24f4ffa9aefe92e4e64ce43342e15f99/third_party/blink/renderer/core/paint/replaced_painter.h

Comment 6 by wangxianzhu@chromium.org, Nov 9

Status: Fixed (was: Assigned)
►

Sign in to add a comment