New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 902268 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Flaky telemetry_unittests (experimental): testSuccessfullyStartBrowserWithSystemCacheClearOptions

Project Member Reported by hbos@chromium.org, Nov 6

Issue description

For the last 200 runs (or more, the history doesn't go further back) the "telemetry_unittests (experimental)" have been flaking on Windows-10-15063.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29?limit=200

Typically it's this one:
telemetry.internal.browser.browser_unittest.TestBrowserCreation.testSuccessfullyStartBrowserWithSystemCacheClearOptions

Example:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/4131

The "telemetry_unittests (experimental)" failures don't turn the bot red, but they keep showing up in the Sheriff-o-Matic and marks most of the runs as failures.

I would disable the test but I don't know how to do that because this is third_party/catapult. I also don't know what it means that this is "experimental".
 
nednguyen@ can you take a look or retriage? It would be good if we could disable the flaking tests, until then this has Sheriff-Chromium label.
Components: -Tests>Telemetry Speed>Telemetry
Components: Tests>Flaky
Previous sheriffs have argued that it's not high priority because it's experimental but considering this has been flaking for 200+ runs I think P-1 may be in order until the tests are at least disabled?
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/6ba6af1e543b60cced283cf7490d81415fe934d1

commit 6ba6af1e543b60cced283cf7490d81415fe934d1
Author: Nghia Nguyen <nednguyen@google.com>
Date: Tue Nov 06 14:12:34 2018

Disable testSuccessfullyStartBrowserWithSystemCacheClearOptions on win10

Bug: chromium:902268
Change-Id: I0e45b915ee38b82ef8f239b9ac73a35f1654444e

TBR=crouleau@chromium.org

Change-Id: I0e45b915ee38b82ef8f239b9ac73a35f1654444e
Reviewed-on: https://chromium-review.googlesource.com/c/1319259
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/6ba6af1e543b60cced283cf7490d81415fe934d1/telemetry/telemetry/internal/browser/browser_unittest.py

Labels: -Sheriff-Chromium
Thanks, we should be able to remove the label now.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71c2e690ee2574019b7222f8002c27d664a12bf5

commit 71c2e690ee2574019b7222f8002c27d664a12bf5
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Nov 06 15:38:43 2018

Roll src/third_party/catapult 9a5dbc6f4454..6ba6af1e543b (1 commits)

https://chromium.googlesource.com/catapult.git/+log/9a5dbc6f4454..6ba6af1e543b


git log 9a5dbc6f4454..6ba6af1e543b --date=short --no-merges --format='%ad %ae %s'
2018-11-06 nednguyen@google.com Disable testSuccessfullyStartBrowserWithSystemCacheClearOptions on win10


Created with:
  gclient setdep -r src/third_party/catapult@6ba6af1e543b

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:902268
TBR=sullivan@chromium.org

Change-Id: I276b3d0931fe789e59d6d653857695421b46908e
Reviewed-on: https://chromium-review.googlesource.com/c/1319383
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605686}
[modify] https://crrev.com/71c2e690ee2574019b7222f8002c27d664a12bf5/DEPS

Comment 8 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 9 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment