New issue
Advanced search Search tips

Issue 902228 link

Starred by 3 users
Status: Fixed
Owner:
pbos@chromium.org
Closed: Dec 19
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Weird overlapping of icon and text is observe in omnibox while reloading NTP.

Reported by db...@etouch.net, Nov 6 
Chrome Version:72.0.3602.2 Revision 0a902853e0533619bf95966c9ecc4993cc6cb940-refs/branch-heads/3602@{#4}(32/64 bit)
OS: Windows(7,8,8.1,10), Mac (10.13.1, 10.13.6, 10.14.1) and Linux(14.04)

What steps will reproduce the problem?
(1) Launch chrome, open NTP and reload it.
(2) Observe in omnibox while reloading NTP.

Actual: Weird overlapping of icon and text is observe in omnibox while reloading NTP.

Expected: No such a overlapping should seen.

This is a regression issue, broken in 'M72', below is bisect info:

Good Build:72.0.3596.0(Revision: 603701)
Bad Build: 72.0.3598.0(Revision: 604471)
Chromium bisect info:

You are probably looking for a change made after 591108 (known good), but no later than 591109 (first known bad).

CHANGE-LOG URL:
  
https://chromium.googlesource.com/chromium/src/+log/b74072a0ef3004865cb0e4d73ea66bdd24acec18..18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3?pretty=fuller&n=100


Suspecting: https://chromium.googlesource.com/chromium/src/+/18a40fa1b32e4daccf4ea0d9824b38c13fcc9ac3

@rbpotter : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1) Providing suspect using chromium bisect script because unable to perform bisect using 'per-revision' script.
2) Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting following error:
   - Error message on Mac OS:[Errno 2] No such file or directory error message
   - Error message on Windows OS: RuntimeError: We don't have enough builds to bisect.

Kindly refer the attached screen-cast.

Thank you..!
Actual_Reload.mp4
519 KB View Download
Expected_Reload.mp4
358 KB View Download

Comment 1 by twelling...@chromium.org, Nov 6

Labels: zine-triaged
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9a4e7095e587d2e9fcb2117a0e496ee51064222

commit d9a4e7095e587d2e9fcb2117a0e496ee51064222
Author: Peter Boström <pbos@chromium.org>
Date: Wed Dec 19 03:20:12 2018

Hide tab icon when navigating to chrome://newtab

This change prevents refreshing "chrome://newtab" from flickering due to
the loading animation playing during refresh while it's navigating.

Bug:  chromium:902228 
Change-Id: Ifc734b67313ae2ce060e81fba9ce48e638c99190
Reviewed-on: https://chromium-review.googlesource.com/c/1373133
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617718}
[modify] https://crrev.com/d9a4e7095e587d2e9fcb2117a0e496ee51064222/chrome/browser/favicon/favicon_utils.cc

Comment 3 by gayane@chromium.org, Dec 19

Components: -UI>Browser>NewTabPage UI>Browser>TabStrip

Comment 4 by pbos@chromium.org, Dec 19

Status: Fixed (was: Assigned)

Comment 5 by dipt...@virtusa.com, Dec 20

Labels: TE-Verified-M73 TE-Verified-73.0.3646.0
Update:

Above issue is fixed on latest canary build #73.0.3646.0 using Windows(7,8,8.1,10), Mac (10.13.1, 10.13.6, 10.14.1) and Linux(14.04) OS.

Hence adding TE-Verified labels.

Thank you.
Fix_Issue.mp4
319 KB View Download
►

Sign in to add a comment