Integration tests for proxy API |
||||||
Issue descriptionI can't find any integration tests for the new proxy API. Although this got unit tested in the relevant CLs, this doesn't cover the integration with WebView (and that code could therefore break). Specifically, the proxy code doesn't currently work with the network service, yet this isn't visible in our test filter: https://cs.chromium.org/chromium/src/testing/buildbot/filters/mojo.fyi.network_webview_instrumentation_test_apk.filter Can we add integration tests?
,
Nov 6
We're gonna have tests in the support library and CTS when it's implemented in the framework. Do we need any additional tests?
,
Nov 6
The issue is that chromium developers aren't generally aware of CTS or AndroidX. Chromium-side integration tests offer more visibility to these developers (so, they know if they break our code). Another advantage to integration tests is that they run on CQ (presubmit) where CTS runs on a separate bot (postsubmit).
,
Nov 7
,
Nov 13
,
Dec 27
,
Jan 16
(Bulk edit to add component)
,
Jan 16
(6 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c5b7240984937fe41ca7fa76bab6d8c8dd1c215 commit 8c5b7240984937fe41ca7fa76bab6d8c8dd1c215 Author: Laís Minchillo <laisminchillo@chromium.org> Date: Wed Jan 16 10:23:16 2019 [aw] Add proxy override integration tests Bug: 902215 Change-Id: Ibac9527580253aa924ed8c553bb5f01f47e368aa Reviewed-on: https://chromium-review.googlesource.com/c/1391561 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Cr-Commit-Position: refs/heads/master@{#623179} [add] https://crrev.com/8c5b7240984937fe41ca7fa76bab6d8c8dd1c215/android_webview/javatests/src/org/chromium/android_webview/test/AwProxyControllerTest.java [modify] https://crrev.com/8c5b7240984937fe41ca7fa76bab6d8c8dd1c215/android_webview/test/BUILD.gn [modify] https://crrev.com/8c5b7240984937fe41ca7fa76bab6d8c8dd1c215/testing/buildbot/filters/mojo.fyi.network_webview_instrumentation_test_apk.filter
,
Jan 16
(6 days ago)
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by timvolod...@chromium.org
, Nov 6