clients.matchAll({includeUncontrolled: true, type: 'sharedworker'}) causes DCHECK failure |
||
Issue description
clients.matchAll({includeUncontrolled: true, type: 'sharedworker'}) causes DCHECK failure as follows:
[109986:109997:1106/112635.093626:FATAL:struct_ptr.h(170)] Check failed: state_ == VALID.
#0 0x7f64245182dd base::debug::StackTrace::StackTrace()
#1 0x7f642420ecfa base::debug::StackTrace::StackTrace()
#2 0x7f64242809db logging::LogMessage::~LogMessage()
#3 0x7f641efdc1c1 mojo::InlinedStructPtr<>::operator->()
#4 0x7f64210671bc content::service_worker_client_utils::(anonymous namespace)::AddNonWindowClient()
#5 0x7f6421062cc7 content::service_worker_client_utils::(anonymous namespace)::GetNonWindowClients()
#6 0x7f6421060737 content::service_worker_client_utils::GetClients()
#7 0x7f64211f4510 content::ServiceWorkerVersion::GetClients()
#8 0x7f64181c54a1 blink::mojom::ServiceWorkerHostStubDispatch::AcceptWithResponder()
#9 0x7f64211fe5b0 blink::mojom::ServiceWorkerHostStub<>::AcceptWithResponder()
#10 0x7f642469c3f3 mojo::InterfaceEndpointClient::HandleValidatedMessage()
#11 0x7f642469b9c1 mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept()
#12 0x7f6424699e72 mojo::FilterChain::Accept()
#13 0x7f642469fbd5 mojo::InterfaceEndpointClient::HandleIncomingMessage()
#14 0x7f64246ac68b mojo::internal::MultiplexRouter::ProcessIncomingMessage()
#15 0x7f64246abbd5 mojo::internal::MultiplexRouter::Accept()
#16 0x7f6424699e72 mojo::FilterChain::Accept()
#17 0x7f642468b28b mojo::Connector::ReadSingleMessage()
#18 0x7f642468c4d1 mojo::Connector::ReadAllAvailableMessages()
#19 0x7f642468c1f5 mojo::Connector::OnHandleReadyInternal()
#20 0x7f642468c0db mojo::Connector::OnWatcherHandleReady()
<snip>
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd142b47b0be63a7f8b88bf09cbfe781c0d48989 commit dd142b47b0be63a7f8b88bf09cbfe781c0d48989 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Tue Nov 06 06:37:36 2018 ServiceWorker: Modernize clients-matchall-include-uncontrolled.https.html using async/await Bug: 902201 Change-Id: Ib9fd5a5f0e9cc49cf653b6af768d00912c008deb Reviewed-on: https://chromium-review.googlesource.com/c/1319392 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#605617} [modify] https://crrev.com/dd142b47b0be63a7f8b88bf09cbfe781c0d48989/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-include-uncontrolled.https.html
,
Nov 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7fdd0287a1cf7483dff3917ef91767101bc99fb7 commit 7fdd0287a1cf7483dff3917ef91767101bc99fb7 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Tue Nov 06 07:53:20 2018 ServiceWorker: Pass client_type by value in for-loops Bug: 902201 Change-Id: I55613be57c363aa9d396108826e21643006ad224 Reviewed-on: https://chromium-review.googlesource.com/c/1319221 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#605626} [modify] https://crrev.com/7fdd0287a1cf7483dff3917ef91767101bc99fb7/content/browser/service_worker/service_worker_client_utils.cc
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/743c147652005b9c5b0ad395179b9fbac8e4942f commit 743c147652005b9c5b0ad395179b9fbac8e4942f Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Wed Nov 07 05:24:28 2018 ServiceWorker: Add WPTs for Clients.matchAll() with uncontrolled shared workers Bug: 902201 Change-Id: I18e4dc822a5440bbe4b3c01092da7c137984a9a3 Reviewed-on: https://chromium-review.googlesource.com/c/1319216 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#605967} [modify] https://crrev.com/743c147652005b9c5b0ad395179b9fbac8e4942f/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/clients-matchall-include-uncontrolled.https.html
,
Nov 7
|
||
►
Sign in to add a comment |
||
Comment 1 by nhiroki@google.com
, Nov 6