New issue
Advanced search Search tips

Issue 902196 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

TabDiscarder model V2

Project Member Reported by charleszhao@chromium.org, Nov 6

Issue description

These are the new model we want to try.

(1) a discarded model based on current logging.

(2) a new reactivation model based on current logging.

(3) a discarded model based on new logging.

(4) a new reactivation model based on new logging.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e86f89f58583540677abc200a43a24ab184949f

commit 5e86f89f58583540677abc200a43a24ab184949f
Author: Charles Zhao <charleszhao@chromium.org>
Date: Thu Nov 15 03:20:14 2018

TabRanker: Change to a new model trained on discarded data only.

Changes made in this CL:

(1) new preprocessor_config.pb and new native_inference weights.

(2) the native_inference.cc logic is also changed a bit because new
    quantized model does not have dequantization any more.

(3) only kept 'score tests' to confirm this model returns same result
    as the model trained in google3. Other 'expectation tests' are all
    removed, because we have to fix them for every new model. Instead
    we do a full feature analysis before submit the model to verify
    that.

Bug: 902196

Change-Id: I3dd4382f750b9216369c7de14edd9c692cf6db71
Reviewed-on: https://chromium-review.googlesource.com/c/1319209
Commit-Queue: Charles . <charleszhao@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608243}
[modify] https://crrev.com/5e86f89f58583540677abc200a43a24ab184949f/chrome/browser/resource_coordinator/tab_ranker/example_preprocessor_config.pb
[modify] https://crrev.com/5e86f89f58583540677abc200a43a24ab184949f/chrome/browser/resource_coordinator/tab_ranker/native_inference.cc
[modify] https://crrev.com/5e86f89f58583540677abc200a43a24ab184949f/chrome/browser/resource_coordinator/tab_ranker/native_inference.h
[modify] https://crrev.com/5e86f89f58583540677abc200a43a24ab184949f/chrome/browser/resource_coordinator/tab_ranker/tab_score_predictor.cc
[modify] https://crrev.com/5e86f89f58583540677abc200a43a24ab184949f/chrome/browser/resource_coordinator/tab_ranker/tab_score_predictor_unittest.cc

Sign in to add a comment