New issue
Advanced search Search tips

Issue 902171 link

Starred by 1 user
Status: Fixed
Owner:
sky@chromium.org
Closed: Dec 10
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 878200



Sign in to add a comment

NonClientFrameControllerMashTest.ContentRegionNotDrawnForClient fails

Project Member Reported by est...@chromium.org, Nov 6 
This test fails in single and multi process mash. It crashes because the fake context factory is set on the wrong aura::Env in SetUp, so it never gets a frame sink and GetLastCompositorFrame() derefs null.

I tried changing the test initialization so it made ash_test_helper() aware of the fake context factory instead of using the one from ui::InitializeContextFactoryForTests, which got the test a little farther but it still failed:

Value of: FindColorQuad(frame, kTileBounds, SK_ColorBLACK)
  Actual: false
Expected: true

(that's the first FindColorQuad call in the test). Sadrul seems to have written the test, so perhaps he knows what to do.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38dcb5ed0137923d9b1f758a8d8ddf7b0035c86c

commit 38dcb5ed0137923d9b1f758a8d8ddf7b0035c86c
Author: Evan Stade <estade@chromium.org>
Date: Wed Nov 07 01:50:24 2018

Add bug link for disabled mash ash unittest

Bug:  902171 
Change-Id: I13860617a1531a98f87a5af1d342bd69ef781976
Reviewed-on: https://chromium-review.googlesource.com/c/1318841
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605924}
[modify] https://crrev.com/38dcb5ed0137923d9b1f758a8d8ddf7b0035c86c/testing/buildbot/filters/chromeos.single_process_mash.ash_unittests.filter

Comment 2 by weifangsun@chromium.org, Nov 8 

<UI triage> Bug owners, please add the appropriate component to your bug. Thanks!

Comment 3 by steve...@chromium.org, Dec 5

Blocking: 878200

Comment 4 by sky@chromium.org, Dec 7

Owner: sky@chromium.org
Status: Started (was: Untriaged)

Comment 5 by sky@chromium.org, Dec 10 

This test was written when ash ran with aura configure with MUS. That is no longer the case, so this test doesn't make sense. Will remove it.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddfbb23b27bc4448ce118a9f80eb31bf4a9dd20e

commit ddfbb23b27bc4448ce118a9f80eb31bf4a9dd20e
Author: Scott Violet <sky@chromium.org>
Date: Mon Dec 10 18:01:49 2018

chromeos: removes ContentRegionNotDrawnForClient test

This test was written at a time when ash was a client of the window service
and ran with an aura::Env::Mode of MUS. That's no longer the case, so this
test doesn't make sense.

BUG= 902171 
TEST=test only change

Change-Id: I4eadb97b60a89b26c10dd1242d3e2f869e810969
Reviewed-on: https://chromium-review.googlesource.com/c/1370193
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615170}
[modify] https://crrev.com/ddfbb23b27bc4448ce118a9f80eb31bf4a9dd20e/ash/wm/non_client_frame_controller_unittest.cc
[modify] https://crrev.com/ddfbb23b27bc4448ce118a9f80eb31bf4a9dd20e/testing/buildbot/filters/chromeos.single_process_mash.ash_unittests.filter

Comment 7 by sky@chromium.org, Dec 10

Status: Fixed (was: Started)
►

Sign in to add a comment