New issue
Advanced search Search tips

Issue 902161 link

Starred by 1 user
Status: Fixed
Owner:
qnnguyen@chromium.org
Closed: Nov 6
Cc:
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove system salt from authentication process

Project Member Reported by qnnguyen@chromium.org, Nov 6 
The system salt is no longer used by the authentication flow. We should remove the GetSystemSalt step in LoginScreenController::AuthenticateUserWithPasswordOrPin.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f522435e5d436358e984c8cdeaec5497c122e993

commit f522435e5d436358e984c8cdeaec5497c122e993
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Tue Nov 06 02:03:34 2018

cros: Remove system salt fetch in DoAuthenticateUser

The system salt is no longer needed for authentication.
Also remove unused PendingDoAuthenticateUser declaration.

Bug:  902161 
Change-Id: I7920f2975cf4b547149caa2d0c7056085d6dab2a
Reviewed-on: https://chromium-review.googlesource.com/c/1318632
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605568}
[modify] https://crrev.com/f522435e5d436358e984c8cdeaec5497c122e993/ash/login/login_screen_controller.cc
[modify] https://crrev.com/f522435e5d436358e984c8cdeaec5497c122e993/ash/login/login_screen_controller.h

Comment 2 by qnnguyen@chromium.org, Nov 6

Status: Fixed (was: Untriaged)
►

Sign in to add a comment